----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63372/#review198404 -----------------------------------------------------------
docs/memory-profiling.md Lines 22 (patched) <https://reviews.apache.org/r/63372/#comment278531> Ain't it called `--enable-jemalloc-allocator`? docs/memory-profiling.md Lines 49 (patched) <https://reviews.apache.org/r/63372/#comment278537> This endpoint spits out a huge JSON file even on a fresh master without any load. Maybe it makes sense to say what might be interesting / what this JSON includes; including JSON schema would also be great. docs/memory-profiling.md Lines 95-97 (patched) <https://reviews.apache.org/r/63372/#comment278538> How a user gets a compatible `jeprof` installed? Do we expect them to figure out the bundled version of jemalloc and then figure out how to get and install jeprof onto the machine? Can we do it ourselves during the configure step? Or maybe better have memory-profiler use the bundled jeprof? - Alexander Rukletsov On Jan. 24, 2018, 4:40 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63372/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2018, 4:40 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > Added documentation for memory profiling. > > > Diffs > ----- > > docs/memory-profiling.md PRE-CREATION > > > Diff: https://reviews.apache.org/r/63372/diff/3/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
