Re: Review Request 66293: Tested default executor support of `max_completion_time`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/#review200714 --- PASS: Mesos patch 66293 was successfully built and tested.

Re: Review Request 66481: Converted `pid` in command executor to `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66481/#review200713 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66293: Tested default executor support of `max_completion_time`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66293/ --- (Updated April 7, 2018, 5:54 p.m.) Review request for mesos, Jason Lai and

Re: Review Request 66291: Added support to `max_completion_time` in default executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66291/ --- (Updated April 7, 2018, 5:53 p.m.) Review request for mesos, Jason Lai and

Re: Review Request 66284: Tested `max_completion_time` support in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66284/ --- (Updated April 7, 2018, 5:53 p.m.) Review request for mesos, Jason Lai and

Re: Review Request 66283: Added support of `max_completion_time` in docker executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66283/ --- (Updated April 7, 2018, 5:52 p.m.) Review request for mesos, Jason Lai and

Re: Review Request 66260: Tested `max_completion_time` support in command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66260/ --- (Updated April 7, 2018, 5:52 p.m.) Review request for mesos, Jason Lai and

Re: Review Request 66259: Added `max_completion_time` support to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66259/ --- (Updated April 7, 2018, 5:51 p.m.) Review request for mesos, Jason Lai and

Re: Review Request 66258: Added `max_completion_time` to `TaskInfo` and new reason.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66258/ --- (Updated April 7, 2018, 5:51 p.m.) Review request for mesos, Jason Lai and

Re: Review Request 66481: Converted `pid` in command executor to `Option`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66481/ --- (Updated April 7, 2018, 5:50 p.m.) Review request for mesos, Andrew

Re: Review Request 66481: Converted `pid` in command executor to `Option`.

> On April 5, 2018, 5:01 p.m., James Peach wrote: > > I think we should just change all the usages of `pid` rather than renaming > > it to `pid_`. Fixed. - Zhitao --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 66493: Made FreeBSD default to non-GNU ld.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66493/#review200707 --- Patch looks great! Reviews applied: [66493] Passed command:

Re: Review Request 66445: Windows: Cleaned up included CRT headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66445/#review200705 --- Patch looks great! Reviews applied: [66420, 66421, 66422, 66423,

Re: Review Request 66493: Made FreeBSD default to non-GNU ld.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66493/#review200704 --- FAIL: Some of the unit tests failed. Please check the relevant

Review Request 66493: Made FreeBSD default to non-GNU ld.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66493/ --- Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier. Bugs: