Re: Review Request 67244: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67244/#review203552 --- PASS: Mesos patch 67244 was successfully built and tested.

Review Request 67244: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67244/ --- Review request for mesos. Repository: mesos Description --- To reduce

Re: Review Request 67244: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67244/ --- (Updated May 22, 2018, 4:02 a.m.) Review request for mesos, James Peach and

Re: Review Request 67243: Windows: Changed test image to custom nanoserver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67243/#review203551 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 67243: Windows: Changed test image to custom nanoserver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67243/ --- (Updated May 22, 2018, 1:39 a.m.) Review request for mesos and Andrew

Re: Review Request 67224: Combined and renamed `csi_*_plugin_terminations` metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67224/#review203550 --- Patch looks great! Reviews applied: [65665, 65666, 67224]

Review Request 67243: Windows: Changed test image to custom nanoserver.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67243/ --- Review request for mesos and Andrew Schwartzmeyer. Bugs: MESOS-8499

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203547 --- PASS: Mesos patch 67241 was successfully built and tested.

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203545 --- src/slave/containerizer/mesos/isolators/volume/secret.cpp Lines

Re: Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203544 --- src/slave/containerizer/mesos/io/switchboard.cpp Lines 310-311

Review Request 67241: Added isolator logs for volume/secret isolator and container logger.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/ --- Review request for mesos, Gaston Kleiman, Jie Yu, Qian Zhang, and Vinod Kone.

Re: Review Request 67238: Fixed a quota-related metrics bug.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67238/#review203542 --- PASS: Mesos patch 67238 was successfully built and tested.

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

> On May 21, 2018, 7:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/devices.cpp > > Lines 170-175 (patched) > > > > > > Any reason we only do that for the directory, not the actual device

Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

> On May 21, 2018, 8:56 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 577 (patched) > > > > > > This is more complicated than it needs to be. You can simply do

Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive.

> On May 17, 2018, 11:59 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/archiver.hpp > > Lines 93 (patched) > > > > > > Does libarchive really require a CRT file descriptor, it's not happy > >

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

> On May 21, 2018, 7:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/devices.cpp > > Lines 170-175 (patched) > > > > > > Any reason we only do that for the directory, not the actual device

Re: Review Request 67238: Fixed a quota-related metrics bug.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67238/#review203531 --- Ship it! - Benjamin Mahler On May 21, 2018, 10:13 p.m., Greg

Review Request 67238: Fixed a quota-related metrics bug.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67238/ --- Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and

Re: Review Request 67065: Added a new stout utility header file which interfaces with libarchive.

> On May 17, 2018, 11:59 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/archiver.hpp > > Lines 68-70 (patched) > > > > > > Wait, this is C++, can't we `s/struct archive/archive`? (Thinking aloud

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

> On May 21, 2018, 7:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/devices.cpp > > Lines 170-175 (patched) > > > > > > Any reason we only do that for the directory, not the actual device

Re: Review Request 67064: Added libarchive, bzip2, and xz patches and associated build changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67064/#review203511 --- 3rdparty/CMakeLists.txt Lines 758-759 (patched)

Re: Review Request 67235: Added per-framework metrics for types of resources contained in offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67235/#review203522 --- PASS: Mesos patch 67235 was successfully built and tested.

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

> On May 21, 2018, 7:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/devices.cpp > > Lines 170-175 (patched) > > > > > > Any reason we only do that for the directory, not the actual device

Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/#review203521 --- Also, please remove the review URL from the commit message. The

Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/#review203502 --- src/slave/containerizer/mesos/isolators/network/ports.hpp Lines

Re: Review Request 67236: Windows: Removed unnecessary dependencies from `windows/error.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67236/ --- (Updated May 21, 2018, 1:35 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 67236: Windows: Removed unnecessary dependencies from `windows/error.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67236/#review203518 --- Ship it! Ship It! - Joseph Wu On May 21, 2018, 1:16 p.m.,

Re: Review Request 67236: Windows: Removed unnecessary dependencies from `windows/error.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67236/ --- (Updated May 21, 2018, 1:16 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 67236: Windows: Removed unnecessary dependencies from `windows/error.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67236/ --- (Updated May 21, 2018, 1:13 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 67236: Windows: Removed unnecessary dependencies from `windows/error.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67236/ --- (Updated May 21, 2018, 1:11 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

> On May 18, 2018, 5:26 p.m., Greg Mann wrote: > > src/slave/containerizer/composing.cpp > > Line 669 (original), 618 (patched) > > > > > > Why return `wait()` when the state is DESTROYING, rather than just > >

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

> On May 18, 2018, 5:26 p.m., Greg Mann wrote: > > src/slave/containerizer/composing.cpp > > Line 669 (original), 618 (patched) > > > > > > Why return `wait()` when the state is DESTROYING, rather than just > >

Re: Review Request 67236: Windows: Removed unnecessary dependencies from `windows/error.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67236/ --- (Updated May 21, 2018, 12:58 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 67097: Added `linux/devices` isolator whitelist support.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67097/#review203515 --- Fix it, then Ship it!

Re: Review Request 67236: Windows: Removed unnecessary dependencies from `windows/error.hpp`.

> On May 21, 2018, 12:11 p.m., Chun-Hung Hsiao wrote: > > 3rdparty/stout/include/stout/windows/error.hpp > > Line 88 (original), 85 (patched) > > > > > > ``` > > so we can avoid needing Unicode conversion here. >

Re: Review Request 67236: Windows: Removed unnecessary dependencies from `windows/error.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67236/#review203513 --- Fix it, then Ship it!

Re: Review Request 67235: Added per-framework metrics for types of resources contained in offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67235/ --- (Updated May 21, 2018, 7:03 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 67236: Windows: Removed unnecessary dependencies from `windows/error.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67236/ --- Review request for mesos, Chun-Hung Hsiao and Joseph Wu. Repository: mesos

Review Request 67235: Added per-framework metrics for types of resources contained in offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67235/ --- Review request for mesos, Benjamin Mahler, Gaston Kleiman, Gilbert Song, and

Re: Review Request 67217: Ensured `SlaveRegisteredMessage`s trigger appropriate expectations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67217/#review203510 --- Patch looks great! Reviews applied: [67217] Passed command:

Re: Review Request 67188: Windows: Implemented `os::shell` and enabled tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67188/ --- (Updated May 21, 2018, 11 a.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

> On May 18, 2018, 4:57 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 87 (patched) > > > > > > I small nits, i'd suggest the following to make the logic a bit easier > > to understand: > >

Re: Review Request 65811: Add `path::normalize` to stout for normalizing path (for POSIX only now)

> On May 18, 2018, 4:57 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/path.hpp > > Lines 87 (patched) > > > > > > I small nits, i'd suggest the following to make the logic a bit easier > > to understand: > >

Re: Review Request 67212: Used `*_SOME` macro for checking `Try` values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67212/#review203503 --- Bad patch! Reviews applied: [67212, 67211, 67210] Failed

Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/ --- (Updated May 21, 2018, 4:14 p.m.) Review request for mesos, James Peach and

Re: Review Request 66871: Added documentation about new gauge on `master/subscribers_active`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66871/#review203501 --- Fix it, then Ship it! docs/monitoring.md Lines 845 (patched)

Re: Review Request 67215: Opened subprocess pipes with `O_CLOEXEC`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67215/#review203500 --- 3rdparty/libprocess/src/subprocess_posix.cpp Line 50 (original),

Re: Review Request 66670: Ensured that `wait()` and `destroy()` return the same result.

> On May 10, 2018, 8:52 p.m., Qian Zhang wrote: > > src/slave/containerizer/composing.cpp > > Line 621 (original), 629-632 (patched) > > > > > > Similarly, I am wondering if we can reach here for a nested container.

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8/#review203490 --- Can you please explain how the container will be cleaned up from

Re: Review Request 66668: Removed `destroyed` from `Container` struct in composing containerizer.

> On May 19, 2018, 1:26 a.m., Greg Mann wrote: > > src/slave/containerizer/composing.cpp > > Line 669 (original), 618 (patched) > > > > > > Why return `wait()` when the state is DESTROYING, rather than just > >

Re: Review Request 67136: Added a function to get rlimits.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67136/#review203486 --- Patch looks great! Reviews applied: [67136] Passed command:

Re: Review Request 67177: Sorted container mounts by their target paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67177/#review203482 --- Ship it! Ship It! - Eric Chung On May 17, 2018, 1:28 a.m.,