----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67241/#review203544 -----------------------------------------------------------
src/slave/containerizer/mesos/io/switchboard.cpp Lines 310-311 (patched) <https://reviews.apache.org/r/67241/#comment285835> I'd print out some infomation that's relevant to this isolator for us to determine the following condition `requiresServer`. For example, if the container has tty specified. - Jie Yu On May 21, 2018, 11:44 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67241/ > ----------------------------------------------------------- > > (Updated May 21, 2018, 11:44 p.m.) > > > Review request for mesos, Gaston Kleiman, Jie Yu, Qian Zhang, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added isolator logs for volume/secret isolator and container logger. > > > Diffs > ----- > > src/slave/containerizer/mesos/io/switchboard.cpp > 517d45903bc5095f2f954b95feb61c8717d395f0 > src/slave/containerizer/mesos/isolators/volume/secret.cpp > 8071e4ee808bc825b13a6291767778d6ce3c2746 > > > Diff: https://reviews.apache.org/r/67241/diff/1/ > > > Testing > ------- > > > Thanks, > > Gilbert Song > >
