Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66649/#review204442 --- Patch looks great! Reviews applied: [66649] Passed command:

Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66649/#review204441 --- PASS: Mesos patch 66649 was successfully built and tested.

Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66649/ --- (Updated June 7, 2018, 1:12 a.m.) Review request for mesos, Armand Grillet,

Re: Review Request 67421: Rewrote the `ROOT_BusyMountPoint` test to reflect updated behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67421/#review204440 --- Patch looks great! Reviews applied: [67264, 67423, 67421]

Re: Review Request 67381: Added `cgroups/all` into CHANGELOG and upgrades.md.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67381/#review204439 --- Fix it, then Ship it! docs/upgrades.md Lines 451 (patched)

Re: Review Request 67358: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_PERF_AutoLoadSubsystems`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67358/#review204437 --- Ship it! Ship It! - Gilbert Song On May 30, 2018, 6:10

Re: Review Request 67343: Automatically loaded all the local enabled cgroups subsystems.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67343/#review204434 --- Ship it! Ship It! - Gilbert Song On May 31, 2018, 8:21

Re: Review Request 67342: Added `cgroups/all` into the agent flag `--isolation`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67342/#review204433 --- Ship it! Ship It! - Gilbert Song On May 31, 2018, 8:20

Re: Review Request 67476: Added guideline for contributions modifying Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67476/#review204431 --- Patch looks great! Reviews applied: [67476] Passed command:

Re: Review Request 67478: Addition to contributors.yaml in peparation for submitting an actual patch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67478/#review204417 --- PASS: Mesos patch 67478 was successfully built and tested.

Re: Review Request 66652: Renamed local_puller to image_tar_puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66652/#review204408 --- Patch looks great! Reviews applied: [66559, 66650, 66651, 66561,

Review Request 67478: Addition to contributors.yaml in peparation for submitting an actual patch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67478/ --- Review request for mesos. Repository: mesos Description --- Addition to

Re: Review Request 67421: Rewrote the `ROOT_BusyMountPoint` test to reflect updated behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67421/#review204406 --- PASS: Mesos patch 67421 was successfully built and tested.

Re: Review Request 66561: Supported hdfs fetching in local puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66561/ --- (Updated June 6, 2018, 10:14 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 67464: Fixed `python3/mesos-style.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67464/#review204403 --- Ship it! Ship It! - Armand Grillet On June 5, 2018, 11:15

Re: Review Request 67476: Added guideline for contributions modifying Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67476/#review204402 --- PASS: Mesos patch 67476 was successfully built and tested.

Re: Review Request 66561: Supported hdfs fetching in local puller.

> On June 6, 2018, 8:57 a.m., Qian Zhang wrote: > > docs/configuration/agent.md > > Line 626 (original), 626 (patched) > > > > > > s/a HDFS/an HDFS/ +1 > On June 6, 2018, 8:57 a.m., Qian Zhang wrote: > >

Re: Review Request 66561: Supported hdfs fetching in local puller.

> On April 18, 2018, 2:48 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > > Lines 133 (patched) > > > > > > In which case can `host.empty()` be `true`? E.G.,

Re: Review Request 66562: Added test for local puller hdfs uri fetcher plugin.

> On April 18, 2018, 9:24 p.m., Qian Zhang wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp > > Lines 493-517 (patched) > > > > > > Can you use raw string literal to avoid escaping? > > Gilbert Song

Re: Review Request 66561: Supported hdfs fetching in local puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66561/#review204397 --- Fix it, then Ship it! docs/configuration/agent.md Line 626

Re: Review Request 67357: Added constant time comparison of JWT signatures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67357/#review204398 --- PASS: Mesos patch 67357 was successfully built and tested.

Re: Review Request 67472: Fixed CppLinter in python3/mesos-style.py to use correct linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67472/#review204396 --- Patch looks great! Reviews applied: [67472] Passed command:

Re: Review Request 67425: [WIP] Implement a JWK Set parser converting JWKs into RSA keys.

> On June 4, 2018, 4:04 p.m., Alexander Rojas wrote: > > Before going into detail with this, last patchset we forgot to add certain > > files to the install target wich ended up breaking tarball generation. > > Mostly a failure of your reviewers (myself included). Since you are adding > > new

Review Request 67476: Added guideline for contributions modifying Makefile.am.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67476/ --- Review request for mesos and Greg Mann. Repository: mesos Description

Re: Review Request 67357: Added constant time comparison of JWT signatures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67357/ --- (Updated June 6, 2018, 3:34 p.m.) Review request for mesos and Alexander

Re: Review Request 67472: Fixed CppLinter in python3/mesos-style.py to use correct linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67472/#review204388 --- Ship it! Ship It! - Alexander Rojas On June 6, 2018, 9:41

Re: Review Request 67357: Added constant time comparison of JWT signatures.

> On June 6, 2018, 11:58 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/jwt.cpp > > Lines 213 (patched) > > > > > > To avoid conversions and integral promotions, does it make sense to say > > here > >

Re: Review Request 67357: Added constant time comparison of JWT signatures.

> On June 6, 2018, 12:26 p.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['67357']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > >

Re: Review Request 67421: Rewrote the `ROOT_BusyMountPoint` test to reflect updated behavior.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67421/#review204382 --- Patch looks great! Reviews applied: [67264, 67423, 67421]

Re: Review Request 67357: Added constant time comparison of JWT signatures.

> On May 31, 2018, 4:56 p.m., Benno Evers wrote: > > 3rdparty/libprocess/src/jwt.cpp > > Lines 205 (patched) > > > > > > To be more precise: "which compares either none of the content or the > > whole content of

Re: Review Request 67357: Added constant time comparison of JWT signatures.

> On June 6, 2018, 11:58 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/jwt.cpp > > Lines 213 (patched) > > > > > > To avoid conversions and integral promotions, does it make sense to say > > here > >

Re: Review Request 67357: Added constant time comparison of JWT signatures.

> On June 6, 2018, 10:26 a.m., Mesos Reviewbot Windows wrote: > > FAIL: Some of the unit tests failed. Please check the relevant logs. > > > > Reviews applied: `['67357']` > > > > Failed command: `Start-MesosCITesting` > > > > All the build artifacts available at: > >

Re: Review Request 67357: Added constant time comparison of JWT signatures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67357/#review204374 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66652: Renamed local_puller to image_tar_puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66652/#review204372 --- PASS: Mesos patch 66652 was successfully built and tested.

Re: Review Request 67463: Fixed type error when using `check_output` in Python 3 scripts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67463/#review204370 --- Patch looks great! Reviews applied: [67463] Passed command:

Re: Review Request 66650: Removed an invalid TODO in puller.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66650/#review204369 --- Ship it! Ship It! - Qian Zhang On June 6, 2018, 4:40 p.m.,

Re: Review Request 67223: Used move constructors for making CSI gRPC calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67223/#review204368 --- Ship it! This patch needs to be rebased, but LGTM.

Re: Review Request 67157: Refactored the gRPC client runtime wrapper in libprocess.

> On May 25, 2018, 5:12 p.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/src/grpc.cpp > > Lines 70 (patched) > > > > > > I am slightly worried that we only `join` this thread on `terminate`. > > Could we make

Re: Review Request 67472: Fixed CppLinter in python3/mesos-style.py to use correct linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67472/#review204366 --- PASS: Mesos patch 67472 was successfully built and tested.

Re: Review Request 66652: Renamed local_puller to image_tar_puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66652/ --- (Updated June 6, 2018, 1:44 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 66561: Supported hdfs fetching in local puller.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66561/ --- (Updated June 6, 2018, 1:43 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 66562: Added test for local puller hdfs uri fetcher plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66562/ --- (Updated June 6, 2018, 1:43 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 66651: Supported host and port in hdfs constructor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66651/ --- (Updated June 6, 2018, 1:42 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 66651: Supported host and port in hdfs constructor.

> On April 18, 2018, 5:51 a.m., Qian Zhang wrote: > > Can you add a test in `uri_fetcher_tests.cpp` to verify fetching a remote > > file via Hadoop fetcher plugin? for now, it is hard to find a long existing hdfs:// source to verify network connection reliability. I would say simulate in unit

Re: Review Request 66650: Removed an invalid TODO in puller.cpp.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66650/ --- (Updated June 6, 2018, 1:40 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 66559: Made agent flag '--hadoop_home' as optional.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66559/ --- (Updated June 6, 2018, 1:40 a.m.) Review request for mesos, Jie Yu and Qian

Re: Review Request 66562: Added test for local puller hdfs uri fetcher plugin.

> On April 18, 2018, 6:24 a.m., Qian Zhang wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp > > Lines 493-517 (patched) > > > > > > Can you use raw string literal to avoid escaping? Considering all

Re: Review Request 67357: Added constant time comparison of JWT signatures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67357/ --- (Updated June 6, 2018, 10:31 a.m.) Review request for mesos and Alexander

Re: Review Request 67357: Added constant time comparison of JWT signatures.

> On May 31, 2018, 6:56 p.m., Benno Evers wrote: > > 3rdparty/libprocess/src/jwt.cpp > > Lines 205 (patched) > > > > > > To be more precise: "which compares either none of the content or the > > whole content of

Review Request 67472: Fixed CppLinter in python3/mesos-style.py to use correct linter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67472/ --- Review request for mesos, Andrew Schwartzmeyer and Benjamin Bannier.

Re: Review Request 67464: Fixed `python3/mesos-style.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67464/#review204361 --- Patch looks great! Reviews applied: [67464] Passed command: