Review Request 67668: Fixed a bug in `TestCSIPlugin::DeleteVolume`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67668/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MES

Review Request 67670: Added a unit test for disappeared profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67670/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MES

Review Request 67669: Removed an invariant check when updating the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67669/ --- Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and Meng Zh

Review Request 67666: Added a `TestDiskProfileServer` helper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67666/ --- Review request for mesos, Benjamin Bannier, Jie Yu, Joseph Wu, and Jan Schlicht.

Review Request 67665: Made the `UriDiskProfileAdaptor` module configurable in SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67665/ --- Review request for mesos, Benjamin Bannier, Jie Yu, Joseph Wu, and Jan Schlicht.

Review Request 67664: Fixed a race between `UPDATE_STATE` and `UPDATE_OPERATION_STATUS`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67664/ --- Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.

Review Request 67667: Renamed the `NewProfile` SLRP test and made it based on offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67667/ --- Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. Bugs: MES

Re: Review Request 65875: Improved logging for offers and inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65875/ --- (Updated June 20, 2018, 5:32 a.m.) Review request for mesos, Benjamin Bannier,

Review Request 67663: Made `UriDiskProfileAdaptor` be able to handle disappeared profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67663/ --- Review request for mesos, Benjamin Bannier, James DeFelice, Jie Yu, and Joseph W

Re: Review Request 65640: Fixed a race condition in `UriDiskProfileAdaptorTests`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65640/ --- (Updated June 20, 2018, 5:32 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 67565: Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67565/#review205045 --- Patch looks great! Reviews applied: [67662, 67526, 67564, 67565]

Re: Review Request 65976: Made SLRP be able to handle disappeared profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65976/ --- (Updated June 20, 2018, 4:35 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 65975: Reconciled storage pools when destroying volumes with stale profiles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65975/ --- (Updated June 20, 2018, 4:33 a.m.) Review request for mesos, Benjamin Bannier a

Re: Review Request 67662: Allowed mounts if the container is launched in a new mount namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67662/#review205044 --- PASS: Mesos patch 67662 was successfully built and tested. Review

Re: Review Request 67526: Added container-specific cgroup FS mounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67526/ --- (Updated June 20, 2018, 10:48 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 67565: Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67565/#review205040 --- FAIL: Failed to apply the dependent review: 67526. Failed command

Re: Review Request 67565: Added a test `ROOT_CGROUPS_CommandTaskSpecificCgroupsMount`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67565/ --- (Updated June 20, 2018, 10:40 a.m.) Review request for mesos, Gilbert Song and

Review Request 67662: Allowed mounts if the container is launched in a new mount namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67662/ --- Review request for mesos, Gilbert Song and Jason Lai. Bugs: MESOS-8327 http

Re: Review Request 67513: Added a master flag to configure minimum allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67513/#review205037 --- Fix it, then Ship it! docs/configuration/master.md Lines 210-2

Re: Review Request 67656: Fixed Autotools `cd 3rdparty/stout && make tests` build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67656/#review205039 --- Patch looks great! Reviews applied: [67656] Passed command: expo

Re: Review Request 67561: Refactored `struct Slave` in the allocator for better performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67561/ --- (Updated June 19, 2018, 4:21 p.m.) Review request for mesos, Gastón Kleiman, Gr

Re: Review Request 67517: Added a test to verify `min_allocatable_resources` flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67517/#review205016 --- src/tests/master_allocator_tests.cpp Lines 1241 (patched)

Re: Review Request 67656: Fixed Autotools `cd 3rdparty/stout && make tests` build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67656/#review205036 --- PASS: Mesos patch 67656 was successfully built and tested. Review

Re: Review Request 67656: Fixed Autotools `cd 3rdparty/stout && make tests` build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67656/#review205028 --- Ship it! 3rdparty/stout/Makefile.am Line 245 (original), 247 (

Re: Review Request 67561: Refactored `struct Slave` in the allocator for better performance.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67561/#review204940 --- Fix it, then Ship it! src/master/allocator/mesos/hierarchical.

Re: Review Request 67587: Updated ZooKeeper retry logic to retry on `ENOENT` too.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67587/#review205027 --- Ship it! Ship It! - Akash Gupta On June 13, 2018, 10:30 p.m.

Re: Review Request 67513: Added a master flag to configure minimum allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67513/ --- (Updated June 19, 2018, 2:39 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 67513: Added a master flag to configure minimum allocatable resources.

> On June 19, 2018, 12:18 p.m., Greg Mann wrote: > > src/master/flags.cpp > > Lines 479 (patched) > > > > > > Could you update the configuration documentation for the master as well? Done. > On June 19, 2018, 12:1

Re: Review Request 67516: Added a resource utility `isScalarQuantity`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67516/ --- (Updated June 19, 2018, 2:30 p.m.) Review request for mesos, Gastón Kleiman and

Review Request 67656: Fixed Autotools `cd 3rdparty/stout && make tests` build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67656/ --- Review request for mesos, Benjamin Bannier and Joseph Wu. Repository: mesos D

Re: Review Request 65995: Declined unwanted offers in `RetryOperationStatusUpdate*` SLRP tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65995/ --- (Updated June 19, 2018, 9:16 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 67655: Removed some debugging codes that were committed by mistake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67655/#review205018 --- PASS: Mesos patch 67655 was successfully built and tested. All th

Re: Review Request 67513: Added a master flag to configure minimum allocatable resources.

> On June 19, 2018, 7:18 p.m., Greg Mann wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 179-183 (original), 179-192 (patched) > > > > > > Do we have any tests which verify that the allocator's min. a

Re: Review Request 67513: Added a master flag to configure minimum allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67513/#review205011 --- src/master/flags.cpp Lines 479 (patched)

Re: Review Request 67655: Removed some debugging codes that were committed by mistake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67655/#review205013 --- Ship it! Ship It! - Andrew Schwartzmeyer On June 19, 2018, 1

Review Request 67655: Removed some debugging codes that were committed by mistake.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67655/ --- Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Joseph Wu, Qia

Re: Review Request 67516: Added a resource utility `isScalarQuantity`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67516/#review205010 --- Fix it, then Ship it! include/mesos/resources.hpp Lines 328 (p

Re: Review Request 67510: Fixed a bug in `createStrippedScalarQuantity()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67510/#review205008 --- Ship it! Ship It! - Greg Mann On June 11, 2018, 5:30 p.m., M

Re: Review Request 67609: Added DaoTan Cui to the contributors list.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67609/ --- (Updated 六月 19, 2018, 5:56 p.m.) Review request for mesos and Gilbert Song. R

Re: Review Request 67632: Always define PICOJSON_USE_INT64.

> On June 18, 2018, 1:23 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/Makefile.am > > Lines 96-99 (original), 96-97 (patched) > > > > > > We should probably remove this from CMake too, yeah? > > > > `

Re: Review Request 65976: Allowed profiles to be missing from `DiskProfileAdaptor`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65976/#review204997 --- Ship it! Ship It! - Benjamin Bannier On June 18, 2018, 8:31

Re: Review Request 67632: Added definition for PICOJSON_USE_INT64 into stout headers.

> On June 18, 2018, 8:23 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/Makefile.am > > Lines 96-99 (original), 96-97 (patched) > > > > > > We should probably remove this from CMake too, yeah? > > > > `

Re: Review Request 67632: Added definition for PICOJSON_USE_INT64 into stout headers.

> On June 18, 2018, 10:23 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/Makefile.am > > Lines 96-99 (original), 96-97 (patched) > > > > > > We should probably remove this from CMake too, yeah? > > > >

Re: Review Request 67633: Removed PICOJSON_USE_INT64 from libprocess build system.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67633/#review204990 --- Fix it, then Ship it! Thanks for the cleanup, Benno! Could you

Re: Review Request 67634: Removed PICOJSON_USE_INT64 from Mesos build system.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67634/#review204993 --- Ship it! Thanks for the cleanup, Benno! Could you update the _

Re: Review Request 67632: Added definition for PICOJSON_USE_INT64 into stout headers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67632/#review204992 --- Fix it, then Ship it! Thanks for the cleanup, Benno! Could you

Re: Review Request 67616: Added a length validation for container IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67616/#review204988 --- Patch looks great! Reviews applied: [67616] Passed command: expo

Re: Review Request 67616: Added a length validation for container IDs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67616/#review204987 --- PASS: Mesos patch 67616 was successfully built and tested. Review