Re: Review Request 67821: Added override specifiers to XfsDiskIsolatorProcess methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67821/#review205709 --- Patch looks great! Reviews applied: [67820, 67821] Passed comman

Re: Review Request 67827: Added a helper `stripIncapableResources` in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67827/#review205708 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67777: Added a helper to match agent-framework capabilities in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/#review205707 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67817: Improved logging for offers and inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67817/#review205706 --- Patch looks great! Reviews applied: [67817] Passed command: expo

Review Request 67827: Added a helper `stripIncapableResources` in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67827/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-8916 https://issu

Review Request 67825: Added a resources utility `hasShared()`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67825/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Review Request 67826: Made `Slave::getAvailable()` return all shared resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67826/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description -

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67791/#review205705 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67824: Reduced likelihood of a stack overflow in libprocess socket recv path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67824/#review205704 --- Ship it! Ship It! - Chun-Hung Hsiao On July 4, 2018, 12:06 a

Re: Review Request 67777: Added a helper to match agent-framework capabilities in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6/ --- (Updated July 3, 2018, 5:19 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 67777: Added a helper to match agent-framework capabilities in the allocator.

> On July 2, 2018, 3:42 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Line 1756 (original), 1755 (patched) > > > > > > How about a member function of the framework struct? > >

Review Request 67824: Reduced likelihood of a stack overflow in libprocess socket recv path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67824/ --- Review request for mesos and Chun-Hung Hsiao. Bugs: MESOS-9024 https://issu

Re: Review Request 67822: Avoid duplicate unmount dangling mount point.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67822/#review205701 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67791/ --- (Updated July 3, 2018, 4:57 p.m.) Review request for mesos, Alexander Rojas, Gr

Re: Review Request 67823: Added a master benchmark test for metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67823/#review205700 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67823: Added a master benchmark test for metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67823/ --- (Updated July 3, 2018, 11:10 p.m.) Review request for mesos, Benjamin Mahler, G

Re: Review Request 67822: Avoid duplicate unmount dangling mount point.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67822/ --- (Updated July 3, 2018, 4:05 p.m.) Review request for mesos, Chun-Hung Hsiao, Ja

Re: Review Request 67821: Added override specifiers to XfsDiskIsolatorProcess methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67821/#review205699 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67235: Added per-framework metrics for types of resources contained in offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67235/#review205698 --- FAIL: Some of the unit tests failed. Please check the relevant log

Review Request 67823: Added a master benchmark test for metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67823/ --- Review request for mesos, Benjamin Mahler, Gastón Kleiman, and James Peach. Bug

Re: Review Request 67822: Avoid duplicate unmount dangling mount point.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67822/#review205696 --- Fix it, then Ship it! Could you change the ticket to MESOS-9049

Review Request 67822: Avoid duplicate unmount dangling mount point.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67822/ --- Review request for mesos, Chun-Hung Hsiao, Jason Lai, and Jie Yu. Bugs: MESOS-8

Re: Review Request 67817: Improved logging for offers and inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67817/#review205695 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67235: Added per-framework metrics for types of resources contained in offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67235/ --- (Updated July 3, 2018, 9:41 p.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 67187: Tested per-framework task state metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67187/ --- (Updated July 3, 2018, 9:40 p.m.) Review request for mesos, Gastón Kleiman and

Re: Review Request 66874: Added per-framework metrics for active task states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66874/ --- (Updated July 3, 2018, 9:39 p.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66883: Added/updated tests to check per-framework metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66883/ --- (Updated July 3, 2018, 9:39 p.m.) Review request for mesos, Benjamin Mahler, Gi

Re: Review Request 66870: Added per-framework metrics for suppressed roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66870/ --- (Updated July 3, 2018, 9:38 p.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66856: Tracked completed framework metrics in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66856/ --- (Updated July 3, 2018, 9:35 p.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66861: Added per-framework DRF position metrics to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66861/ --- (Updated July 3, 2018, 9:33 p.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66844: Added framework metrics for filtered resources to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66844/ --- (Updated July 3, 2018, 9:31 p.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66855: Changed the 'capacity_' member of 'BoundedHashMap' to non-const.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66855/ --- (Updated July 3, 2018, 9:32 p.m.) Review request for mesos, Benjamin Mahler, Ga

Review Request 67821: Added override specifiers to XfsDiskIsolatorProcess methods.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67821/ --- Review request for mesos, Benjamin Mahler and James Peach. Repository: mesos

Review Request 67820: Fixed XfsDiskIsolatorProcess::recover() signature.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67820/ --- Review request for mesos, Benjamin Mahler and James Peach. Repository: mesos

Re: Review Request 67147: Included a missing header in the master metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67147/ --- (Updated July 3, 2018, 9:30 p.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66843: Added 'FrameworkMetrics' to the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66843/ --- (Updated July 3, 2018, 9:29 p.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66842: Added per-framework metrics for offer filter durations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66842/ --- (Updated July 3, 2018, 9:29 p.m.) Review request for mesos, Benjamin Mahler, Ga

Re: Review Request 66841: Added a hash function for 'Duration'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66841/ --- (Updated July 3, 2018, 9:28 p.m.) Review request for mesos, Benjamin Mahler, Ga

Review Request 67814: Added per-framework metrics for offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67814/ --- Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilb

Review Request 67813: Added per-framework metrics for task states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67813/ --- Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilb

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67791/#review205692 --- Ship it! Ship It! - Greg Mann On July 3, 2018, 7:30 p.m., Ga

Re: Review Request 67812: Added per-framework offer metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67812/#review205691 --- Patch looks great! Reviews applied: [66882, 66819, 66820, 67808,

Re: Review Request 67817: Improved logging for offers and inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67817/ --- (Updated July 3, 2018, 1:56 p.m.) Review request for mesos, Chun-Hung Hsiao, Gr

Re: Review Request 67812: Added per-framework offer metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67812/#review205690 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67817: Improved logging for offers and inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67817/#review205689 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67791/#review205688 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67817: Improved logging for offers and inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67817/#review205683 --- Fix it, then Ship it! src/master/master.cpp Lines 9573 (patche

Re: Review Request 67808: Added per-framework metrics for scheduler calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67808/#review205682 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67791/ --- (Updated July 3, 2018, 12:30 p.m.) Review request for mesos, Alexander Rojas, G

Review Request 67817: Improved logging for offers and inverse offers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67817/ --- Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Vinod Kone. Repositor

Review Request 67812: Added per-framework offer metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67812/ --- Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilb

Review Request 67809: Added per-framework metrics for scheduler events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67809/ --- Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilb

Review Request 67808: Added per-framework metrics for scheduler calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67808/ --- Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gastón Kleiman, Gilb

Re: Review Request 67722: Fixed unproperly guarded future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67722/#review205680 --- Patch looks great! Reviews applied: [67722] Passed command: expo

Re: Review Request 67777: Added a helper to match agent-framework capabilities in the allocator.

> On July 2, 2018, 3:42 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Line 1756 (original), 1755 (patched) > > > > > > How about a member function of the framework struct? > >

Re: Review Request 67722: Fixed unproperly guarded future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67722/#review205671 --- FAIL: Some of the unit tests failed. Please check the relevant log

Re: Review Request 67413: Refactored logic for `PYTHON` and `PYTHON_VERSION` in `configure.ac`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67413/ --- (Updated July 3, 2018, 2:40 p.m.) Review request for mesos, Andrew Schwartzmeye

Re: Review Request 67413: Refactored logic for `PYTHON` and `PYTHON_VERSION` in `configure.ac`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67413/ --- (Updated July 3, 2018, 2:32 p.m.) Review request for mesos, Andrew Schwartzmeye

Re: Review Request 67791: Prevented master from asking agents to shutdown on auth failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67791/#review205665 --- src/tests/authentication_tests.cpp Line 82 (original), 82 (patche

Re: Review Request 67722: Fixed unproperly guarded future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67722/ --- (Updated July 3, 2018, 12:17 p.m.) Review request for mesos, Gastón Kleiman, Gr

Re: Review Request 67722: Fixed unproperly guarded future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67722/#review205662 --- src/master/master.cpp Lines 9667-9672 (patched)

Re: Review Request 67795: Moved `CheckInfo` validation to common code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67795/#review205659 --- Ship it! Ship It! - Alexander Rukletsov On July 3, 2018, 6:3

Re: Review Request 67794: Moved `validation::healthCheck` to common code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67794/#review205658 --- Ship it! Ship It! - Alexander Rukletsov On July 3, 2018, 6:3