> On July 2, 2018, 3:42 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Line 1756 (original), 1755 (patched) > > <https://reviews.apache.org/r/67777/diff/2/?file=2047194#file2047194line1756> > > > > How about a member function of the framework struct? > > > > ``` > > if (!framework.isCapableOnAgent(slave)) { > > ... > > } > > ```
That would need to move nested Slave class forward or outside. Currently, all the helper functions for slave/framework are member functions of the outer class. I was trying to be consistent. If you think it is necessary, I can go ahead and overhaul the structure. - Meng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67777/#review205647 ----------------------------------------------------------- On June 28, 2018, 4 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67777/ > ----------------------------------------------------------- > > (Updated June 28, 2018, 4 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-8916 > https://issues.apache.org/jira/browse/MESOS-8916 > > > Repository: mesos > > > Description > ------- > > `isFrameworkCapableReceivingAgent` checks if a framework > is capable of receiving resources on the agent based on > the framework capability. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 > src/master/allocator/mesos/hierarchical.cpp > cbdfb2ba9c25755ac631557e0e7dbd721f861a4d > > > Diff: https://reviews.apache.org/r/67777/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
