Re: Review Request 69405: Refactored createAuthorizationCallbacks into common/authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69405/#review210750 --- Ship it! Thanks for the clean up work! - Alexander Rojas On

Re: Review Request 69359: Rewrote test `ReconcileDroppedOperation` for `CREATE_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69359/#review210747 --- Ship it! Ship It! - Benjamin Bannier On Nov. 19, 2018,

Re: Review Request 69365: Recovered disk through `CREATE_DISK` in test `AgentRegisteredWithNewId`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69365/#review210745 --- src/tests/storage_local_resource_provider_tests.cpp Lines 1626

Re: Review Request 69365: Recovered disk through `CREATE_DISK` in test `AgentRegisteredWithNewId`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69365/ --- (Updated Nov. 21, 2018, 5:42 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 69362: Checkpointed creation parameters for CSI volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69362/ --- (Updated Nov. 21, 2018, 3:39 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 69364: Added the `--create_parameters` flag to the test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69364/ --- (Updated Nov. 21, 2018, 3:43 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 69402: Fixed `CreateVolume` of the test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69402/ --- (Updated Nov. 21, 2018, 3:41 a.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 69365: Recovered disk through `CREATE_DISK` in test `AgentRegisteredWithNewId`.

> On Nov. 20, 2018, 4:21 p.m., Benjamin Bannier wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 275-276 (original), 278-279 (patched) > > > > > > ``` > > // Create a JSON string

Re: Review Request 69364: Added the `--create_parameters` flag to the test CSI plugin.

> On Nov. 20, 2018, 1:16 p.m., Benjamin Bannier wrote: > > src/examples/test_csi_plugin.cpp > > Lines 367-370 (patched) > > > > > > Can we move this block and the one below outside of the conditional or > > do we

Re: Review Request 69360: Rewrote test `ConvertPreExistingVolume` for `CREATE_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69360/ --- (Updated Nov. 21, 2018, 2:46 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69357: Added profiles to storage pools in tests for `CREATE_DISK`.

> On Nov. 20, 2018, 3:47 p.m., Benjamin Bannier wrote: > > src/tests/operation_reconciliation_tests.cpp > > Lines 795-797 (original), 795-798 (patched) > > > > > > Nit: old indent was fine IMO. Dropping this and

Re: Review Request 69357: Added profiles to storage pools in tests for `CREATE_DISK`.

> On Nov. 20, 2018, 3:47 p.m., Benjamin Bannier wrote: > > Could you update the commit message? > > > > I am not sure we need to update all the tests you touched here, but there > > also seems nothing wrong with it. Maybe something to potentially elaborate > > on in the commit message as

Re: Review Request 69411: Added new interface for constructing `cluster::Master`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69411/#review210739 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 69157: Fixed handling for offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69157/#review210737 --- Fix it, then Ship it! Could you update the commit message

Re: Review Request 69157: Fixed handling for offer operation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69157/ --- (Updated Nov. 20, 2018, 6:50 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 69412: Fixed thread safety issue in jwt signature validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69412/#review210729 --- PASS: Mesos patch 69412 was successfully built and tested.

Re: Review Request 69036: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69036/#review210725 --- Ship it! Ship It! - Benjamin Bannier On Nov. 16, 2018,

Re: Review Request 69360: Rewrote test `ConvertPreExistingVolume` for `CREATE_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69360/#review210724 --- Ship it! Unless you reorder the chain, could you call out in

Re: Review Request 69405: Refactored createAuthorizationCallbacks into common/authorization.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69405/#review210723 --- Fix it, then Ship it! Lovely! src/common/authorization.hpp

Re: Review Request 69365: Recovered disk through `CREATE_DISK` in test `AgentRegisteredWithNewId`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69365/#review210710 --- Fix it, then Ship it!

Re: Review Request 69411: Added new interface for constructing `cluster::Master`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69411/#review210720 --- PASS: Mesos patch 69411 was successfully built and tested.

Re: Review Request 69345: Made non-root containers can access SANDBOX_PATH volume of PARENT type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/#review210721 --- PASS: Mesos patch 69345 was successfully built and tested.

Re: Review Request 69357: Added profiles to storage pools in tests for `CREATE_DISK`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69357/#review210719 --- Fix it, then Ship it! Could you update the commit message? I

Re: Review Request 69361: Implemented the new `CREATE_DISK`/`DESTROY_DISK` semantics in SLRP.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69361/#review210717 --- Ship it! Ship It! - Benjamin Bannier On Nov. 16, 2018, 1:42

Review Request 69412: Fixed thread safety issue in jwt signature validation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69412/ --- Review request for mesos, Gastón Kleiman, Greg Mann, Jan Schlicht, and Till

Re: Review Request 69356: Added validation for `Offer.Operation.CreateDisk.target_profile`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69356/#review210716 --- Ship it! Ship It! - Benjamin Bannier On Nov. 19, 2018,

Re: Review Request 69362: Checkpointed creation parameters for CSI volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69362/#review210715 --- Fix it, then Ship it!

Re: Review Request 69345: Made non-root containers can access SANDBOX_PATH volume of PARENT type.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69345/ --- (Updated Nov. 20, 2018, 10:13 p.m.) Review request for mesos, Gilbert Song,

Review Request 69411: Added new interface for constructing `cluster::Master`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69411/ --- Review request for mesos. Repository: mesos Description --- This review

Re: Review Request 69342: Added an agent flag `--volume_gid_range`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69342/ --- (Updated Nov. 20, 2018, 10:10 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 69344: Added volume gid manager to Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69344/ --- (Updated Nov. 20, 2018, 10:12 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 69364: Added the `--create_parameters` flag to the test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69364/#review210711 --- Ship it! src/examples/test_csi_plugin.cpp Lines 367-370

Re: Review Request 69409: Added Seccomp parser tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69409/#review210709 --- FAIL: Failed to apply the dependent review: 67844. Failed

Review Request 69409: Added Seccomp parser tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69409/ --- Review request for mesos, Gilbert Song, James Peach, and Qian Zhang. Bugs:

Re: Review Request 69390: Added docs describing how to use the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69390/#review210708 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69311: Enabled parallel test runner to cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69311/#review210707 --- Ship it! Ship It! - Till Toenshoff On Nov. 14, 2018, 1:11

Re: Review Request 69312: Enabled parallel test runner to cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69312/#review210706 --- Ship it! Ship It! - Till Toenshoff On Nov. 11, 2018, 12:01

Re: Review Request 69313: Enabled parallel test runner to cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69313/#review210705 --- Ship it! - Till Toenshoff On Nov. 11, 2018, 12:01 a.m.,

Re: Review Request 69390: Added docs describing how to use the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69390/ --- (Updated Nov. 20, 2018, 12:12 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 69390: Added docs describing how to use the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69390/#review210703 --- docs/cli.md Lines 20 (patched)

Re: Review Request 69390: Added docs describing how to use the new CLI.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69390/ --- (Updated Nov. 20, 2018, 11:57 a.m.) Review request for mesos and Kevin Klues.