Re: Review Request 69911: Added tests for reconciliation of operations on agent default resources.

> On Feb. 7, 2019, 4:36 p.m., Greg Mann wrote: > > src/tests/operation_reconciliation_tests.cpp > > Lines 1383 (patched) > > > > > > Could you explain in this comment why the response contains no > > operations?

Re: Review Request 69911: Added tests for reconciliation of operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69911/ --- (Updated Feb. 8, 2019, 3:12 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review212680 --- PASS: Mesos patch 69615 was successfully built and tested.

Re: Review Request 69902: Fixed incorrect skipping in the allocation loops.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69902/ --- (Updated Feb. 8, 2019, 9:47 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 69910: Added tests for feedback for operations on agent default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69910/ --- (Updated Feb. 8, 2019, 1:27 p.m.) Review request for mesos, Greg Mann and

Re: Review Request 69615: Disable containerizer ptrace attach.

> On Jan. 18, 2019, 8:36 a.m., Jiang Yan Xu wrote: > > src/slave/flags.cpp > > Lines 338 (patched) > > > > > > If disallow is the default, it's a breaking change right? Can the > > default be allowing it? Strictly

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/ --- (Updated Feb. 8, 2019, 9:09 p.m.) Review request for mesos, Xudong Ni, Gilbert

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/#review212679 --- Looks good, just some minor comments. I suppose you'll need to

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212678 --- Fix it, then Ship it! Looks good, after leaving the comment

Re: Review Request 69889: Stored static framework offer filters in allocator framework class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69889/#review212677 --- Ship it! Ship It! - Benjamin Mahler On Feb. 8, 2019, 11:32

Re: Review Request 69931: Empty test commit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69931/#review212672 --- PASS: Mesos patch 69931 was successfully built and tested.

Re: Review Request 69909: Tested unreachable task behavior on agent GC.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69909/#review212671 --- PASS: Mesos patch 69909 was successfully built and tested.

Review Request 69931: Empty test commit.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69931/ --- Review request for mesos. Repository: mesos Description --- Empty test

Re: Review Request 69697: Reverted cleanup step of `verify-reviews.py`.

> On Jan. 16, 2019, 5:04 p.m., Vinod Kone wrote: > > support/verify-reviews.py > > Line 174 (original), 171 (patched) > > > > > > Do you guys understand why this was failing in the Azure CI in the > > first place?

Re: Review Request 69817: Refactored 'support/verify-reviews.py' to be closer to commit 7412179.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69817/#review212668 --- Ship it! Ship It! - Till Toenshoff On Jan. 23, 2019, 11:47

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/#review212666 --- FAIL: Failed to apply the dependent review: 69821. Failed

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69890/ --- (Updated Feb. 8, 2019, 12:32 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69890: Added test for per-framework, per-role minimal allocatable resources.

> On Feb. 5, 2019, 8:03 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp > > Lines 2287 (patched) > > > > > > any reason not to stick to using "minimum" for these? ditto below > > >

Re: Review Request 69889: Stored static framework offer filters in allocator framework class.

> On Feb. 5, 2019, 8:13 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 105 (patched) > > > > > > Actually, just realized when reading the subsequent patch (and thinking > >

Re: Review Request 69889: Stored static framework offer filters in allocator framework class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69889/ --- (Updated Feb. 8, 2019, 12:32 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69821/ --- (Updated Feb. 8, 2019, 12:32 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 69818: Added offer filters to static framework configuration.

> On Feb. 6, 2019, 6:01 p.m., James DeFelice wrote: > > include/mesos/mesos.proto > > Lines 1541 (patched) > > > > > > Each `ResourceQuantities` item here represents a "shape" that will be > > matched against a

Re: Review Request 69821: Enforced minimal allocatable resources in the hierarchical allocator.

> On Feb. 4, 2019, 9:58 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 2058-2060 (original), 2092-2094 (patched) > > > > > > We lost the comment here about why it's safe to

Re: Review Request 69889: Stored static framework offer filters in allocator framework class.

> On Feb. 5, 2019, 7:42 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Line 480 (original), 482-483 (patched) > > > > > > Actually on second look, it seems odd to store both the