Re: Review Request 67444: Made quota consumption tracking event-driven in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67444/#review213114 --- Bad review! Reviews applied: [67444, 68119, 68118] Error:

Re: Review Request 69614: Reverted "Added `libacl` into a few Dockerfiles.".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69614/#review213113 --- Ship it! Ship It! - Gilbert Song On Dec. 20, 2018, 5 p.m.,

Re: Review Request 69479: Added the flag `--task_supplementary_groups` to command executor.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69479/#review213112 --- Ship it! Ship It! - Gilbert Song On Dec. 11, 2018, 7:06

Re: Review Request 69553: Changed the definition of `uid_t` and `gid_t` to UNIT for Windows.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69553/#review213111 --- Ship it! Ship It! - Gilbert Song On Dec. 11, 2018, 7:06

Re: Review Request 69675: Added volume gid manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69675/#review213110 --- src/slave/volume_gid_manager/volume_gid_manager.cpp Lines

Re: Review Request 69614: Reverted "Added `libacl` into a few Dockerfiles.".

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69614/#review213108 --- Bad review! Reviews applied: [69614, 69613, 69579, 69547, 68163,

Re: Review Request 70044: Moved status update streams of operations on agent's default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70044/#review213107 --- PASS: Mesos patch 70044 was successfully built and tested.

Re: Review Request 67762: Added minimum capability check during master recovery.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67762/#review213106 --- Patch looks great! Reviews applied: [67761, 67762] Passed

Re: Review Request 69978: Added garbage collection of terminated operations status update streams.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69978/#review213105 --- PASS: Mesos patch 69978 was successfully built and tested.

Review Request 70044: Moved status update streams of operations on agent's default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70044/ --- Review request for mesos, Benno Evers, Greg Mann, and Joseph Wu. Bugs:

Re: Review Request 70044: Moved status update streams of operations on agent's default resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70044/ --- (Updated Feb. 22, 2019, 5:34 p.m.) Review request for mesos, Benno Evers, Greg

Re: Review Request 69978: Added garbage collection of terminated operations status update streams.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69978/ --- (Updated Feb. 22, 2019, 5:28 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 69701: Improved debuggability of `verify-reviews.py`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69701/#review213104 --- Bad review! Reviews applied: [69701, 69698] Error: 2019-02-23

Re: Review Request 69559: Simplified verify-reviews.py to be more similar to the Python 2 script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69559/#review213103 --- Bad review! Reviews applied: [69559] Error: 2019-02-22 23:53:14

Re: Review Request 69551: Renamed `Metrics()` function in test utils.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69551/#review213099 --- Bad review! Reviews applied: [69551] Error: 2019-02-22 22:53:41

Re: Review Request 69342: Added an agent flag `--volume_gid_range`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69342/#review213098 --- Ship it! Ship It! - Gilbert Song On Jan. 6, 2019, 4:22

Re: Review Request 68785: Added jsonschema.py for managing json-based configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68785/#review213096 --- Patch looks great! Reviews applied: [68785] Passed command:

Re: Review Request 66649: Added pb2gen.sh for generating python protobuf bindings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66649/#review213093 --- Patch looks great! Reviews applied: [66649] Passed command:

Re: Review Request 69615: Disable containerizer ptrace attach.

> On Feb. 13, 2019, 11:07 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 556 (patched) > > > > > > The main thing I wanted to confirm is what we chatted about offline but > > I

Re: Review Request 70010: Store `logrotate` config in memfd file instead of container's sandbox.

> On Feb. 21, 2019, 7:26 p.m., Gilbert Song wrote: > > When I was testing the containerizer memfd sealing, I have observed out of > > FD leak on my dev machine, due to the leak from whitelisting the FD. Could > > we manually test the scale before landing this patch? > Could we manually test

Re: Review Request 68654: Enabled isort for src/python/lib.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68654/#review213086 --- Patch looks great! Reviews applied: [68654] Passed command:

Re: Review Request 67185: Added request_protobuf to mesos.http.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67185/#review213083 --- Patch looks great! Reviews applied: [67185] Passed command:

Re: Review Request 69313: Enabled parallel test runner to cmake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69313/#review213078 --- Patch looks great! Reviews applied: [69309, 69310, 69311, 69312,