Re: Review Request 70534: Added tests for the V1 UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70534/#review215335 --- Patch looks great! Reviews applied: [70532, 70663, 70664, 70665,

Re: Review Request 70651: Notifies master `/api/v1` subscribers about recovered frameworks.

> On May 17, 2019, 10:16 a.m., Greg Mann wrote: > > src/tests/api_tests.cpp > > Lines 2774 (patched) > > > > > > Nit: make this a const ref? This is copied because `event` is overwritten later. Do you think that

Re: Review Request 70660: Fix the XFS build for recent Fedora versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70660/#review215330 --- Ship it! Ship It! - Xudong Ni On May 17, 2019, 2:24 a.m.,

Re: Review Request 70530: Refactored Framework updates for the UPDATE_FRAMEWORK call; fixed race.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70530/#review215329 --- Patch looks great! Reviews applied: [70583, 70531, 70530]

Re: Review Request 70660: Fix the XFS build for recent Fedora versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70660/#review215327 --- Ship it! Ship It! - Jiang Yan Xu On May 16, 2019, 7:24

Re: Review Request 70534: Added tests for the V1 UPDATE_FRAMEWORK call.

> On May 12, 2019, 5:44 a.m., Benjamin Mahler wrote: > > src/tests/update_framework_tests.cpp > > Lines 98 (patched) > > > > > > What does the presence of agent reservations matter to testing > > UPDATE_FRAMEWORK?

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call in the V1 API.

> On April 24, 2019, 7:52 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 3237 (patched) > > > > > > What does updateFramework do if the changes are not allowed? Crash? > > > > Seems like

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call in the V1 API.

> On May 12, 2019, 5:46 a.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 2877-2880 (original), 2884-2887 (patched) > > > > > > Hm.. why doesn't the broadcast function send it to subscribers too? why

Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 70534: Added tests for the V1 UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70534/ --- (Updated May 17, 2019, 3:19 p.m.) Review request for mesos and Benjamin

Re: Review Request 70533: Implemented the UPDATE_FRAMEWORK call in the V1 API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70533/ --- (Updated May 17, 2019, 3:18 p.m.) Review request for mesos and Benjamin

Review Request 70670: Simplified the `Framework::update()` method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70670/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7258

Review Request 70669: Made it possible to validate against `user` and `checkpoint` updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70669/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7258

Review Request 70668: Fixed the race between validating and applying FrameworkInfo updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70668/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7258 and MESOS-9763

Review Request 70667: Added unit tests for 'framework::validateUpdate()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70667/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7258

Review Request 70666: Introduced a function for validating a `FrameworkInfo` update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70666/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7258

Review Request 70665: Moved the logic of sending 'Framework' updates into a separate method.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70665/ --- Review request for mesos. Bugs: MESOS-7258

Review Request 70664: Made `activateRecoveredFramework()` return void instead of Nothing().

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70664/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7258

Review Request 70663: Removed non-implemented declaration of 'Master::validate()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70663/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-7258

Re: Review Request 70532: Added an UPDATE_FRAMEWORK scheduler::Call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70532/ --- (Updated May 17, 2019, 3 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 70573: Updated bintray upload scripts to remove hard-coded accounts.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70573/#review215322 --- Ship it! Looks sane. And I see that any process changes

Re: Review Request 67177: Sorted container mounts by their target paths.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67177/#review215321 --- I don't think I have enough context here. Can you describe the

Re: Review Request 70661: Added `CHECK_CONTAINS` and `CHECK_NOT_CONTAINS` macros.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70661/#review215320 --- Ship it! - Benjamin Mahler On May 17, 2019, 6:46 a.m., James

Re: Review Request 70651: Notifies master `/api/v1` subscribers about recovered frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70651/#review215319 --- Fix it, then Ship it! src/tests/api_tests.cpp Lines 2618

Re: Review Request 70637: Updated CHECK messages in the heirarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70637/#review215318 --- Patch looks great! Reviews applied: [70661, 70637] Passed

Review Request 70661: Added `CHECK_CONTAINS` and `CHECK_NOT_CONTAINS` macros.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70661/ --- Review request for mesos, Benjamin Mahler and Meng Zhu. Repository: mesos

Re: Review Request 70637: Updated CHECK messages in the heirarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70637/ --- (Updated May 17, 2019, 6:47 a.m.) Review request for mesos, Benjamin Mahler