Re: Review Request 70715: Added method `empty()` for `ResourceLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70715/#review215519 --- Ship it! Ship It! - Benjamin Mahler On May 24, 2019, noon,

Re: Review Request 70707: Refactored role quota info into `Struct Role`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70707/#review215518 --- src/master/allocator/mesos/hierarchical.hpp Line 123 (original),

Re: Review Request 70712: Added filesystem operations to the `ContainerLaunchInfo`.

> On May 24, 2019, 10:45 p.m., Jiang Yan Xu wrote: > > include/mesos/slave/containerizer.proto > > Lines 207 (patched) > > > > > > Nit: not all possible file operation have a source and a target? Would > >

Re: Review Request 70712: Added filesystem operations to the `ContainerLaunchInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70712/#review215515 --- include/mesos/slave/containerizer.proto Lines 207 (patched)

Re: Review Request 70712: Added filesystem operations to the `ContainerLaunchInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70712/#review215514 --- Fix it, then Ship it! This LGTM! Thanks James!

Re: Review Request 70641: Changed Agent GET_STATE for completed executor's tasks (Part 2).

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70641/#review215513 --- Fix it, then Ship it! src/tests/api_tests.cpp Lines 6846

Re: Review Request 70577: Changed Agent V1 GET_STATE for any completed executor's tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70577/#review215512 --- Fix it, then Ship it! src/tests/api_tests.cpp Lines 6761

Re: Review Request 70713: Renamed quota guarantee to be plural in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70713/#review215510 --- Ship it! nevermind :) - Benjamin Mahler On May 24, 2019,

Re: Review Request 70713: Renamed quota guarantee to be plural in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70713/#review215508 --- Does this match the quota protobuf? - Benjamin Mahler On May

Re: Review Request 70706: Clarified a comment regarding role `reservationScalarQuantities`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70706/#review215505 --- Ship it! Ship It! - Benjamin Mahler On May 23, 2019, 2:43

Re: Review Request 70705: Added comment regarding tracking role consumed quota.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70705/#review215504 --- Ship it! src/master/allocator/mesos/hierarchical.cpp Lines

Re: Review Request 70534: Added tests for the V1 UPDATE_FRAMEWORK call.

> On May 24, 2019, 3:59 p.m., Benjamin Mahler wrote: > > src/tests/master/update_framework_tests.cpp > > Lines 434-438 (patched) > > > > > > This looks racy? > > > > The expectation should be set up prior

Re: Review Request 70534: Added tests for the V1 UPDATE_FRAMEWORK call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70534/#review215500 --- Overall looking pretty good, thanks! Can you be sure to run the

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

> On May 24, 2019, 2:54 p.m., Benjamin Mahler wrote: > > Thanks for adding this: > > > > (1) If we're going to introduce this, let's include a patch after it that > > updates all the `SUBSCRIBE` related tests in `src/tests/api_tests.cpp` to > > use this. > > (2) Can you also include some

Re: Review Request 70671: Added a class for setting expectations on master V1 API events in tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70671/#review215497 --- Thanks for adding this: (1) If we're going to introduce this,

Re: Review Request 70716: Decoupled quota limits from quota guarantees in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70716/#review215496 --- Patch looks great! Reviews applied: [70705, 70706, 70707, 70713,

Review Request 70716: Decoupled quota limits from quota guarantees in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70716/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository:

Review Request 70715: Added method `empty()` for `ResourceLimits`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70715/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository:

Review Request 70714: Added method to construct `ResourceLimits` from scalar resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70714/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository:

Review Request 70713: Renamed quota guarantee to be plural in the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70713/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Repository:

Re: Review Request 70707: Refactored role quota info into `Struct Role`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70707/ --- (Updated May 24, 2019, 4:52 a.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 70621: Used full paths as volume IDs for the test CSI plugin.

> On May 14, 2019, 1:37 p.m., Benjamin Bannier wrote: > > src/examples/test_csi_plugin.cpp > > Lines 1250 (patched) > > > > > > Can we do that "normalization" when we initialize `workDir` instead? > > Chun-Hung

Re: Review Request 70621: Used full paths as volume IDs for the test CSI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70621/#review215495 --- Ship it! LGTM! - Benjamin Bannier On May 22, 2019, 5:03

Re: Review Request 70712: Added filesystem operations to the `ContainerLaunchInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70712/#review215493 --- Patch looks great! Reviews applied: [70712] Passed command:

Review Request 70712: Added filesystem operations to the `ContainerLaunchInfo`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70712/ --- Review request for mesos, Xudong Ni, Gilbert Song, Jie Yu, and Jiang Yan Xu.