Review Request 70881: Improve master CHECK messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70881/ --- Review request for mesos, Benjamin Mahler and Greg Mann. Repository: mesos

Re: Review Request 70836: Added test for DrainInfo in agent API outputs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70836/#review215956 --- Patch looks great! Reviews applied: [70822, 70839, 70834, 70835,

Re: Review Request 70822: Added common protobufs for agent draining.

> On June 14, 2019, 9:34 a.m., Benjamin Bannier wrote: > > src/messages/messages.proto > > Lines 986 (patched) > > > > > > What does it mean if the master sends a `DRAINED` state to the agent? > > Is that something

Re: Review Request 70879: Updated webui Roles tab to consistently display '-' for 0 entries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70879/#review215953 --- Patch looks great! Reviews applied: [70877, 70879] Passed

Re: Review Request 70834: Added minimal agent handler for 'DrainSlaveMessage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70834/ --- (Updated June 18, 2019, 11:20 p.m.) Review request for mesos, Benjamin

Re: Review Request 70834: Added minimal agent handler for 'DrainSlaveMessage'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70834/ --- (Updated June 18, 2019, 11:20 p.m.) Review request for mesos, Benjamin

Re: Review Request 70822: Added common protobufs for agent draining.

> On June 14, 2019, 9:34 a.m., Benjamin Bannier wrote: > > src/messages/messages.proto > > Lines 986 (patched) > > > > > > What does it mean if the master sends a `DRAINED` state to the agent? > > Is that something

Re: Review Request 70740: Windows: Removed multiple categories of sources from the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70740/#review215951 --- Ship it! Ship It! - Gilbert Song On May 28, 2019, 4:11

Re: Review Request 70740: Windows: Removed multiple categories of sources from the build.

> On June 18, 2019, 4:09 p.m., Gilbert Song wrote: > > src/uri/fetcher.hpp > > Lines 43-44 (original), 46-49 (patched) > > > > > > Probably we still want to keep the docker fetche plugin for windows. > > Otherwise,

Re: Review Request 70822: Added common protobufs for agent draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70822/ --- (Updated June 18, 2019, 11:17 p.m.) Review request for mesos, Benjamin

Re: Review Request 70822: Added common protobufs for agent draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70822/ --- (Updated June 18, 2019, 11:17 p.m.) Review request for mesos, Benjamin

Re: Review Request 70740: Windows: Removed multiple categories of sources from the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70740/#review215949 --- src/uri/fetcher.hpp Lines 43-44 (original), 46-49 (patched)

Re: Review Request 70836: Added test for DrainInfo in agent API outputs.

> On June 14, 2019, 9:59 a.m., Benjamin Bannier wrote: > > src/tests/slave_tests.cpp > > Lines 11785-11786 (patched) > > > > > > Do we want to add e.g., tasks into this test later? As written it would > > fit

Re: Review Request 70863: Assign cgroup processes after configuring the subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70863/#review215947 --- Fix it, then Ship it!

Re: Review Request 70836: Added test for DrainInfo in agent API outputs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70836/ --- (Updated June 18, 2019, 10:27 p.m.) Review request for mesos, Benjamin

Re: Review Request 70839: Added agent capability for agent draining.

> On June 12, 2019, 2:09 p.m., Benjamin Bannier wrote: > > src/common/protobuf_utils.cpp > > Line 1133 (original), 1133 (patched) > > > > > > This would have auto-upgraded would we have used a protobuf > >

Re: Review Request 70822: Added common protobufs for agent draining.

> On June 14, 2019, 11:34 a.m., Benjamin Bannier wrote: > > src/messages/messages.proto > > Lines 986 (patched) > > > > > > What does it mean if the master sends a `DRAINED` state to the agent? > > Is that

Re: Review Request 70822: Added common protobufs for agent draining.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70822/ --- (Updated June 18, 2019, 10:08 p.m.) Review request for mesos, Benjamin

Re: Review Request 70822: Added common protobufs for agent draining.

> On June 14, 2019, 9:34 a.m., Benjamin Bannier wrote: > > src/messages/messages.proto > > Lines 986 (patched) > > > > > > What does it mean if the master sends a `DRAINED` state to the agent? > > Is that something

Re: Review Request 70822: Added common protobufs for agent draining.

> On June 14, 2019, 11:34 a.m., Benjamin Bannier wrote: > > src/messages/messages.proto > > Lines 986 (patched) > > > > > > What does it mean if the master sends a `DRAINED` state to the agent? > > Is that

Re: Review Request 70877: Updated master's /roles endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70877/#review215942 --- Patch looks great! Reviews applied: [70877] Passed command:

Re: Review Request 70822: Added common protobufs for agent draining.

> On June 14, 2019, 9:34 a.m., Benjamin Bannier wrote: > > src/messages/messages.proto > > Lines 986 (patched) > > > > > > What does it mean if the master sends a `DRAINED` state to the agent? > > Is that something

Review Request 70879: Updated webui Roles tab to consistently display '-' for 0 entries.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70879/ --- Review request for mesos, Armand Grillet and Meng Zhu. Repository: mesos

Review Request 70877: Updated master's /roles endpoint to use jsonify.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70877/ --- Review request for mesos and Meng Zhu. Repository: mesos Description ---

Re: Review Request 70862: Update `EXPECT` to `ASSERT` in blkio tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70862/#review215940 --- Ship it! Ship It! - Gilbert Song On June 16, 2019, 7:13

Re: Review Request 70834: Added minimal agent handler for 'DrainSlaveMessage'.

> On June 14, 2019, 9:36 a.m., Benjamin Bannier wrote: > > src/slave/slave.hpp > > Lines 894 (patched) > > > > > > I think we nned to have something which resets this back to `None` once > > draining is

Re: Review Request 70834: Added minimal agent handler for 'DrainSlaveMessage'.

> On June 13, 2019, 12:17 p.m., Joseph Wu wrote: > > Are you planning to add the recovery logic later? (That would fit nicely > > into this patch) Yes, there is a separate ticket for the recovery logic. - Greg --- This is an

Re: Review Request 70863: Assign cgroup processes after configuring the subsystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70863/#review215932 --- Ship it! Ship It! - Qian Zhang On June 17, 2019, 10:47