Re: Review Request 71480: Fixed a bug for non-partition-aware schedulers.

2019-09-12 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71480/#review217716 --- Patch looks great! Reviews applied: [71480] Passed command:

Re: Review Request 71479: Added a test to ensure resources are recovered during agent removal.

2019-09-12 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71479/#review217715 --- Patch looks great! Reviews applied: [71459, 71460, 71476, 71479]

Re: Review Request 71481: Added some extra ASSERTs to a role test.

2019-09-12 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71481/#review217714 --- Ship it! Ship It! - Meng Zhu On Sept. 12, 2019, 5:48 p.m.,

Review Request 71481: Added some extra ASSERTs to a role test.

2019-09-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71481/ --- Review request for mesos, Benjamin Mahler, Greg Mann, and Meng Zhu.

Re: Review Request 71480: Fixed a bug for non-partition-aware schedulers.

2019-09-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71480/#review217713 --- Ship it! Ship It! - Joseph Wu On Sept. 12, 2019, 4:18 p.m.,

Review Request 71480: Fixed a bug for non-partition-aware schedulers.

2019-09-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71480/ --- Review request for mesos, Gilbert Song, Joseph Wu, and Vinod Kone. Bugs:

Review Request 71479: Added a test to ensure resources are recovered during agent removal.

2019-09-12 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71479/ --- Review request for mesos. Bugs: MESOS-621

Review Request 71476: Simplified recover resources when removing frameworks or agents.

2019-09-12 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71476/ --- Review request for mesos, Andrei Sekretenko and Benjamin Mahler. Bugs:

Re: Review Request 71478: Windows: Moved definition out of inline function call.

2019-09-12 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71478/#review217711 --- Patch looks great! Reviews applied: [71478] Passed command:

Review Request 71478: Windows: Moved definition out of inline function call.

2019-09-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71478/ --- Review request for mesos, Greg Mann and Till Toenshoff. Repository: mesos

Re: Review Request 71440: Improved allocator inverse offer test.

2019-09-12 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71440/#review217708 --- Patch looks great! Reviews applied: [68507, 68508, 71428, 71440]

Re: Review Request 71445: Removed race in `StorageLocalResourceProviderTest.Update`.

2019-09-12 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71445/#review217701 --- Patch looks great! Reviews applied: [71445] Passed command:

Re: Review Request 71460: Tracked offered and allocated resources in the role tree.

2019-09-12 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71460/#review217700 --- Fix it, then Ship it!

Re: Review Request 71445: Removed race in `StorageLocalResourceProviderTest.Update`.

2019-09-12 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71445/#review217699 --- Ship it! Ship It! - Jan Schlicht On Sept. 12, 2019, 11:01

Re: Review Request 71445: Removed race in `StorageLocalResourceProviderTest.Update`.

2019-09-12 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71445/ --- (Updated Sept. 12, 2019, 11:01 a.m.) Review request for mesos, Chun-Hung Hsiao