Re: Review Request 71660: SSL Wrapper: Stubbed out a SSL socket class.

> On Nov. 8, 2019, 12:33 a.m., Greg Mann wrote: > > 3rdparty/libprocess/src/ssl/socket_wrapper.hpp > > Lines 24-28 (patched) > > > > > > What do you think about making `SSLSocketWrapper` a true wrapper of the > >

Re: Review Request 71660: SSL Wrapper: Stubbed out a SSL socket class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71660/#review218573 --- 3rdparty/libprocess/src/CMakeLists.txt Lines 101-103 (patched)

Re: Review Request 71659: SSL Wrapper: Allowed SSL without libevent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71659/#review218572 --- cmake/CompilationConfigure.cmake Lines 263-268 (original)

Re: Review Request 71735: Added 'nodiscard' attribute to some member functions of Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71735/#review218570 --- Bad patch! Reviews applied: [71734, 71735] Failed command:

Re: Review Request 71735: Added 'nodiscard' attribute to some member functions of Resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71735/ --- (Updated Nov. 7, 2019, 2:37 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 71735: Added 'nodiscard' attribute to some Resources member functions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71735/#review218567 --- Ship it! Thanks for this. As for the formatting, personally

Re: Review Request 71722: Improved error reporting in 'Resources::pushReservation()'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71722/#review218566 --- Ship it! Thanks for this, I remember having patched that in

Re: Review Request 71734: Revamped attribute handling in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71734/ --- (Updated Nov. 7, 2019, 2:23 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 71729: Added authorization handling for reservations with `source`.

> On Nov. 6, 2019, 4:11 p.m., Benno Evers wrote: > > src/master/master.cpp > > Lines 3810 (patched) > > > > > > It doesn't seem ideal to have recursively nested calls to > > `collectauthorizations()`, even if the

[GitHub] [mesos] ArmandGrillet commented on a change in pull request #345: Allow `mesos task exec/attach` for any task_id

ArmandGrillet commented on a change in pull request #345: Allow `mesos task exec/attach` for any task_id URL: https://github.com/apache/mesos/pull/345#discussion_r343623804 ## File path: src/python/cli_new/lib/cli/http.py ## @@ -41,6 +41,8 @@ def read_endpoint(addr,

[GitHub] [mesos] brugidou commented on a change in pull request #345: Allow `mesos task exec/attach` for any task_id

brugidou commented on a change in pull request #345: Allow `mesos task exec/attach` for any task_id URL: https://github.com/apache/mesos/pull/345#discussion_r343619740 ## File path: src/python/cli_new/lib/cli/http.py ## @@ -41,6 +41,8 @@ def read_endpoint(addr, endpoint):

[GitHub] [mesos] ArmandGrillet commented on a change in pull request #345: Allow `mesos task exec/attach` for any task_id

ArmandGrillet commented on a change in pull request #345: Allow `mesos task exec/attach` for any task_id URL: https://github.com/apache/mesos/pull/345#discussion_r343617448 ## File path: src/python/cli_new/lib/cli/http.py ## @@ -41,6 +41,8 @@ def read_endpoint(addr,

Re: Review Request 71725: Added end-to-end test for operator API reservation updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71725/#review218564 --- Bad review! Reviews applied: [71725, 71729] Error: No reviewers

Re: Review Request 71729: Added authorization handling for reservations with `source`.

> On Nov. 6, 2019, 5:11 p.m., Benno Evers wrote: > > src/master/master.cpp > > Lines 3810 (patched) > > > > > > It doesn't seem ideal to have recursively nested calls to > > `collectauthorizations()`, even if the

Re: Review Request 71729: Added authorization handling for reservations with `source`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71729/ --- (Updated Nov. 7, 2019, noon) Review request for mesos and Benno Evers. Bugs: