Re: Review Request 71816: WIP: Added domain-socket related flags to Mesos agent.

2019-11-25 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71816/#review218799 --- Patch looks great! Reviews applied: [71816] Passed command:

Re: Review Request 71662: SSL Wrapper: Windows: Guarded the SSL-only connect method.

2019-11-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71662/#review218797 --- Ship it! Ship It! - Greg Mann On Oct. 23, 2019, 7:37 p.m.,

Re: Review Request 71661: Added missing header guards for poll_socket.hpp.

2019-11-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71661/#review218796 --- Fix it, then Ship it! 3rdparty/libprocess/src/poll_socket.hpp

Re: Review Request 71660: SSL Wrapper: Stubbed out a SSL socket class.

2019-11-25 Thread Greg Mann
> On Nov. 19, 2019, 1:30 p.m., Benno Evers wrote: > > 3rdparty/libprocess/src/ssl/socket_wrapper.hpp > > Lines 25 (patched) > > > > > > This is mostly bike-shedding, so feel free to drop this issue if you > >

Re: Review Request 71764: Autotools: Libprocess: Allowed SSL without libevent.

2019-11-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71764/#review218794 --- Ship it! Ship It! - Greg Mann On Nov. 13, 2019, 7:01 p.m.,

Re: Review Request 71659: SSL Wrapper: Allowed SSL without libevent.

2019-11-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71659/#review218793 --- Ship it! Ship It! - Greg Mann On Nov. 19, 2019, 7:32 p.m.,

Re: Review Request 71815: WIP: Made default executor connect via domain sockets if available.

2019-11-25 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71815/#review218790 --- Patch looks great! Reviews applied: [71814, 71815] Passed

Re: Review Request 71814: WIP: Added support for 'http+unix' URL scheme in libprocess.

2019-11-25 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71814/#review218788 --- Hm.. it doesn't seem like this should be done in the scheme. Is

Review Request 71816: WIP: Added domain-socket related flags to Mesos agent.

2019-11-25 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71816/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-10035

Review Request 71815: WIP: Made default executor connect via domain sockets if available.

2019-11-25 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71815/ --- Review request for mesos and Benjamin Bannier. Bugs: MESOS-10039

Review Request 71814: WIP: Added support for 'http+unix' URL scheme in libprocess.

2019-11-25 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71814/ --- Review request for mesos, Benjamin Bannier and Benjamin Mahler. Bugs: