Re: Review Request 71860: Moved creating authorization Object out of `Master::authorizeFramework`.

2020-01-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71860/#review219137 --- Ship it! Had to manually apply the changes here, since my

Re: Review Request 71859: Moved creating authorization Object out of `Master::authorizeTask`.

2020-01-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71859/#review219135 --- Ship it! Made the adjustment below, and will commit shortly!

Re: Review Request 71859: Moved creating authorization Object out of `Master::authorizeTask`.

2020-01-06 Thread Benjamin Mahler
> On Dec. 4, 2019, 6:21 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Lines 3736-3741 (original), 3743-3751 (patched) > > > > > > Hm.. can you reply to this comment with an example of the logging > >

Re: Review Request 71538: Allowed disabling use of NVML headers.

2020-01-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71538/#review219134 --- Patch looks great! Reviews applied: [71538] Passed command:

Re: Review Request 71538: Allowed disabling use of NVML headers.

2020-01-06 Thread Benjamin Bannier
> On Jan. 6, 2020, 2:19 p.m., Benno Evers wrote: > > configure.ac > > Lines 271 (patched) > > > > > > Why not just `--enable-nvml`/`--disable-nvml`? Good idea! - Benjamin

Re: Review Request 71538: Allowed disabling use of NVML headers.

2020-01-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71538/ --- (Updated Jan. 6, 2020, 3:43 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 71538: Allowed disabling use of NVML headers.

2020-01-06 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71538/#review219132 --- Fix it, then Ship it! configure.ac Lines 271 (patched)

Re: Review Request 71717: Made sure all targets are build for cmake `tests` target.

2020-01-06 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71717/#review219131 --- Ship it! Ship It! - Benno Evers On Jan. 6, 2020, 1:05 p.m.,

Re: Review Request 71934: Bumped site's rack to rack-1.16.12.

2020-01-06 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71934/#review219130 --- Ship it! Ship It! - Till Toenshoff On Dec. 20, 2019, 11:51

Review Request 71717: Made sure all targets are build for cmake `tests` target.

2020-01-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71717/ --- Review request for mesos, Benno Evers and Till Toenshoff. Repository: mesos

Re: Review Request 71934: Bumped site's rack to rack-1.16.12.

2020-01-06 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71934/#review219129 --- Ship it! Ship It! - Benno Evers On Dec. 20, 2019, 11:51

Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.

2020-01-06 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71947/#review219127 --- 3rdparty/libprocess/include/process/address.hpp Lines 224

Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_EnableCpuLimit`.

2020-01-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71956/#review219128 --- Patch looks great! Reviews applied: [71855, 71931, 71856, 71858,

Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.

2020-01-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71953/#review219126 --- Bad patch! Reviews applied: [71855, 71931, 71856, 71858, 71884,

Review Request 71956: Added a test `ROOT_CGROUPS_CFS_EnableCpuLimit`.

2020-01-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71956/ --- Review request for mesos, Andrei Budnik and Greg Mann. Bugs: MESOS-10047

Review Request 71955: Add a new parameter `resourceLimits` to the `createTask` methods.

2020-01-06 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71955/ --- Review request for mesos, Andrei Budnik and Greg Mann. Bugs: MESOS-10047