Re: Review Request 72410: Updated existing documentation for resource limits.

2020-04-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72410/#review220511 --- Bad patch! Reviews applied: [72408, 72409, 72410] Failed

Re: Review Request 72410: Updated existing documentation for resource limits.

2020-04-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72410/ --- (Updated April 28, 2020, 12:59 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 72409: Added intro docs on running workloads.

2020-04-27 Thread Greg Mann
> On April 22, 2020, 2:09 p.m., Qian Zhang wrote: > > docs/running-workloads.md > > Lines 57 (patched) > > > > > > I think we also need to mention this new feature (task resource limits > > support) in

Re: Review Request 72409: Added intro docs on running workloads.

2020-04-27 Thread Greg Mann
> On April 22, 2020, 1:21 p.m., Qian Zhang wrote: > > docs/running-workloads.md > > Lines 30 (patched) > > > > > > What do you mean for "task is specified with executor ID"? Why do we > > want to specify an executor

Re: Review Request 72409: Added intro docs on running workloads.

2020-04-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72409/ --- (Updated April 27, 2020, 11:57 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 72408: Made the scheduler resources a top-level item in the documentation.

2020-04-27 Thread Greg Mann
> On April 22, 2020, 9:07 a.m., Qian Zhang wrote: > > docs/home.md > > Line 76 (original), 76 (patched) > > > > > > Should we name it `Frameworks`? I went with Ben's suggestion, let me know what you think! - Greg

Re: Review Request 72408: Made the scheduler resources a top-level item in the documentation.

2020-04-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72408/ --- (Updated April 27, 2020, 11:55 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 72410: Updated existing documentation for resource limits.

2020-04-27 Thread Greg Mann
> On April 22, 2020, 2:02 p.m., Qian Zhang wrote: > > docs/nested-container-and-task-group.md > > Lines 74 (patched) > > > > > > I see https://reviews.apache.org/r/72409 already has the content of > > this section,

Re: Review Request 72409: Added intro docs on running workloads.

2020-04-27 Thread Greg Mann
> On April 22, 2020, 1:21 p.m., Qian Zhang wrote: > > docs/running-workloads.md > > Lines 30 (patched) > > > > > > What do you mean for "task is specified with executor ID"? Why do we > > want to specify an executor

Re: Review Request 72435: Set OOM score adj when Docker container's memory limit is infinite.

2020-04-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72435/#review220502 --- Ship it! Ship It! - Greg Mann On April 27, 2020, 6:20 a.m.,

Re: Review Request 72442: Reverted the changes about `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED`.

2020-04-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72442/#review220501 --- Patch looks great! Reviews applied: [72442] Passed command:

Review Request 72442: Reverted the changes about `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED`.

2020-04-27 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72442/ --- Review request for mesos, Andrei Budnik and Greg Mann. Bugs: MESOS-10049

Re: Review Request 72435: Set OOM score adj when Docker container's memory limit is infinite.

2020-04-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72435/#review220496 --- Patch looks great! Reviews applied: [72435] Passed command:

[GitHub] [mesos] akornatskyy commented on pull request #361: Added ability to specify a root dir for boost-libs, curl and libseccomp.

2020-04-27 Thread GitBox
akornatskyy commented on pull request #361: URL: https://github.com/apache/mesos/pull/361#issuecomment-619808069 @asekretenko @greggomann : this is another improvement to cmake to be able to build with a custom location of boost-libs, curl and libseccomp.

[GitHub] [mesos] akornatskyy opened a new pull request #361: Added ability to specify a root dir for boost-libs, curl and libseccomp.

2020-04-27 Thread GitBox
akornatskyy opened a new pull request #361: URL: https://github.com/apache/mesos/pull/361 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [mesos] akornatskyy commented on pull request #360: Fix java bindings.

2020-04-27 Thread GitBox
akornatskyy commented on pull request #360: URL: https://github.com/apache/mesos/pull/360#issuecomment-619805494 @asekretenko @greggomann Fixed mesos java bindings for cmake by reversing dependency so `libmesos-java` depends on `libmesos`.

[GitHub] [mesos] akornatskyy opened a new pull request #360: Fix java bindings.

2020-04-27 Thread GitBox
akornatskyy opened a new pull request #360: URL: https://github.com/apache/mesos/pull/360 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Review Request 72435: Set OOM score adj when Docker container's memory limit is infinite.

2020-04-27 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72435/ --- Review request for mesos, Andrei Budnik and Greg Mann. Bugs: MESOS-10053