Re: Review Request 72728: Added a unit test for the CSI server.

> On Aug. 12, 2020, 11:18 a.m., Qian Zhang wrote: > > src/tests/csi_server_tests.cpp > > Lines 114-121 (patched) > > > > > > It seems the required flag > >

Re: Review Request 72728: Added a unit test for the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72728/#review221553 --- src/tests/csi_server_tests.cpp Lines 96 (patched)

Re: Review Request 72727: Updated the test CSI plugin for CSI server testing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72727/#review221554 --- src/examples/test_csi_plugin.cpp Lines 174-177 (patched)

Re: Review Request 72728: Added a unit test for the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72728/#review221552 --- src/tests/csi_server_tests.cpp Lines 89-92 (original)

Re: Review Request 72728: Added a unit test for the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72728/#review221550 --- Patch looks great! Reviews applied: [72732, 72716, 72726, 72727,

Re: Review Request 72740: Introduced an interface for plugging offer filtering into the allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72740/#review221549 --- include/mesos/allocator/allocator.hpp Lines 72-96 (patched)

Re: Review Request 72739: Introduced a `FrameworkOptions` struct into the allocator interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72739/#review221548 --- Ship it! Ok, so recoverFramework does not need the allocation

Re: Review Request 72738: Added protobuf messages for constraints-based offer filtering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72738/#review221547 --- Ship it! Overall structure looks good! I just left a

Re: Review Request 72727: Updated the test CSI plugin for CSI server testing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72727/ --- (Updated Aug. 11, 2020, 6:55 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72727: Updated the test CSI plugin for CSI server testing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72727/#review221544 --- src/examples/test_csi_plugin.cpp Lines 1589-1590 (original),

Re: Review Request 72754: Enabled the `volume/csi` isolator in `MesosContainerizer`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72754/#review221542 --- Patch looks great! Reviews applied: [72732, 72716, 72690, 72733,

Re: Review Request 72733: Implemented the `prepare` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72733/ --- (Updated Aug. 11, 2020, 4:32 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72753: Implemented the `recover` method of `volume/csi` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72753/ --- (Updated Aug. 11, 2020, 4:31 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72728: Added a unit test for the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72728/#review221538 --- Bad patch! Reviews applied: [72732, 72716, 72726, 72727, 72728]