Re: Review Request 72779: Initialized plugins lazily in the CSI server.

> On Aug. 19, 2020, 3:43 p.m., Qian Zhang wrote: > > src/slave/csi_server.cpp > > Line 136 (original), 155 (patched) > > > > > > If `name` is specified, do we need to do this `os::ls`? I think we can > > just load

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72779/#review221653 --- src/slave/csi_server.cpp Lines 186 (patched)

Re: Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/#review221652 --- Ship it! Ship It! - Qian Zhang On Aug. 20, 2020, 5:48 a.m.,

Re: Review Request 72787: Added basic tests for regexp-based constraints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72787/#review221651 --- Bad patch! Reviews applied: [72771, 72738, 72739, 72741, 72742,

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72779/#review221650 --- Patch looks great! Reviews applied: [72732, 72716, 72690, 72733,

Re: Review Request 72728: Added unit tests for the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72728/ --- (Updated Aug. 19, 2020, 9:50 p.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/ --- (Updated Aug. 19, 2020, 9:48 p.m.) Review request for mesos and Qian Zhang.

Re: Review Request 72783: Added RE2 to the automake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72783/#review221649 --- Ship it! Ship It! - Benjamin Mahler On Aug. 18, 2020, 7:01

Re: Review Request 72782: Added RE2 to the CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72782/#review221648 --- Ship it! Looks like there is a newer 2020-08-01 release with 1

Re: Review Request 72741: Implemented offer constraints filter with Exists/NotExists predicates.

> On Aug. 17, 2020, 10:03 p.m., Benjamin Mahler wrote: > > include/mesos/allocator/allocator.hpp > > Lines 76 (patched) > > > > > > Hm.. not obvious to me why we need this, can you explain in a comment? > > Andrei

Re: Review Request 72745: Added protobuf messages for offer constraints on a string equality.

> On Aug. 19, 2020, 7:03 p.m., Benjamin Mahler wrote: > > include/mesos/scheduler/scheduler.proto > > Lines 275-276 (original), 275-290 (patched) > > > > > > I'm still struggling to get a good grasp on the cases

Re: Review Request 72745: Added protobuf messages for offer constraints on a string equality.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72745/ --- (Updated Aug. 19, 2020, 8:16 p.m.) Review request for mesos and Benjamin

Re: Review Request 72787: Added basic tests for regexp-based constraints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72787/#review221645 --- Bad patch! Reviews applied: [72771, 72738, 72739, 72741, 72742,

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

> On Aug. 19, 2020, 7:43 a.m., Qian Zhang wrote: > > src/slave/csi_server.cpp > > Lines 130-132 (patched) > > > > > > I see this method will always be called with name specifed in > >

Re: Review Request 72745: Added protobuf messages for offer constraints on a string equality.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72745/#review221644 --- include/mesos/scheduler/scheduler.proto Lines 275-276

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72779/ --- (Updated Aug. 19, 2020, 7:04 p.m.) Review request for mesos and Qian Zhang.

Re: Review Request 72744: Added a scheduler API test for a valid offer constraints update.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72744/#review221643 --- Ship it! src/tests/master/update_framework_tests.cpp Lines

Re: Review Request 72782: Added RE2 to the CMake build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72782/ --- (Updated Aug. 19, 2020, 6:02 p.m.) Review request for mesos and Benjamin

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

> On Aug. 19, 2020, 7:43 a.m., Qian Zhang wrote: > > src/slave/csi_server.cpp > > Line 136 (original), 155 (patched) > > > > > > If `name` is specified, do we need to do this `os::ls`? I think we can > > just load

Re: Review Request 72787: Added basic tests for regexp-based constraints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72787/#review221640 --- Bad patch! Reviews applied: [72771, 72738, 72739, 72741, 72742,

Re: Review Request 72787: Added basic tests for regexp-based constraints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72787/#review221639 --- Bad patch! Reviews applied: [72771, 72738, 72739, 72741, 72742,

Re: Review Request 72743: Wired up creating `OfferConstraintsFilter` into the schdeuler API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72743/ --- (Updated Aug. 19, 2020, 1:28 p.m.) Review request for mesos and Benjamin

Re: Review Request 72774: Wired up the `OfferConstraintsFilter` into the hierarchical allocator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72774/ --- (Updated Aug. 19, 2020, 1:27 p.m.) Review request for mesos and Benjamin

Re: Review Request 72787: Added basic tests for regexp-based constraints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72787/ --- (Updated Aug. 19, 2020, 12:09 p.m.) Review request for mesos and Benjamin

Re: Review Request 72776: Added basic tests for offer constraints on a string attribute equality.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72776/ --- (Updated Aug. 19, 2020, 12:01 p.m.) Review request for mesos and Benjamin

Re: Review Request 72742: Added basic tests for the `OfferConstraintsFilter`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72742/ --- (Updated Aug. 19, 2020, noon) Review request for mesos and Benjamin Mahler.

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72779/#review221638 --- Patch looks great! Reviews applied: [72732, 72716, 72690, 72733,

Re: Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/#review221637 --- Ship it! Ship It! - Qian Zhang On Aug. 19, 2020, 2:16 p.m.,

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72779/#review221636 --- src/slave/csi_server.cpp Lines 130-132 (patched)

Re: Review Request 72761: Added the CSI server to the Mesos agent.

> On Aug. 19, 2020, 3:01 a.m., Qian Zhang wrote: > > src/slave/slave.cpp > > Lines 1747 (patched) > > > > > > As we discussed in https://reviews.apache.org/r/72759/#comment310644 , > > this should be

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

> On Aug. 17, 2020, 7:15 a.m., Qian Zhang wrote: > > src/slave/csi_server.cpp > > Line 225 (original), 212 (patched) > > > > > > What if this method fails somewhere and returns a `Failure`? As the > > result

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72779/ --- (Updated Aug. 19, 2020, 6:23 a.m.) Review request for mesos and Qian Zhang.

Re: Review Request 72779: Initialized plugins lazily in the CSI server.

> On Aug. 17, 2020, 3:13 a.m., Qian Zhang wrote: > > src/slave/csi_server.cpp > > Lines 204 (patched) > > > > > > Will this `repair` get invoked when each of the above `then()` fails? > > Or it will get invoked

Re: Review Request 72728: Added a unit test for the CSI server.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72728/ --- (Updated Aug. 19, 2020, 6:18 a.m.) Review request for mesos, Andrei Budnik and

Re: Review Request 72761: Added the CSI server to the Mesos agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72761/ --- (Updated Aug. 19, 2020, 6:16 a.m.) Review request for mesos and Qian Zhang.