Re: Review Request 63861: Updated networking doc for Windows docker containers.

ally generated e-mail. To reply, visit: https://reviews.apache.org/r/63861/#review191218 ------- On Nov. 16, 2017, 6:18 p.m., Akash Gupta wrote: > > --- > This is an automatically generated e

Re: Review Request 63860: Fixed docker network settings for Windows.

docs that describe how nat works. - Akash --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/#review191217 ------- On Nov. 16, 2017, 6:18 p.m., Akash Gupta wrote: > > ---

Re: Review Request 63859: Fixed signal vals & WEXITSTATUS on Windows stout.

3971line378> > > > > Should this be a static cast? yep - Akash --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63859/#review191213 --------

Review Request 63861: Updated networking doc for Windows docker containers.

/ Testing --- Thanks, Akash Gupta

Review Request 63862: Ported docker_tests.cpp to Windows.

DockerTest (only 12 tests instead of 14, because I don't have Nvidia GPU): [==] 12 tests from 1 test case ran. (12413 ms total) [ PASSED ] 12 tests. Thanks, Akash Gupta

Review Request 63860: Fixed docker network settings for Windows.

/63860/diff/1/ Testing (updated) --- See https://reviews.apache.org/r/63862/ for test results. Thanks, Akash Gupta

Review Request 63859: Fixed signal vals & WEXITSTATUS on Windows stout.

rg/r/63859/diff/1/ Testing (updated) --- See https://reviews.apache.org/r/63862/ for test results. Thanks, Akash Gupta

Re: Review Request 63276: Windows: Added `Cpu` and `Mem` isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63276/#review190966 --- Ship it! Ship It! - Akash Gupta On Nov. 14, 2017, 1:57 a.m

Re: Review Request 63277: Windows: Ported CPU and memory isolator tests.

(original), 270 (patched) <https://reviews.apache.org/r/63277/#comment268551> Personally, I think it makes sense to increase this time on Windows. Powershell takes some time to start up, so one second isn't enough. - Akash Gupta On Nov. 6, 2017, 11:19 p.m., Andrew Schwartzmeyer

Re: Review Request 63278: Windows: Documented the `cpu` and `mem` isolators.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63278/#review190885 --- Ship it! Ship It! - Akash Gupta On Nov. 6, 2017, 11:19 p.m

Re: Review Request 63275: Windows: Abstracted out `os::name_job` in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63275/#review190884 --- Ship it! Ship It! - Akash Gupta On Nov. 2, 2017, 8:40 p.m

Re: Review Request 63274: Windows: Added `os::get_job_memory` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63274/#review190774 --- Ship it! Ship It! - Akash Gupta On Nov. 2, 2017, 8:40 p.m

Re: Review Request 63273: Windows: Added `os::get_job_processes` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63273/#review190773 --- Ship it! Ship It! - Akash Gupta On Nov. 2, 2017, 8:40 p.m

Re: Review Request 63272: Windows: Added `os::get_job_info` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63272/#review190772 --- Ship it! Ship It! - Akash Gupta On Nov. 2, 2017, 8:40 p.m

Re: Review Request 63271: Windows: Added `os::set_job_memory_limit` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63271/#review190771 --- Ship it! Ship It! - Akash Gupta On Nov. 2, 2017, 8:39 p.m

Re: Review Request 63269: Windows: Added `os::set_job_cpu_limit` to stout.

) to get the right number. There was a bug fix in python with a similar issue to this: https://github.com/python/cpython/commit/c67bae04780f9d7590f9f91b4ee5f31c5d75b3c3 - Akash Gupta On Nov. 2, 2017, 8:39 p.m., Andrew

Re: Review Request 63269: Windows: Added `os::set_job_cpu_limit` to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63269/#review190768 --- Ship it! Ship It! - Akash Gupta On Nov. 2, 2017, 8:39 p.m

Re: Review Request 63269: Windows: Added `os::set_job_cpu_limit` to stout.

) <https://reviews.apache.org/r/63269/#comment268377> small nit, but for consistency, change false to FALSE. - Akash Gupta On Nov. 2, 2017, 8:39 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically g

Re: Review Request 63268: Windows: Fixed variable casing in `windows/os.hpp`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63268/#review190754 --- Ship it! Ship It! - Akash Gupta On Nov. 2, 2017, 8:39 p.m

<    1   2   3   4