-mail. To reply, visit:
> https://reviews.apache.org/r/56812/
> ---
>
> (Updated Feb. 28, 2017, 7:37 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till
> Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.or
cess-tests \
--gtest_filter="FutureTest.After3" --gtest_repeat=100
--gtest_break_on_failure
$ ./${MESOS_SRC_ROOT}/build/build/src/mesos-tests
```
Thanks,
Alexander Rojas
> On Feb. 27, 2017, 12:58 p.m., Alexander Rojas wrote:
> > 3rdparty/libprocess/include/process/authenticator.hpp, line 62
> > <https://reviews.apache.org/r/56623/diff/7/?file=1646581#file1646581line62>
> >
> > `static` keyword doesn't have that much use
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56619/#review166883
---
Ship it!
Ship It!
- Alexander Rojas
On Feb. 25, 2017, 12:06
cess-tests \
--gtest_filter="FutureTest.After3" --gtest_repeat=100
--gtest_break_on_failure
$ ./${MESOS_SRC_ROOT}/build/build/src/mesos-tests
```
Thanks,
Alexander Rojas
----
On Feb. 21, 2017, 9:34 p.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55576/
> -
` is set to `false`.
Diffs
-
3rdparty/libprocess/src/clock.cpp 6116c82377b1c2f33c5f4bc14890d35f34cc973d
Diff: https://reviews.apache.org/r/57093/diff/
Testing
---
`make check`
Full test tried in next patch.
Thanks,
Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57054/#review166866
---
Ship it!
Thanks for taking care of this!
- Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56901/#review166862
---
Ship it!
Ship It!
- Alexander Rojas
On Feb. 22, 2017, 8:48
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56618/#review166854
---
Ship it!
Ship It!
- Alexander Rojas
On Feb. 22, 2017, 2:15
or the whole function could be
moved to `authenticator.cpp`
3rdparty/libprocess/include/process/authenticator.hpp (lines 100 - 101)
<https://reviews.apache.org/r/56623/#comment238938>
Any reason we cannot do this in this patchset?
- Alexander Rojas
On Feb. 24, 2017, 1:05 a.m
> On Aug. 22, 2016, 4:29 a.m., Vinod Kone wrote:
> > Have you also done compatibility tests mentioned in the ticket?
>
> Tomasz Janiszewski wrote:
> No. It's minior upgrade from 1.18 to 1.19 but I can got thur
>
.
$ stress -c 4 -t 2600 -d 2 -i 2 &
$ ./${MESOS_SRC_ROOT}/build/3rdparty/libprocess/libprocess-tests \
--gtest_filter="FutureTest.After3" --gtest_repeat=100
--gtest_break_on_failure
$ ./${MESOS_SRC_ROOT}/build/build/src/mesos-tests
```
Thanks,
Alexander Rojas
> On Feb. 16, 2017, 11:45 a.m., Alexander Rojas wrote:
> > 3rdparty/libprocess/src/http.cpp, lines 87-109
> > <https://reviews.apache.org/r/56623/diff/1/?file=1632560#file1632560line87>
> >
> > Why not going the fancy way and use `jsonify()`?
Just add th
lter="FutureTest.After3" --gtest_repeat=100
--gtest_break_on_failure
$ ./${MESOS_SRC_ROOT}/build/build/src/mesos-tests
```
Thanks,
Alexander Rojas
here is the way to go, we don't seem to use it
for `http::Request`. This goes with my idea of just using
`http::authentication::Context` as the name type.
- Alexander Rojas
On Feb. 14, 2017, 1:14 a.m., Greg Mann wrote:
>
> ---
> Thi
gt; ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56618/
> ---
>
> (Updated Feb. 14, 2017, 12:46 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till
&g
uf generated
`Subject` class so this is not a free function.
- Alexander Rojas
On Feb. 14, 2017, 12:46 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56617/#review165824
---
Ship it!
Ship It!
- Alexander Rojas
On Feb. 14, 2017, 4:41
authenticator.cpp`
3rdparty/libprocess/src/http.cpp (lines 87 - 109)
<https://reviews.apache.org/r/56623/#comment237667>
Why not going the fancy way and use `jsonify()`?
- Alexander Rojas
On Feb. 1
://reviews.apache.org/r/54784/diff/
Testing
---
make check
Thanks,
Alexander Rojas
, but not to attach to its input, therefore its attempts should
fail.
Diffs
-
src/tests/api_tests.cpp aa7d89a710400d1460bc9139ea563cfdd45bd58f
Diff: https://reviews.apache.org/r/54784/diff/
Testing
---
make check
Thanks,
Alexander Rojas
.
Diffs (updated)
-
src/tests/api_tests.cpp aa7d89a710400d1460bc9139ea563cfdd45bd58f
Diff: https://reviews.apache.org/r/54783/diff/
Testing
---
make check
Thanks,
Alexander Rojas
nested container sessions.
Diffs (updated)
-
src/tests/api_tests.cpp aa7d89a710400d1460bc9139ea563cfdd45bd58f
Diff: https://reviews.apache.org/r/54783/diff/
Testing
---
make check
Thanks,
Alexander Rojas
://reviews.apache.org/r/54783/diff/
Testing
---
make check
Thanks,
Alexander Rojas
--
>
> (Updated Feb. 14, 2017, 12:46 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till
> Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7003
> https://issues.apache.org/jira/browse/MESOS-7003
>
&g
uld suggest to only giving it a thought.
- Alexander Rojas
On Feb. 11, 2017, 1:44 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
ibprocess/src/tests/http_tests.cpp (lines 1860 - 1863)
<https://reviews.apache.org/r/56475/#comment237170>
Probably create the expected value in a variable outside of the `EXPECT_EQ`?
- Alexander
3>
I think the keyword `auto` is prefered when extracting iterators,
[reference](https://github.com/apache/mesos/blob/master/docs/c%2B%2B-style-guide.md#c11)
- Alexander Rojas
On Feb. 11, 2017, 1:44 a.m., Greg Mann wrote:
>
>
n Feb. 10, 2017, 12:27 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56178/
> ---
>
> (Updated Feb. 10, 201
(lines 246 - 247)
<https://reviews.apache.org/r/56178/#comment236229>
Better: _Remove this `if` branch at the end of `value` deprecation cycle._
- Alexander Rojas
On Feb. 6, 2017, 8:32 p.m., Benjamin Bannier
all the futures in
// the list reach a final state.
await(authorizations)
.then([](const list<Future>& authorizations) {
// Add here the actual body of the foreach
});
```
- Alexander Rojas
On Jan. 25, 2017, 1:31
g/r/56178/#comment236027>
Probably add a _TODO_ requesting to remove these lines after end of
deprecation period.
- Alexander Rojas
On Feb. 3, 2017, 1:10 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically g
---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56178/
> ---
>
> (Updated Feb. 3, 2017, 1:10 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rojas, and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55679/#review162286
---
Ship it!
Ship It!
- Alexander Rojas
On Jan. 19, 2017, 11:17
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55678/#review162282
---
Ship it!
Ship It!
- Alexander Rojas
On Jan. 19, 2017, 11:17
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55677/#review162274
---
Ship it!
Ship It!
- Alexander Rojas
On Jan. 19, 2017, 11:17
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55676/#review162267
---
Ship it!
Ship It!
- Alexander Rojas
On Jan. 19, 2017, 11:15
676/#comment233609>
Rebase problem?
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/55676/#comment233610>
Rebase problem?
- Alexander Rojas
On Jan. 18, 2017, 8:01 p.m., Gastón K
cess/libprocess-tests \
--gtest_filter="FutureTest.After3" --gtest_repeat=100
--gtest_break_on_failure
$ ./${MESOS_SRC_ROOT}/build/build/src/mesos-tests
```
Thanks,
Alexander Rojas
arty/libprocess/libprocess-tests \
--gtest_filter="FutureTest.After3" --gtest_repeat=100
--gtest_break_on_failure
$ ./${MESOS_SRC_ROOT}/build/build/src/mesos-tests
```
Thanks,
Alexander Rojas
lter="FutureTest.After3" --gtest_repeat=100
--gtest_break_on_failure
$ ./${MESOS_SRC_ROOT}/build/build/src/mesos-tests
```
Thanks,
Alexander Rojas
464/#comment232633>
Why not replacing this test with one that shows the opposite?
- Alexander Rojas
On Jan. 12, 2017, 4:30 p.m., Gastón Kleiman wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
(!per_thread) {
_configthreadlocale(_DISABLE_PER_THREAD_LOCALE)
}
```
- Alexander Rojas
On Jan. 12, 2017, 1:56 a.m., Joseph Wu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
same time, changing the locale of the stream is
not thread safe (although using the stream concurrently should be heavily
discouraged).
- Alexander Rojas
On Jan. 11, 2017, 11:03 a.m., Michael Park wrote:
>
> ---
> This is an aut
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55296/#review161047
---
Ship it!
Ship It!
- Alexander Rojas
On Jan. 10, 2017, 1:36
tps://reviews.apache.org/r/55296/#comment232146>
This needs either UNREACHABLE() or to return stream to avoid warnings.
- Alexander Rojas
On Jan. 7, 2017, 11:02 a.m., Michael Park wrote:
>
> ---
> This is an automatically g
: "");
ss->str("");
```
Performance
```
Run on (8 X 2800 MHz CPU s)
2017-01-03 15:12:37
Benchmark Time CPU Iterations
-
BM_Jsonify980 ns980 ns 716413
```
Surprisingly, proposal 2 seemed to be the most efficient after multiple runs of
the suite.
Thanks,
Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55319/#review160889
---
Ship it!
Ship It!
- Alexander Rojas
On Jan. 8, 2017, 8:45
quot;);
*stream_ << trimmed << (trimmed.back() == '.' ? "0" : "");
ss->str("");
```
Performance
```
Run on (8 X 2800 MHz CPU s)
2017-01-03 15:12:37
Benchmark Time CPU Iterations
-
BM_Jsonify980 ns980 ns 716413
```
Surprisingly, proposal 2 seemed to be the most efficient after multiple runs of
the suite.
Thanks,
Alexander Rojas
X, "0");
*stream_ << trimmed << (trimmed.back() == '.' ? "0" : "");
ss->str("");
```
Performance
```
Run on (8 X 2800 MHz CPU s)
2017-01-03 15:12:37
Benchmark Time CPU Iterations
-
BM_Jsonify980 ns980 ns 716413
```
Surprisingly, proposal 2 seemed to be the most efficient after multiple runs of
the suite.
Thanks,
Alexander Rojas
gt; > @ 0x603951 RUN_ALL_TESTS()
> > @ 0x603657 main
> > @ 0x7fa01f229a40 (unknown)
> > @ 0x419019 _start
> > Segmentation fault (core dumped)
> > ```
> >
> > Can you run this test with repeat enab
iterations.
./3rdparty/libprocess/libprocess-tests --gtest_filter="FutureTest.After3"
--gtest_repeat=-1 --gtest_break_on_failure
```
Thanks,
Alexander Rojas
nt;
initialized = true;
}
*ss << double_;
std::string trimmed = strings::trim(ss->str(), strings::SUFFIX, "0");
*stream_ << trimmed << (trimmed.back() == '.' ? "0" : "");
ss->str("");
```
Performance
```
Run on (8 X 2800 MHz CPU s)
2017-01-03 15:12:37
Benchmark Time CPU Iterations
-
BM_Jsonify980 ns980 ns 716413
```
Surprisingly, proposal 2 seemed to be the most efficient after multiple runs of
the suite.
Thanks,
Alexander Rojas
quot;);
*stream_ << trimmed << (trimmed.back() == '.' ? "0" : "");
ss->str("");
```
Performance
```
Run on (8 X 2800 MHz CPU s)
2017-01-03 15:12:37
Benchmark Time CPU Iterations
-
BM_Jsonify980 ns980 ns 716413
```
Surprisingly, proposal 2 seemed to be the most efficient after multiple runs of
the suite.
Thanks,
Alexander Rojas
}
*ss << double_;
std::string trimmed = strings::trim(ss->str(), strings::SUFFIX, "0");
*stream_ << trimmed << (trimmed.back() == '.' ? "0" : "");
ss->str("");
```
Performance
```
Run on (8 X 2800 MHz CPU s)
2017-01-03 15:12:37
Benchmark Time CPU Iterations
-
BM_Jsonify980 ns980 ns 716413
```
Surprisingly, proposal 2 seemed to be the most efficient after multiple runs of
the suite.
Thanks,
Alexander Rojas
---
`make check`
Thanks,
Alexander Rojas
> > Can you run this test with repeat enabled and debug this issue?
I was not that easy to reproduce, but the root of the problem is that `Clock`
may delete the timers after the tests, which causes `use_count` to be different
from 1, I have a fix coming when I have run the
.
Repository: mesos
Description
---
Adds tests for authorization when attaching to a container input.
Diffs
-
src/tests/api_tests.cpp 82c0fc27e5e707adb73faeb26828a2ce3e3feb16
Diff: https://reviews.apache.org/r/54784/diff/
Testing (updated)
---
make check
Thanks,
Alexander Rojas
---
Adds tests for authorization when attaching to a container input.
Diffs
-
src/tests/api_tests.cpp 82c0fc27e5e707adb73faeb26828a2ce3e3feb16
Diff: https://reviews.apache.org/r/54784/diff/
Testing
---
Thanks,
Alexander Rojas
Thanks,
Alexander Rojas
---
Adds a unit test which checks authorization when launching
a nested container session.
Diffs
-
src/tests/api_tests.cpp 82c0fc27e5e707adb73faeb26828a2ce3e3feb16
Diff: https://reviews.apache.org/r/54783/diff/
Testing
---
Thanks,
Alexander Rojas
/libprocess/include/process/future.hpp
26bf5851f6562cd73aa4938b3308639144657044
3rdparty/libprocess/src/tests/future_tests.cpp
7c411c7be1849119fe0b070622dbe4488fa11b7a
Diff: https://reviews.apache.org/r/53299/diff/
Testing
---
`make check`
Thanks,
Alexander Rojas
s
where the `Authorizer::authorized()` calls exist.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54662/#review158974
---
places
where the `Authorizer::authorized()` calls exist.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54661/#review158973
-------
8a71eadd8f26df147ddea800221b6f243280bf3b
Diff: https://reviews.apache.org/r/54661/diff/
Testing
---
make check
Thanks,
Alexander Rojas
059eb770051f54d5d1fc116bd491f460ee177b0a
Diff: https://reviews.apache.org/r/54538/diff/
Testing
---
make check
Thanks,
Alexander Rojas
059eb770051f54d5d1fc116bd491f460ee177b0a
Diff: https://reviews.apache.org/r/54538/diff/
Testing
---
make check
Thanks,
Alexander Rojas
/slave.hpp 059eb770051f54d5d1fc116bd491f460ee177b0a
Diff: https://reviews.apache.org/r/54538/diff/
Testing
---
make check
Thanks,
Alexander Rojas
/authorizer.cpp 3b983d0c0dea3ad761e7c684a9f943809dc541e9
src/tests/authorization_tests.cpp f70d60d73a64e7eb4be20a17b62a8726b659e1b8
Diff: https://reviews.apache.org/r/54535/diff/
Testing
---
make check
Thanks,
Alexander Rojas
)
-
3rdparty/libprocess/include/process/future.hpp
26bf5851f6562cd73aa4938b3308639144657044
3rdparty/libprocess/src/tests/future_tests.cpp
7c411c7be1849119fe0b070622dbe4488fa11b7a
Diff: https://reviews.apache.org/r/53299/diff/
Testing
---
`make check`
Thanks,
Alexander Rojas
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53299/#review158898
-------
On Oct. 31, 2016, 3:48 p.m., Alexander Rojas wrote:
>
> ---
/diff/
Testing
---
make check
Thanks,
Alexander Rojas
/diff/
Testing
---
make check
Thanks,
Alexander Rojas
8a71eadd8f26df147ddea800221b6f243280bf3b
src/slave/slave.hpp 059eb770051f54d5d1fc116bd491f460ee177b0a
Diff: https://reviews.apache.org/r/54538/diff/
Testing (updated)
---
make check
Thanks,
Alexander Rojas
---
make check
Thanks,
Alexander Rojas
3b983d0c0dea3ad761e7c684a9f943809dc541e9
Diff: https://reviews.apache.org/r/54655/diff/
Testing (updated)
---
make check
Thanks,
Alexander Rojas
`.
Diffs (updated)
-
src/slave/http.cpp 580a90b5547dd26ac5d26e0fd2fc1471a382f62d
src/slave/slave.hpp ecfca05ffd1ff72918cd803f6a70809efaae4f17
Diff: https://reviews.apache.org/r/54538/diff/
Testing
---
** Needs more testing **
make check
Thanks,
Alexander Rojas
part of `/containers`?
pretty much so.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54538/#review158795
---
On Dec. 9,
: https://reviews.apache.org/r/54655/diff/
Testing
---
Thanks,
Alexander Rojas
------
On Dec. 9, 2016, 4:32 p.m., Alexander Rojas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54535/
> ---
/authorizer.cpp 3b983d0c0dea3ad761e7c684a9f943809dc541e9
src/tests/authorization_tests.cpp f70d60d73a64e7eb4be20a17b62a8726b659e1b8
Diff: https://reviews.apache.org/r/54535/diff/
Testing
---
make check
Thanks,
Alexander Rojas
ecfca05ffd1ff72918cd803f6a70809efaae4f17
Diff: https://reviews.apache.org/r/54538/diff/
Testing
---
** Needs more testing **
make check
Thanks,
Alexander Rojas
://reviews.apache.org/r/54538/diff/
Testing
---
** Needs more testing **
make check
Thanks,
Alexander Rojas
3b983d0c0dea3ad761e7c684a9f943809dc541e9
src/tests/authorization_tests.cpp f70d60d73a64e7eb4be20a17b62a8726b659e1b8
Diff: https://reviews.apache.org/r/54535/diff/
Testing
---
make check
Thanks,
Alexander Rojas
4b94dff9c1f9f212f84984674268ef38b43d93bd
src/slave/slave.cpp 7eb45036f49289972c0b706c3c8e2ed96553d279
src/tests/api_tests.cpp 7c70f284a9225ca23abc7049f48f3efba314b641
Diff: https://reviews.apache.org/r/54381/diff/
Testing
---
make check
Thanks,
Alexander Rojas
t of unncesesary copying.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54381/#review158255
---
On Dec. 6,
4b94dff9c1f9f212f84984674268ef38b43d93bd
src/slave/slave.cpp 7eb45036f49289972c0b706c3c8e2ed96553d279
src/tests/api_tests.cpp 7c70f284a9225ca23abc7049f48f3efba314b641
Diff: https://reviews.apache.org/r/54381/diff/
Testing
---
make check
Thanks,
Alexander Rojas
ntainerizer to be called.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54381/#review158090
---
On Dec. 5,
/tests/api_tests.cpp 7c70f284a9225ca23abc7049f48f3efba314b641
Diff: https://reviews.apache.org/r/54381/diff/
Testing
---
make check
Thanks,
Alexander Rojas
0696a629ac2d2b9950e20708f0c3666b58ff7ca0
src/authorizer/local/authorizer.cpp 77e05dd2475d6e7511e7c7eeea578ec31ff3d198
src/tests/authorization_tests.cpp d23f551c2caa454da0c0f6cb7d77a8c2bd75a474
Diff: https://reviews.apache.org/r/53541/diff/
Testing
---
make check
Thanks,
Alexander Rojas
0696a629ac2d2b9950e20708f0c3666b58ff7ca0
src/authorizer/local/authorizer.cpp 77e05dd2475d6e7511e7c7eeea578ec31ff3d198
src/tests/authorization_tests.cpp d23f551c2caa454da0c0f6cb7d77a8c2bd75a474
Diff: https://reviews.apache.org/r/53541/diff/
Testing
---
make check
Thanks,
Alexander Rojas
h so, but `permissive=false` affects all the ACLs.
- Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53541/#review157211
---
On Nov.
0696a629ac2d2b9950e20708f0c3666b58ff7ca0
src/authorizer/local/authorizer.cpp 77e05dd2475d6e7511e7c7eeea578ec31ff3d198
src/tests/authorization_tests.cpp d23f551c2caa454da0c0f6cb7d77a8c2bd75a474
Diff: https://reviews.apache.org/r/53541/diff/
Testing
---
make check
Thanks,
Alexander Rojas
src/tests/authorization_tests.cpp d23f551c2caa454da0c0f6cb7d77a8c2bd75a474
Diff: https://reviews.apache.org/r/53541/diff/
Testing
---
make check
Thanks,
Alexander Rojas
d23f551c2caa454da0c0f6cb7d77a8c2bd75a474
Diff: https://reviews.apache.org/r/53541/diff/
Testing
---
make check
Thanks,
Alexander Rojas
d23f551c2caa454da0c0f6cb7d77a8c2bd75a474
Diff: https://reviews.apache.org/r/53541/diff/
Testing
---
make check
Thanks,
Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54085/#review157008
---
Ship it!
Ship It!
- Alexander Rojas
On Nov. 25, 2016, 5:53
d23f551c2caa454da0c0f6cb7d77a8c2bd75a474
Diff: https://reviews.apache.org/r/53541/diff/
Testing
---
make check
Thanks,
Alexander Rojas
e up the
> > authorization check for those Calls as a separate patch, so we can see how
> > these fields will be filled in?
>
> Alexander Rojas wrote:
> Will fix when everything is running properly.
So as bespoken, I won't break this patch, however there's a follow u
301 - 400 of 1120 matches
Mail list logo
