> On Feb. 24, 2017, 3:07 a.m., Vinod Kone wrote: > > src/slave/http.cpp, line 836 > > <https://reviews.apache.org/r/56812/diff/2/?file=1641768#file1641768line836> > > > > not related to your change, but I'm curious why this method uses the > > object approver whereas the `Slave::Http::flags()` doesn't? cc @arojas > > Greg Mann wrote: > I'm guessing it's just for historical reasons; the old handler probably > was not updated when the newer one was added?
As Greg says, it is mostly historical reasons. Once the objectApprover was introduced, it is consider a better option, but we haven't consolidate an effort to move everthing towards the object approver. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56812/#review166636 ----------------------------------------------------------- On Feb. 28, 2017, 7:37 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56812/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 7:37 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7003 > https://issues.apache.org/jira/browse/MESOS-7003 > > > Repository: mesos > > > Description > ------- > > This patch updates the HTTP endpoint handlers in the > agent process to accept the `Principal` type instead > of an `Option<string>& principal`. > > > Diffs > ----- > > src/slave/http.cpp 94731ec883c309cefb811694dc4e39de12d1ac59 > src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2 > src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a > > Diff: https://reviews.apache.org/r/56812/diff/ > > > Testing > ------- > > Testing details can be found at the end of this review chain. > > > Thanks, > > Greg Mann > >
