Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-02-20 Thread Anindya Sinha
te. - Anindya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/#review166111 --- On Feb. 8, 2017, 3:54 a.m., Anin

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-02-20 Thread Anindya Sinha
/slave_authorization_tests.cpp 61c44460eb79931dd77c5100eb33a31a182c1710 Diff: https://reviews.apache.org/r/55888/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-02-20 Thread Anindya Sinha
and the current user. - Anindya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55888/#review166035 --- On Feb. 8, 201

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-02-20 Thread Anindya Sinha
https://reviews.apache.org/r/55887/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-02-20 Thread Anindya Sinha
K_FAILED` on a failure. So, I left this status update that the agent generates as `TASK_FAILED`. - Anindya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/#review165999 ------

Review Request 56533: Fix the shell script to not use deprecated [..] in increment operation.

2017-02-09 Thread Anindya Sinha
/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-02-07 Thread Anindya Sinha
on agents. Diffs (updated) - src/tests/slave_tests.cpp 7f357a653335b559b5c78d4618926715dc4a63c7 Diff: https://reviews.apache.org/r/55888/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-02-07 Thread Anindya Sinha
/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 49571: Added a benchmark test for allocations.

2017-02-06 Thread Anindya Sinha
allocate() took 1.517221secs to make 1000 offers round 150 allocate() took 1.526446secs to make 1000 offers round 199 allocate() took 1.538005secs to make 1000 offers Thanks, Anindya Sinha

Re: Review Request 55359: Consolidate update of allocations in `updateAllocation()`.

2017-02-06 Thread Anindya Sinha
--- Tests passed. Thanks, Anindya Sinha

Re: Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-02-06 Thread Anindya Sinha
https://reviews.apache.org/r/55887/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-02-06 Thread Anindya Sinha
7f357a653335b559b5c78d4618926715dc4a63c7 Diff: https://reviews.apache.org/r/55888/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 49571: Added a benchmark test for allocations.

2017-02-03 Thread Anindya Sinha
allocate() took 1.517221secs to make 1000 offers round 150 allocate() took 1.526446secs to make 1000 offers round 199 allocate() took 1.538005secs to make 1000 offers Thanks, Anindya Sinha

Re: Review Request 55359: Consolidate update of allocations in `updateAllocation()`.

2017-02-03 Thread Anindya Sinha
allocations in the allocator and sorters can be consolidated together. Diffs (updated) - src/master/allocator/mesos/hierarchical.cpp 5f540569043df9d2bb75416c8c36bb4dd7bd68a1 Diff: https://reviews.apache.org/r/55359/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

2017-02-03 Thread Anindya Sinha
/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a Diff: https://reviews.apache.org/r/45962/diff/ Testing --- New test framework for shared resources added. Tests successful. Thanks, Anindya Sinha

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

2017-02-03 Thread Anindya Sinha
tests/persistent_volume_tests.cpp 468a85b4a6ce09592341afd07ce12a03f5fc4f73 Diff: https://reviews.apache.org/r/53096/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 55359: Consolidate update of allocations in `updateAllocation()`.

2017-02-01 Thread Anindya Sinha
/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

2017-02-01 Thread Anindya Sinha
) - src/examples/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a Diff: https://reviews.apache.org/r/45962/diff/ Testing --- New test framework for shared resources added. Tests successful. Thanks, Anindya Sinha

Re: Review Request 49571: Added a benchmark test for allocations.

2017-02-01 Thread Anindya Sinha
1.520157secs to make 1000 offers round 100 allocate() took 1.517221secs to make 1000 offers round 150 allocate() took 1.526446secs to make 1000 offers round 199 allocate() took 1.538005secs to make 1000 offers Thanks, Anindya Sinha

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

2017-02-01 Thread Anindya Sinha
l.cpp ffa07087f9ed8d28b99cc4cde7c739cfd7edb1e1 src/tests/persistent_volume_tests.cpp 468a85b4a6ce09592341afd07ce12a03f5fc4f73 Diff: https://reviews.apache.org/r/53096/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 49571: Added a benchmark test for allocations.

2017-01-30 Thread Anindya Sinha
allocate() took 1.517221secs to make 1000 offers round 150 allocate() took 1.526446secs to make 1000 offers round 199 allocate() took 1.538005secs to make 1000 offers Thanks, Anindya Sinha

Re: Review Request 55359: Consolidate update of allocations in `updateAllocation()`.

2017-01-30 Thread Anindya Sinha
edFrameworkAllocation.createStrippedScalarQuantity()); > > > > LOG(INFO) << "Updated allocation of framework " << frameworkId > > << " on agent " << slaveId > > <<

Re: Review Request 55359: Consolidate update of allocations in `updateAllocation()`.

2017-01-30 Thread Anindya Sinha
passed. Thanks, Anindya Sinha

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

2017-01-30 Thread Anindya Sinha
tests/persistent_volume_tests.cpp 468a85b4a6ce09592341afd07ce12a03f5fc4f73 Diff: https://reviews.apache.org/r/53096/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

2017-01-30 Thread Anindya Sinha
/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a Diff: https://reviews.apache.org/r/45962/diff/ Testing --- New test framework for shared resources added. Tests successful. Thanks, Anindya Sinha

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

2017-01-26 Thread Anindya Sinha
/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a Diff: https://reviews.apache.org/r/45962/diff/ Testing --- New test framework for shared resources added. Tests successful. Thanks, Anindya Sinha

Re: Review Request 49571: Added a benchmark test for allocations.

2017-01-26 Thread Anindya Sinha
allocate() took 1.517221secs to make 1000 offers round 150 allocate() took 1.526446secs to make 1000 offers round 199 allocate() took 1.538005secs to make 1000 offers Thanks, Anindya Sinha

Re: Review Request 55359: Consolidate update of allocations in `updateAllocation()`.

2017-01-26 Thread Anindya Sinha
, Anindya Sinha

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

2017-01-26 Thread Anindya Sinha
tests/persistent_volume_tests.cpp 468a85b4a6ce09592341afd07ce12a03f5fc4f73 Diff: https://reviews.apache.org/r/53096/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Review Request 55887: Check task user before allowing a task to be launched on the agent.

2017-01-24 Thread Anindya Sinha
r the authorization error. Diffs - src/slave/slave.hpp 0dadbe50be15f89b791da55fa10f1b434693ee0f src/slave/slave.cpp 0548b04073c0ba4adfc4433d75fd18c2ba79d891 Diff: https://reviews.apache.org/r/55887/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Review Request 55888: Test to ensure non-authorized users cannot launch tasks on agents.

2017-01-24 Thread Anindya Sinha
--- All tests passed. Thanks, Anindya Sinha

Re: Review Request 55446: Added common validation for IDs.

2017-01-13 Thread Anindya Sinha
org/r/55446/#comment232848> Should we consider disallowing spaces as well? `iscntrl` includes tabs but do we want spaces to be included in the path? - Anindya Sinha On Jan. 12, 2017, 9:46 a.m., Jiang Yan Xu wrote: > > ---

Review Request 55359: Consolidate update of allocations in `updateAllocation()`.

2017-01-09 Thread Anindya Sinha
can be consolidated together. Diffs - src/master/allocator/mesos/hierarchical.cpp 91b1ec43940a788459f045ca4a4b82d4e8373bca Diff: https://reviews.apache.org/r/55359/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

2017-01-09 Thread Anindya Sinha
/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a Diff: https://reviews.apache.org/r/45962/diff/ Testing --- New test framework for shared resources added. Tests successful. Thanks, Anindya Sinha

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

2017-01-09 Thread Anindya Sinha
tests/persistent_volume_tests.cpp 8198b6b5ad323d17835ba067c7ff3d34ef948125 Diff: https://reviews.apache.org/r/53096/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 49571: Added a benchmark test for allocations.

2017-01-09 Thread Anindya Sinha
allocate() took 1.517221secs to make 1000 offers round 150 allocate() took 1.526446secs to make 1000 offers round 199 allocate() took 1.538005secs to make 1000 offers Thanks, Anindya Sinha

Re: Review Request 52071: Updated docs to handle resources with no size in agent flags.

2016-12-19 Thread Anindya Sinha
://reviews.apache.org/r/52071/diff/ Testing --- Documentation change only. All tests passed. Thanks, Anindya Sinha

Re: Review Request 51880: Added unit tests to determine disk size for MOUNT or PATH disks.

2016-12-19 Thread Anindya Sinha
, Anindya Sinha

Re: Review Request 51880: Added unit tests to determine disk size for MOUNT or PATH disks.

2016-12-19 Thread Anindya Sinha
ated into 2 separate classes, viz. `ResourcesContainerizerTest` and `DiskResourcesContainerizerTest`, and moved setting up of mounts in `SetUp()` and unmounting in `TearDown()`. - Anindya --- This is an automatically gen

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

2016-12-19 Thread Anindya Sinha
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review159590 --- On Dec. 12, 2016, 10:35 p.m., Anindya Sinha wrote: > >

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

2016-12-19 Thread Anindya Sinha
9d45bb496c4cf378af429b5aa970bf81450e482a Diff: https://reviews.apache.org/r/45962/diff/ Testing --- New test framework for shared resources added. Tests successful. Thanks, Anindya Sinha

Re: Review Request 49571: Added a benchmark test for allocations.

2016-12-19 Thread Anindya Sinha
make 1000 offers round 150 allocate() took 1.526446secs to make 1000 offers round 199 allocate() took 1.538005secs to make 1000 offers Thanks, Anindya Sinha

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

2016-12-19 Thread Anindya Sinha
73bca src/tests/persistent_volume_tests.cpp b7c313781f3dd9ab4fd68ce23ccc044d50b734d8 Diff: https://reviews.apache.org/r/53096/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

2016-12-19 Thread Anindya Sinha
> ``` Not all sorters, only the role and quota sorters. - Anindya ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53096/#review159578 -

Re: Review Request 52071: Updated docs to handle resources with no size in agent flags.

2016-12-18 Thread Anindya Sinha
://reviews.apache.org/r/52071/diff/ Testing --- Documentation change only. All tests passed. Thanks, Anindya Sinha

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-12-18 Thread Anindya Sinha
, Anindya Sinha

Re: Review Request 51880: Added unit tests to determine disk size for MOUNT or PATH disks.

2016-12-18 Thread Anindya Sinha
/tests/containerizer/common_containerizer_tests.cpp PRE-CREATION src/tests/resources_tests.cpp 8dfb1be35d9f9c6ff69139d055c6b3d3ec475e68 Diff: https://reviews.apache.org/r/51880/diff/ Testing --- All tests including the additional tests in this RR passed. Thanks, Anindya Sinha

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-12-18 Thread Anindya Sinha
add a `Resource` object (of type `gpus`) with a size of `available` retrieved from `nvml::deviceGetCount()`. But if there are additional `gpus` resources (with or without value), then we will fail here eventually: `if (resources.gpus().get() > available.get())` I think a better approach mi

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-12-18 Thread Anindya Sinha
://reviews.apache.org/r/52002/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

2016-12-12 Thread Anindya Sinha
/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a Diff: https://reviews.apache.org/r/45962/diff/ Testing --- New test framework for shared resources added. Tests successful. Thanks, Anindya Sinha

Re: Review Request 49571: Added a benchmark test for allocations.

2016-12-12 Thread Anindya Sinha
allocate() took 1.517221secs to make 1000 offers round 150 allocate() took 1.526446secs to make 1000 offers round 199 allocate() took 1.538005secs to make 1000 offers Thanks, Anindya Sinha

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

2016-12-12 Thread Anindya Sinha
tests/persistent_volume_tests.cpp b7c313781f3dd9ab4fd68ce23ccc044d50b734d8 Diff: https://reviews.apache.org/r/53096/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 49571: Added a benchmark test for allocations.

2016-12-12 Thread Anindya Sinha
1.520157secs to make 1000 offers round 100 allocate() took 1.517221secs to make 1000 offers round 150 allocate() took 1.526446secs to make 1000 offers round 199 allocate() took 1.538005secs to make 1000 offers Thanks, Anindya Sinha

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

2016-12-12 Thread Anindya Sinha
/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a Diff: https://reviews.apache.org/r/45962/diff/ Testing --- New test framework for shared resources added. Tests successful. Thanks, Anindya Sinha

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

2016-12-12 Thread Anindya Sinha
src/tests/persistent_volume_tests.cpp b7c313781f3dd9ab4fd68ce23ccc044d50b734d8 Diff: https://reviews.apache.org/r/53096/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 52071: Updated docs to handle resources with no size in agent flags.

2016-12-09 Thread Anindya Sinha
2caa44927d45c0ab13f8160794b50f4fde3711aa Diff: https://reviews.apache.org/r/52071/diff/ Testing --- Documentation change only. All tests passed. Thanks, Anindya Sinha

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-12-09 Thread Anindya Sinha
00f2f453f5eb4ddc4b0b9b89be2bd89f05d9 Diff: https://reviews.apache.org/r/51879/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-12-09 Thread Anindya Sinha
://reviews.apache.org/r/52002/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-12-09 Thread Anindya Sinha
not autodetect `gpus` resources. - Anindya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/#review157057 --- On Dec. 10, 2016

Re: Review Request 51880: Added unit tests to determine disk size for MOUNT or PATH disks.

2016-12-09 Thread Anindya Sinha
: https://reviews.apache.org/r/51880/diff/ Testing --- All tests including the additional tests in this RR passed. Thanks, Anindya Sinha

Re: Review Request 49571: Added a benchmark test for allocations.

2016-12-02 Thread Anindya Sinha
allocate() took 1.517221secs to make 1000 offers round 150 allocate() took 1.526446secs to make 1000 offers round 199 allocate() took 1.538005secs to make 1000 offers Thanks, Anindya Sinha

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

2016-12-02 Thread Anindya Sinha
/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a Diff: https://reviews.apache.org/r/45962/diff/ Testing --- New test framework for shared resources added. Tests successful. Thanks, Anindya Sinha

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

2016-12-02 Thread Anindya Sinha
53096/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

2016-12-01 Thread Anindya Sinha
9d45bb496c4cf378af429b5aa970bf81450e482a Diff: https://reviews.apache.org/r/45962/diff/ Testing --- New test framework for shared resources added. Tests successful. Thanks, Anindya Sinha

Re: Review Request 49571: Added a benchmark test for allocations.

2016-12-01 Thread Anindya Sinha
make 1000 offers round 150 allocate() took 1.526446secs to make 1000 offers round 199 allocate() took 1.538005secs to make 1000 offers Thanks, Anindya Sinha

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

2016-12-01 Thread Anindya Sinha
eviews.apache.org/r/45962/#review156293 --- On Nov. 29, 2016, 12:25 a.m., Anindya Sinha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45962/ > ---

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

2016-12-01 Thread Anindya Sinha
olumeScheduler::resourceOffers()` [where the state machine is initiated and managed]. - Anindya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review157642 -------

Re: Review Request 49571: Added a benchmark test for allocations.

2016-12-01 Thread Anindya Sinha
allocate() took 1.517221secs to make 1000 offers round 150 allocate() took 1.526446secs to make 1000 offers round 199 allocate() took 1.538005secs to make 1000 offers Thanks, Anindya Sinha

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

2016-12-01 Thread Anindya Sinha
/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a Diff: https://reviews.apache.org/r/45962/diff/ Testing --- New test framework for shared resources added. Tests successful. Thanks, Anindya Sinha

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

2016-12-01 Thread Anindya Sinha
53096/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 46228: Create persistent volume with a supplied user.

2016-12-01 Thread Anindya Sinha
the > > gain in security is worth the restriction? > > Anindya Sinha wrote: > The sticky bit ensures that the tasks only deletes files owned by it. > This is particularly true for shared volumes where multiple containers have > access to the same volume simultaneously and we

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

2016-11-28 Thread Anindya Sinha
oleSorter->add(slaveId, updatedTotal.get().nonRevocable()); ``` - Anindya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53096/#review156326 ---

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

2016-11-28 Thread Anindya Sinha
/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a Diff: https://reviews.apache.org/r/45962/diff/ Testing --- New test framework for shared resources added. Tests successful. Thanks, Anindya Sinha

Re: Review Request 49571: Added a benchmark test for allocations.

2016-11-28 Thread Anindya Sinha
allocate() took 1.517221secs to make 1000 offers round 150 allocate() took 1.526446secs to make 1000 offers round 199 allocate() took 1.538005secs to make 1000 offers Thanks, Anindya Sinha

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

2016-11-28 Thread Anindya Sinha
https://reviews.apache.org/r/53096/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

2016-11-21 Thread Anindya Sinha
9d45bb496c4cf378af429b5aa970bf81450e482a Diff: https://reviews.apache.org/r/45962/diff/ Testing --- New test framework for shared resources added. Tests successful. Thanks, Anindya Sinha

Re: Review Request 52002: Added helper methods to determine types of disk resources.

2016-11-20 Thread Anindya Sinha
Diff: https://reviews.apache.org/r/52002/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 46230: Updated docs to reflect user in persistent volumes.

2016-11-20 Thread Anindya Sinha
410993fb69eb73db6ad17ef361f9b72cba5dc84d docs/shared-resources.md 1b490e253447a9e263cb5a6bda10f360ea7138ce Diff: https://reviews.apache.org/r/46230/diff/ Testing --- Documentation change only. All tests passed. Thanks, Anindya Sinha

Re: Review Request 46228: Create persistent volume with a supplied user.

2016-11-20 Thread Anindya Sinha
ucceed to ensure we do not leak persistent volumes. - Anindya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46228/#review155952 ---

Re: Review Request 46229: Add unit tests for adding a user for persistent volumes.

2016-11-20 Thread Anindya Sinha
passed (including the newly added tests). Thanks, Anindya Sinha

Re: Review Request 46228: Create persistent volume with a supplied user.

2016-11-20 Thread Anindya Sinha
e.cpp 521f08d59cd78f9089d58cd3294f0ee4a099cd7f src/v1/resources.cpp 46cc00f2f453f5eb4ddc4b0b9b89be2bd89f05d9 Diff: https://reviews.apache.org/r/46228/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 52980: Updated os::mkdir() to take the mode as an input.

2016-11-20 Thread Anindya Sinha
/include/stout/os/mkdir.hpp fe86864c8b480993c8f052f39b2fd3ece23798da Diff: https://reviews.apache.org/r/52980/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 46227: Added an user to indicate owner of persistent volume.

2016-11-20 Thread Anindya Sinha
--- All tests passed. Thanks, Anindya Sinha

Re: Review Request 52295: Added additional unit tests for shared resources.

2016-11-18 Thread Anindya Sinha
--- All tests passed. Thanks, Anindya Sinha

Re: Review Request 52295: Added additional unit tests for shared resources.

2016-11-18 Thread Anindya Sinha
/ Testing --- All tests passed. Thanks, Anindya Sinha

Re: Review Request 49571: Added a benchmark test for allocations.

2016-11-17 Thread Anindya Sinha
allocate() took 1.517221secs to make 1000 offers round 150 allocate() took 1.526446secs to make 1000 offers round 199 allocate() took 1.538005secs to make 1000 offers Thanks, Anindya Sinha

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

2016-11-17 Thread Anindya Sinha
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45962/#review156082 --- On Nov. 18, 2016, 5:13 a.m., Anindya Sinha wrote: > > -

Re: Review Request 45962: Updated a persistent volume test framework to include shared volumes.

2016-11-17 Thread Anindya Sinha
/persistent_volume_framework.cpp 9d45bb496c4cf378af429b5aa970bf81450e482a Diff: https://reviews.apache.org/r/45962/diff/ Testing --- New test framework for shared resources added. Tests successful. Thanks, Anindya Sinha

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

2016-11-17 Thread Anindya Sinha
191b8 Diff: https://reviews.apache.org/r/53096/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 53096: Fix handling in shared count in total resources in the sorter.

2016-11-17 Thread Anindya Sinha
191b8 Diff: https://reviews.apache.org/r/53096/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Review Request 53842: Add role specific metrics for sorting runs.

2016-11-16 Thread Anindya Sinha
753f90acc52ada84883cbbe3350e61d1e1eaff48 src/master/allocator/mesos/metrics.cpp a36d21c297160bc1c9f43a22743fd5448d7ae5ac src/tests/hierarchical_allocator_tests.cpp edd5cea8996d7c616cf9428f0f1c05d70c37c307 Diff: https://reviews.apache.org/r/53842/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Review Request 53841: Added metrics for sorting of the sorters in the allocator.

2016-11-16 Thread Anindya Sinha
/r/53841/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Review Request 53840: Added a metric in the allocator to track previous allocation cycle.

2016-11-16 Thread Anindya Sinha
etrics.cpp a36d21c297160bc1c9f43a22743fd5448d7ae5ac src/tests/hierarchical_allocator_tests.cpp edd5cea8996d7c616cf9428f0f1c05d70c37c307 Diff: https://reviews.apache.org/r/53840/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Review Request 53839: Added a metric in the master to track sending of previous offer.

2016-11-16 Thread Anindya Sinha
src/tests/master_tests.cpp c8cd89228eb4e55c9a9655f9de39cb070e14520c Diff: https://reviews.apache.org/r/53839/diff/ Testing --- Tests passed. Thanks, Anindya Sinha

Re: Review Request 52980: Updated os::mkdir() to take the mode as an input.

2016-11-15 Thread Anindya Sinha
ar: I mean that permissions _on > Windows_ is a subtle issue in Mesos. My worry is rooted in the fact that this > API also has to support Windows. > > Anindya Sinha wrote: > So, er either extend `mkdir()` to include a `mode` (which as you > indicated would need a change i

Re: Review Request 52295: Added additional unit tests for shared resources.

2016-11-11 Thread Anindya Sinha
t as is. - Anindya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52295/#review152420 --- On Sept. 27, 2016, 12:39 a.m., Anindya Sinha w

Re: Review Request 52295: Added additional unit tests for shared resources.

2016-11-11 Thread Anindya Sinha
, Anindya Sinha

Review Request 53666: Refactor cgroups cleanup to allow cleanup to continue on an error.

2016-11-11 Thread Anindya Sinha
Diff: https://reviews.apache.org/r/53666/diff/ Testing --- All tests passed. Thanks, Anindya Sinha

Review Request 53636: Fix test ROOT_WriteAccessSharedPersistentVolumeReadOnlyMode.

2016-11-09 Thread Anindya Sinha
/ Testing --- All tests passed including the failed test. Thanks, Anindya Sinha

Re: Review Request 49571: Added a benchmark test for allocations.

2016-11-07 Thread Anindya Sinha
allocate() took 1.517221secs to make 1000 offers round 150 allocate() took 1.526446secs to make 1000 offers round 199 allocate() took 1.538005secs to make 1000 offers Thanks, Anindya Sinha

<    1   2   3   4   5   6   7   8   >