-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49571/
-----------------------------------------------------------
(Updated Jan. 9, 2017, 10:37 p.m.)
Review request for mesos and Jiang Yan Xu.
Changes
-------
Rebase.
Bugs: MESOS-5771
https://issues.apache.org/jira/browse/MESOS-5771
Repository: mesos
Description
-------
Allocations test has the following resource configurations:
(1) REGULAR: Offers from every slave have regular resources.
(2) SHARED: Offers from every slave include a shared resource.
(3) REGULAR: Offers from every alternate slave contain only regular
resources; and offers from every other alternate slave contains
a shared resource.
This test is parameterized based on number of agents, number of
frameworks and resource configuration.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp
1edd0ecc8a93cd41532e1cf3641f67c780ab23a5
src/tests/resources_utils.hpp 18dcca7f171102df8fe88f10785f70c5d1cf5b32
src/tests/resources_utils.cpp be1feb97be552af582dbba3a54fa5fa0714b3eb2
Diff: https://reviews.apache.org/r/49571/diff/
Testing
-------
All tests passed.
Allocations benchmark test results
==================================
Support of shared resources has a small impact (roughly 10%) on runtime
performance in allocations as compared to HEAD (without shared resources).
Also, there is no visible impact in performance when shared resources are added
in the tests.
Following is a snapshot with 1000 agents and 200 frameworks.
With the patch (and no shared resources)
----------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6907us
Added 1000 agents in 2.057098secs
round 0 allocate() took 1.689164secs to make 1000 offers
round 50 allocate() took 1.672373secs to make 1000 offers
round 100 allocate() took 1.680571secs to make 1000 offers
round 150 allocate() took 1.674683secs to make 1000 offers
round 199 allocate() took 1.671525secs to make 1000 offers
With the patch (and shared resources on all agents)
---------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/10
Using 1000 agents and 200 frameworks with resource type 1
Added 200 frameworks in 6888us
Added 1000 agents in 2.096218secs
round 0 allocate() took 1.704491secs to make 1000 offers
round 50 allocate() took 1.718623secs to make 1000 offers
round 100 allocate() took 1.716224secs to make 1000 offers
round 150 allocate() took 1.707343secs to make 1000 offers
round 199 allocate() took 1.727467secs to make 1000 offers
With the patch (and shared resources on alternate agents)
---------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/11
Using 1000 agents and 200 frameworks with resource type 2
Added 200 frameworks in 7304us
Added 1000 agents in 2.071009secs
round 0 allocate() took 1.689045secs to make 1000 offers
round 50 allocate() took 1.691524secs to make 1000 offers
round 100 allocate() took 1.688873secs to make 1000 offers
round 150 allocate() took 1.688713secs to make 1000 offers
round 199 allocate() took 1.691223secs to make 1000 offers
Based on HEAD, with all regular resources (no shared resources in HEAD
supported)
---------------------------------------------------------------------------------
[ RUN ] AllResources/HierarchicalAllocations_BENCHMARK_Test.Allocations/9
Using 1000 agents and 200 frameworks with resource type 0
Added 200 frameworks in 6801us
Added 1000 agents in 1.721447secs
round 0 allocate() took 1.502953secs to make 1000 offers
round 50 allocate() took 1.520157secs to make 1000 offers
round 100 allocate() took 1.517221secs to make 1000 offers
round 150 allocate() took 1.526446secs to make 1000 offers
round 199 allocate() took 1.538005secs to make 1000 offers
Thanks,
Anindya Sinha
