d to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> GET /master/redirect_foo HTTP/1.1
> Host: 127.0.0.1:5050
> User-Agent: curl/7.43.0
> Accept: */*
>
< HTTP/1.1 404 Not Found
< Date: Wed, 28 Sep 2016 17:49:54 GMT
< Content-Length: 0
<
* Connection #0 to host 127.0.0.1 left intact
```
It is worth noting that in this PR /master/redirect/ and /redirect/ return
404, not 307. This behavior is consistent with master.
Thanks,
Charles Allen
ot;/redirect/") ||
> > + strings::startsWith(request.url.path,
> > + "/" + master->self().id +
> > "/redirect/")) {
> > +// Stop redirection here to avoid fall into an infinite
> >
uest to the
> > master.
> > ```
Fixed
- Charles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52105/#review150313
-------
.
* Connected to 127.0.0.1 (127.0.0.1) port 5050 (#0)
> GET /master/redirect_foo HTTP/1.1
> Host: 127.0.0.1:5050
> User-Agent: curl/7.43.0
> Accept: */*
>
< HTTP/1.1 404 Not Found
< Date: Wed, 28 Sep 2016 17:49:54 GMT
< Content-Length: 0
<
* Connection #0 to host 127.0.0.1 left intact
```
It is worth noting that in this PR /master/redirect/ and /redirect/ return
404, not 307. This behavior is consistent with master.
Thanks,
Charles Allen
t; Date: Wed, 28 Sep 2016 17:49:54 GMT
< Content-Length: 0
<
* Connection #0 to host 127.0.0.1 left intact
```
It is worth noting that in this PR /master/redirect/ and /redirect/ return
404, not 307. This behavior is consistent with master.
Thanks,
Charles Allen
re to avoid fall into an infinite
> > redirection loop.
> > +return NotFound();
> >} else {
> > ```
> >
> > in the previous comment.
Sure, I can do that.
- Charles
--------
> > would get unexpected result. So how about just return 404 which consistent
> > with `/redirect/`
> >
> > ```
> > // When current master is not the leader, redirect to the leading
> > master.
> > if (!master->elected()) {
> >
.1
> Host: 127.0.0.1:5050
> User-Agent: curl/7.43.0
> Accept: */*
>
< HTTP/1.1 404 Not Found
< Date: Fri, 23 Sep 2016 17:30:55 GMT
< Content-Length: 0
<
* Connection #0 to host 127.0.0.1 left intact
```
It is worth noting that in this PR /master/redirect/ and /redirect/ return
404, not 307. This behavior is consistent with master.
Thanks,
Charles Allen
.org/r/52105/#review150185
-------
On Sept. 22, 2016, 8:47 p.m., Charles Allen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apach
ks`. Could you elaborate the user
> > cases about this? Because we have handled the endpoint redirection
> > automatically internal. For example, when you request
> > `http://NON_LEADING_MASTER:5050/master/frameworks`, mesos master would
> > redirect to `http://LEADING
050 (#0)
> GET /redirectNOTFOUND/foo/bar HTTP/1.1
> Host: 127.0.0.1:5050
> User-Agent: curl/7.43.0
> Accept: */*
>
< HTTP/1.1 404 Not Found
< Date: Thu, 22 Sep 2016 20:35:47 GMT
< Content-Length: 0
<
* Connection #0 to host 127.0.0.1 left intact
```
It is worth noting that in this PR /master/redirect/ and /redirect/ return
404, not 307. This behavior is consistent with master.
Thanks,
Charles Allen
l/7.43.0
> Accept: */*
>
< HTTP/1.1 307 Temporary Redirect
< Date: Tue, 20 Sep 2016 23:13:43 GMT
< Location: //10.17.97.185:5050/test
< Content-Length: 0
<
* Connection #0 to host 127.0.0.1 left intact
```
It is worth noting that in this PR /master/redirect/ and /redirect/ return
404, not 307. This behavior is consistent with master.
Thanks,
Charles Allen
ks`. Could you elaborate the user
> > cases about this? Because we have handled the endpoint redirection
> > automatically internal. For example, when you request
> > `http://NON_LEADING_MASTER:5050/master/frameworks`, mesos master would
> > redirect to `http://LEADING
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52105/#review149824
-----------
On Sept. 21, 2016, 3:03 a.m., Charles Allen wrote:
>
> -
n: //10.17.97.185:5050/test
< Content-Length: 0
<
* Connection #0 to host 127.0.0.1 left intact
```
It is worth noting that in this PR /master/redirect/ and /redirect/ return
404, not 307. This behavior is consistent with master.
Thanks,
Charles Allen
to app.js by breakpointing in the javascript using chrome
developer tools, and modifying the javascript in the developer tools.
This caused TB scale to display properly.
Thanks,
Charles Allen
Allen to contributors
Diffs
-
docs/contributors.yaml 04451e3e040aeb155feee74c789677085e6544f5
Diff: https://reviews.apache.org/r/49483/diff/
Testing
---
Thanks,
Charles Allen
at 111.1 KB/sec)
```
- Charles
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49422/#review140198
---
On June 30, 2016, 3:59 a.m., Char
cluster. Works fine.
Thanks,
Charles Allen
19 matches
Mail list logo
