esn't worth the time to fix).
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71414/#review217508
---
On Aug. 30, 2019, 12:48
6d632606f411d3ca99d3573a57c9f68b02ba8072
src/tests/storage_local_resource_provider_tests.cpp
69b59d48ceefebbb7accefe411c54ac5cecff1c3
Diff: https://reviews.apache.org/r/71414/diff/1/
Testing
---
make check
The test would fail without the fix.
Thanks,
Chun-Hung Hsiao
This should be removed. L739 resumed the SUM.
- Chun-Hung Hsiao
On Aug. 19, 2019, 11:58 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
> On Aug. 9, 2019, 7:41 a.m., Chun-Hung Hsiao wrote:
> > src/resource_provider/storage/provider.cpp
> > Line 752 (original), 811 (patched)
> > <https://reviews.apache.org/r/71151/diff/4/?file=2159963#file2159963line813>
> >
> > As commented in the
e feel free to drop this. I already gave you another
ship-it :)
- Chun-Hung Hsiao
On Aug. 19, 2019, 11:58 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71150/#review217314
---
Ship it!
Ship It!
- Chun-Hung Hsiao
On Aug. 19, 2019, 11:58
ource_provider_tests.cpp
Lines 6881 (patched)
<https://reviews.apache.org/r/71151/#comment304413>
Ditto.
- Chun-Hung Hsiao
On Aug. 6, 2019, 2:27 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically gen
)
.onFailed(std::bind(err, resource, lambda::_1))
.onDiscarded(std::bind(err, resource, "future discarded"));
```
- Chun-Hung Hsiao
On July 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
>
> --
rovider/storage/provider.cpp
Lines 1869-1886 (original), 1933-1950 (patched)
<https://reviews.apache.org/r/71151/#comment304274>
With periodic reconciliation, this won't be necessary. Removing this would
also reduce a source of reconciliation, so the reconciliation can only happen
in
/71150/#comment304183>
Remove this debug log.
- Chun-Hung Hsiao
On July 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
I'm fine with either approach so please feel free to drop this.
- Chun-Hung Hsiao
On June 11, 2019, 12:38 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70831/#review217025
---
Ship it!
Ship It!
- Chun-Hung Hsiao
On June 11, 2019, 12:38
/storage_local_resource_provider_tests.cpp
Line 330 (original), 330 (patched)
<https://reviews.apache.org/r/71148/#comment304249>
Fits in one line.
- Chun-Hung Hsiao
On July 29, 2019, 8:56 a.m., Benjamin Bannier wrote:
>
> ---
> This is an automati
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71147/#review217023
---
Ship it!
Ship It!
- Chun-Hung Hsiao
On July 29, 2019, 8:56
src/tests/resource_provider_manager_tests.cpp
Lines 1436 (patched)
<https://reviews.apache.org/r/70728/#comment304220>
Ditto.
- Chun-Hung Hsiao
On July 27, 2019, 7:04 p.m., Benjamin Bannier wrote:
>
> ---
> This is an au
to come up with a good name when
I worked on this ticket ;) Thanks for coming up with this name!
- Chun-Hung Hsiao
On July 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
(original), 846 (patched)
<https://reviews.apache.org/r/71148/#comment304121>
How about using zero here, as described in `mesos.proto`?
And since most tests require no reconciliation, maybe making zero the
default in `setupResourceProviderConfig`?
- Chun-Hung Hsiao
On July 23
tests
that checks for reconciliations.
- Chun-Hung Hsiao
On July 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
manager.
So maybe "Since the local resource provider gets subscribed after the agent
is registered?"
Ditto below.
- Chun-Hung Hsiao
On July 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
>
> ---
> This i
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71145/#review216874
---
Ship it!
Ship It!
- Chun-Hung Hsiao
On July 23, 2019, 8:18
/resource_provider/constants.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/71144/diff/2/
Changes: https://reviews.apache.org/r/71144/diff/1-2/
Testing
---
Thanks,
Chun-Hung Hsiao
: https://reviews.apache.org/r/71143/diff/1-2/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
/
Testing
---
Thanks,
Chun-Hung Hsiao
/v1_volume_manager_process.hpp
30788c3593d4b4bd6271705a1188f73836bc7a85
src/tests/storage_local_resource_provider_tests.cpp
38233053452259571743317326a6efc74d97bd29
Diff: https://reviews.apache.org/r/71143/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
ngOffers`.
Also, let's avoid accessing `process->info` directly in the remaining of
this test.
src/tests/slave_tests.cpp
Line 11769 (original), 11775 (patched)
<https://reviews.apache.org/r/70728/#comment30
/diff/1/
Testing
---
Ran the tests under stress 200 times.
Thanks,
Chun-Hung Hsiao
4d7c37cf8814e45432b3fe15173f5343676a372b
src/tests/api_tests.cpp 37d0cb11ddb24b32f1e83feefe168f2aa2eb659c
Diff: https://reviews.apache.org/r/70788/diff/2/
Changes: https://reviews.apache.org/r/70788/diff/1-2/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
with the unit test in r/70764. The unit test will fail at the
5th poll without the fix and will pass with the fix.
Thanks,
Chun-Hung Hsiao
37d0cb11ddb24b32f1e83feefe168f2aa2eb659c
Diff: https://reviews.apache.org/r/70788/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
der ID).
- Chun-Hung Hsiao
On May 27, 2019, 4:32 p.m., Benjamin Bannier wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
215f7f92b5c2a0e60555134ce9887e8a187e3b1d
Diff: https://reviews.apache.org/r/70765/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
215f7f92b5c2a0e60555134ce9887e8a187e3b1d
Diff: https://reviews.apache.org/r/70766/diff/1/
Testing
---
make check
Manually tested with the unit test in r/70764. The unit test will fail at the
5th poll without the fix and will pass with the fix.
Thanks,
Chun-Hung Hsiao
che.org/r/70740/#comment302288>
IIRC Windows uses some v2s2 spec?
https://github.com/apache/mesos/blob/fa410f2fb8efb988590f4da2d4cfffbb2ce70637/src/uri/fetchers/docker.cpp#L974
- Chun-Hung Hsiao
On May 28, 2019, 11:11 p.m., Jos
37d0cb11ddb24b32f1e83feefe168f2aa2eb659c
Diff: https://reviews.apache.org/r/70651/diff/3/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
2771f4c045c877b7d8aa5db042810232c0e40ba0
src/master/master.cpp 4d7c37cf8814e45432b3fe15173f5343676a372b
Diff: https://reviews.apache.org/r/70702/diff/1/
Testing
---
make check
Ran the test updated in r/70651 for 500 times under stress.
Thanks,
Chun-Hung Hsiao
4d7c37cf8814e45432b3fe15173f5343676a372b
src/tests/api_tests.cpp 37d0cb11ddb24b32f1e83feefe168f2aa2eb659c
Diff: https://reviews.apache.org/r/70651/diff/2/
Changes: https://reviews.apache.org/r/70651/diff/1-2/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
> On May 17, 2019, 10:16 a.m., Greg Mann wrote:
> > src/tests/api_tests.cpp
> > Lines 2774 (patched)
> > <https://reviews.apache.org/r/70651/diff/1/?file=2145475#file2145475line2777>
> >
> > Nit: make this a const ref?
>
> Chun-Hung Hsi
/
Testing
---
make check
Ran the unit test under stress for 500 iterations.
Thanks,
Chun-Hung Hsiao
proto messages,
since operation feeback is only supported in v1. As a result, we no longer need
the vector evolve helper.
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70686/#re
reply, visit:
https://reviews.apache.org/r/70683/#review215403
---
On May 20, 2019, 10:30 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70683/
> --
---
make check
Thanks,
Chun-Hung Hsiao
03f782ead136a79c4c5b099496072933f6737598
src/tests/storage_local_resource_provider_tests.cpp
ecd7aeef1cb3d1a5b4b3419dfd912d41a8c6
Diff: https://reviews.apache.org/r/70622/diff/2/
Changes: https://reviews.apache.org/r/70622/diff/1-2/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
://reviews.apache.org/r/70621/diff/2/
Changes: https://reviews.apache.org/r/70621/diff/1-2/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
/70620/diff/2/
Changes: https://reviews.apache.org/r/70620/diff/1-2/
Testing
---
sudo make check
more testing done later in chain
Thanks,
Chun-Hung Hsiao
Let me make it explicit here.
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70621/#review215248
---
On May 10, 2019, 1:17
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70620/#review215220
---
On May 10, 2019, 1:14 a.m., Chun-Hung Hsiao wrote:
>
>
che.org/jira/browse/MESOS-9254.
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70620/#review215202
---
On M
326a450eb2ae9912a19c6e0220e80f74d2953add
src/tests/mock_slave.cpp 1122c2a8b56b9d4e5deea4e892d81061f5e39a8d
Diff: https://reviews.apache.org/r/70686/diff/1/
Testing
---
make check
Ran the unit test under stress for 500 iterations.
Thanks,
Chun-Hung Hsiao
,
Chun-Hung Hsiao
8148aff6bf1d9637d486b549d7f8c7124566d86c
src/tests/slave_tests.cpp 50882a5aa1b20c234f3cec8366f346fa9bfd4f83
Diff: https://reviews.apache.org/r/70684/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
19c155967bf090fb2ec39211805ff1385787ab59
Diff: https://reviews.apache.org/r/70683/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
> On May 17, 2019, 10:16 a.m., Greg Mann wrote:
> > src/tests/api_tests.cpp
> > Lines 2774 (patched)
> > <https://reviews.apache.org/r/70651/diff/1/?file=2145475#file2145475line2777>
> >
> > Nit: make this a const ref?
>
> Chun-Hung Hsi
eviews.apache.org/r/70651/#review215319
-------
On May 16, 2019, 5:11 a.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically generated e-mail. To re
Diff: https://reviews.apache.org/r/70651/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
src/tests/agent_resource_provider_config_api_tests.cpp
7185ac00b5137c7ab208b623e36d03ffd43aab6e
Diff: https://reviews.apache.org/r/70628/diff/1/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
19d6c424365f8fd6e6d4a5bb7a61fbe5a66f031d
Diff: https://reviews.apache.org/r/70627/diff/1/
Testing
---
N/A
Thanks,
Chun-Hung Hsiao
> On May 10, 2019, 3:31 a.m., Chun-Hung Hsiao wrote:
> > src/tests/utils/task_scheduler.cpp
> > Lines 289 (patched)
> > <https://reviews.apache.org/r/70579/diff/1/?file=2142143#file2142143line289>
> >
> > ```
> > o
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70596/#review215058
-------
On May 3, 2019, 9:09 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an automatically gen
instead make
`TaskSchedulerProcess::submit` to take `output` as its second argument.
src/tests/utils/task_scheduler.cpp
Lines 486 (patched)
<https://reviews.apache.org/r/70579/#comment301728>
We could avoid this wiring by making `TaskSc
-Hung Hsiao
ecd7aeef1cb3d1a5b4b3419dfd912d41a8c6
Diff: https://reviews.apache.org/r/70622/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
.
Diffs
-
src/examples/test_csi_plugin.cpp 03f782ead136a79c4c5b099496072933f6737598
src/tests/storage_local_resource_provider_tests.cpp
ecd7aeef1cb3d1a5b4b3419dfd912d41a8c6
Diff: https://reviews.apache.org/r/70621/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70184/#review215120
---
Ship it!
Ship It!
- Chun-Hung Hsiao
On May 6, 2019, 9:48
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70595/#review215075
---
Ship it!
Ship It!
- Chun-Hung Hsiao
On May 6, 2019, 10:04
A possible way to fix this is to set up some promise in
`wait_for_terminate`, and then wait for the corresponding future before calling
`terminate` in this test.
That said, fixing this flake that's unlikely to happen might not worth it,
so please feel free to drop this issue.
- Chu
> On May 3, 2019, 11:31 p.m., Chun-Hung Hsiao wrote:
> > 3rdparty/libprocess/src/tests/process_tests.cpp
> > Lines 2092-2108 (patched)
> > <https://reviews.apache.org/r/70595/diff/1/?file=2142838#file2142838line2092>
> >
> > I tried this unit tes
?
- Chun-Hung Hsiao
On May 3, 2019, 7:58 p.m., Benjamin Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
Future response = http::get(url);
terminate(pid, true);
```
3rdparty/libprocess/src/tests/process_tests.cpp
Lines 2110-2112 (patched)
<https://reviews.apache.org/r/70595/#comment301417>
`AWAIT_EXPECT_RESPONSE_STATUS_EQ(http::OK().status, response);`
- Chun-Hung Hsiao
/storage_local_resource_provider_tests.cpp
ecd7aeef1cb3d1a5b4b3419dfd912d41a8c6
Diff: https://reviews.apache.org/r/70596/diff/1/
Testing
---
sudo make check
Thanks,
Chun-Hung Hsiao
Diff: https://reviews.apache.org/r/70133/diff/3/
Changes: https://reviews.apache.org/r/70133/diff/2-3/
Testing
---
`sudo make check`
Especially, tested that each of the three modified tests finishes in 5 seconds.
Thanks,
Chun-Hung Hsiao
/
Changes: https://reviews.apache.org/r/69955/diff/3-4/
Testing
---
make check
All tests passed 400 iterations (200 per parameter value) under stress.
Thanks,
Chun-Hung Hsiao
/diff/4/
Changes: https://reviews.apache.org/r/69954/diff/3-4/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
ock expectation above.
> > That seems to make more sense to me.
>
> Chun-Hung Hsiao wrote:
> It's more about making it deterministic, and also as part of the
> end-to-end scenario. The contents of the offer has already been checked by
> the matcher.
>
> I cou
/storage_local_resource_provider_tests.cpp
8bf4d2331b59770a7b7f3768499047bec2d67677
Diff: https://reviews.apache.org/r/70431/diff/2/
Changes: https://reviews.apache.org/r/70431/diff/1-2/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
/diff/4/
Changes: https://reviews.apache.org/r/70521/diff/3-4/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
353084
src/tests/slave_tests.cpp b1c3a01031b917fb9773c8c890a8f88838870559
Diff: https://reviews.apache.org/r/70132/diff/8/
Changes: https://reviews.apache.org/r/70132/diff/7-8/
Testing
---
make check
More testing done in r/70537.
Thanks,
Chun-Hung Hsiao
/scheduler_tests.cpp e0ed02900330c678bbf5c609c1f45d05147851ed
Diff: https://reviews.apache.org/r/70537/diff/2/
Changes: https://reviews.apache.org/r/70537/diff/1-2/
Testing
---
make check
Tests `ImplicitDecline3` and `ImplicitDecline5` will fail w/o r/70132.
Thanks,
Chun-Hung Hsiao
`DECLINE` and added examples for implicit decline.
Diffs
-
docs/scheduler-http-api.md a5327c229142267836f327f9c382ef50b7e334db
Diff: https://reviews.apache.org/r/70547/diff/1/
Testing
---
N/A
Thanks,
Chun-Hung Hsiao
urces",
> > e.g., if accepting offered `cpus:4` with `RESERVE(cpus:2, role) &&
> > UNRESERVE(cpus:2, role)` we would implicitly decline only `cpus:2`.
>
> Chun-Hung Hsiao wrote:
> It seems to me that "cancelling operations" as something that are bo
Diff: https://reviews.apache.org/r/70132/diff/7/
Changes: https://reviews.apache.org/r/70132/diff/6-7/
Testing
---
make check
More testing done in r/70537.
Thanks,
Chun-Hung Hsiao
/diff/2/
Changes: https://reviews.apache.org/r/70521/diff/1-2/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
---
make check
Tests `ImplicitDecline3` and `ImplicitDecline5` will fail w/o r/70132.
Thanks,
Chun-Hung Hsiao
ad54ae217863a08f4e6d743b39c176b171353084
src/tests/slave_tests.cpp b1c3a01031b917fb9773c8c890a8f88838870559
Diff: https://reviews.apache.org/r/70132/diff/6/
Changes: https://reviews.apache.org/r/70132/diff/5-6/
Testing (updated)
---
make check
More testing done in r/70537.
Thanks,
Chun-Hung
ated to behavior
> > framework authors need to reason about I strongly feel that we must add a
> > test for the expected behavior.
>
> Chun-Hung Hsiao wrote:
> I could add a unit test in a separated patch. This patch itself will be
> backported,
itself will be
backported, after discussed with @bmahler.
- Chun-Hung
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70132/#review214812
---
.
Repository: mesos
Description
---
Renamed variables in `Master::_accept` to improve readability.
Diffs
-
src/master/master.cpp ad54ae217863a08f4e6d743b39c176b171353084
Diff: https://reviews.apache.org/r/70521/diff/1/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
://reviews.apache.org/r/70132/diff/4-5/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
1396f25bf7aa9fbc62af9111ad412238faff432e
Diff: https://reviews.apache.org/r/65085/diff/2/
Changes: https://reviews.apache.org/r/65085/diff/1-2/
Testing
---
Thanks,
Chun-Hung Hsiao
t(1))`. Do you think
this would make the test simpler?
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69954/#review214689
--------
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/69955/#review214690
---
On April 12, 2019, 10:02 p.m., Chun-Hung Hsiao wrote:
>
> ---
> This is an au
,
Chun-Hung Hsiao
/storage_local_resource_provider_tests.cpp
8bf4d2331b59770a7b7f3768499047bec2d67677
Diff: https://reviews.apache.org/r/69955/diff/3/
Changes: https://reviews.apache.org/r/69955/diff/2-3/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
/v1_volume_manager.cpp bf640f9ee836f6d8cc6bb2364f2cdeddc51a7cf3
Diff: https://reviews.apache.org/r/70468/diff/1/
Testing
---
make check
Testing of this bug is done later in the chain.
Thanks,
Chun-Hung Hsiao
/diff/3/
Changes: https://reviews.apache.org/r/69954/diff/2-3/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
uot; if you are
> > using GNU date ***
> > ```
> >
> > We should also take care to potentially expect `offerRescinded`.
Okay I understand what happened here now.
Since the `CREATE` and `DESTROY` function cancel each other out, the net effect
of the last `ACCEPT` call wa
> On March 27, 2019, 5:10 p.m., Chun-Hung Hsiao wrote:
> > src/tests/storage_local_resource_provider_tests.cpp
> > Lines 4926 (patched)
> > <https://reviews.apache.org/r/70184/diff/1/?file=2130933#file2130933line4926>
> >
> > I'm not sure if
src/tests/slave_tests.cpp b1c3a01031b917fb9773c8c890a8f88838870559
Diff: https://reviews.apache.org/r/70449/diff/5/
Changes: https://reviews.apache.org/r/70449/diff/4-5/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
ted/update/
Oops thanks.
- Chun-Hung
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70449/#review214586
---
On April 11,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70454/#review214587
---
Ship it!
Ship It!
- Chun-Hung Hsiao
On April 11, 2019, 12
794a9c986b266b4916f6fbada670142798245bd1
src/tests/slave_tests.cpp b1c3a01031b917fb9773c8c890a8f88838870559
Diff: https://reviews.apache.org/r/70449/diff/4/
Changes: https://reviews.apache.org/r/70449/diff/3-4/
Testing
---
make check
Thanks,
Chun-Hung Hsiao
1 - 100 of 1959 matches
Mail list logo
