Re: Review Request 69727: Compared the device number of namespace handle instead of /proc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69727/#review211921 --- Ship it! Ship It! - Deepak Goel On Jan. 11, 2019, 11:21 p.m

Re: Review Request 69715: Fixed the CNI_NETNS handling in port mapper CNI plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69715/#review211908 --- Ship it! Ship It! - Deepak Goel On Jan. 11, 2019, 6:10 p.m

Re: Review Request 69712: Added a CNI reboot test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69712/#review211898 --- Ship it! Ship It! - Deepak Goel On Jan. 11, 2019, 6:49 p.m

Re: Review Request 69706: Kept `CNI_NETNS` unset in detach if network namespace is gone.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69706/#review211842 --- Ship it! Ship It! - Deepak Goel On Jan. 10, 2019, 8:44 p.m

Review Request 69592: Updated upgrades.md.

://reviews.apache.org/r/69592/diff/1/ Testing --- Thanks, Deepak Goel

Re: Review Request 69590: Moves CNI root directory to a persistent location.

ming that this location was never meant for users? > > Deepak Goel wrote: > Didn't understand your comment? Which location you are talking about? > > Chun-Hung Hsiao wrote: > I guess Till was asking why the log of `networkConfigJSON` is hidden from > user

Re: Review Request 69590: Moves CNI root directory to a persistent location.

/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686 src/tests/containerizer/cni_isolator_tests.cpp 5473737cdc71a3179c22be0d4db2060a6ef53d24 Diff: https://reviews.apache.org/r/69590/diff/4/ Changes: https://reviews.apache.org/r/69590/diff/3-4/ Testing --- Thanks, Deepak Goel

Re: Review Request 69590: Moves CNI root directory to a persistent location.

/flags.cpp ccaf65029ec2d0e78041fc3992a0bf5ca0798686 src/tests/containerizer/cni_isolator_tests.cpp 5473737cdc71a3179c22be0d4db2060a6ef53d24 Diff: https://reviews.apache.org/r/69590/diff/3/ Changes: https://reviews.apache.org/r/69590/diff/2-3/ Testing --- Thanks, Deepak Goel

Re: Review Request 69590: Moves CNI root directory to a persistent location.

eviews.apache.org/r/69590/#review211416 --- On Dec. 19, 2018, 2:03 a.m., Deepak Goel wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 69590: Moves CNI root directory to a persistent location.

5473737cdc71a3179c22be0d4db2060a6ef53d24 Diff: https://reviews.apache.org/r/69590/diff/2/ Changes: https://reviews.apache.org/r/69590/diff/1-2/ Testing --- Thanks, Deepak Goel

Review Request 69590: Moves CNI root directory to a persistent location.

/r/69590/diff/1/ Testing --- Thanks, Deepak Goel

Re: Review Request 69538: Added UCR bridge network for Mesos Mini.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69538/#review211155 --- Ship it! Ship It! - Deepak Goel On Dec. 10, 2018, 6:11 a.m

Re: Review Request 68335: Added a CNI test to verify destroy while preparing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68335/#review207196 --- Ship it! Ship It! - Deepak Goel On Aug. 13, 2018, 11 p.m

Re: Review Request 68333: Made CNI isolator cleanup more robust.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68333/#review207192 --- Ship it! Ship It! - Deepak Goel On Aug. 13, 2018, 10:59 p.m

Re: Review Request 68158: Fixed the iptables deadlock in CNI port mapper plugin.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68158/#review206887 --- Ship it! Ship It! - Deepak Goel On Aug. 6, 2018, 4:52 p.m

Re: Review Request 62017: Allows port mapper plugin to have optional args.

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62017/#review184620 --- On Sept. 6, 2017, 12:25 a.m., Deepak Goel wrote: > > -

Re: Review Request 62017: Allows port mapper plugin to have optional args.

/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp 43cf3e44a55c56dc8195c9cd05f6edd8bf13d448 Diff: https://reviews.apache.org/r/62017/diff/4/ Changes: https://reviews.apache.org/r/62017/diff/3-4/ Testing --- Thanks, Deepak Goel

Re: Review Request 62017: Allows port mapper plugin to have optional args.

/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp 43cf3e44a55c56dc8195c9cd05f6edd8bf13d448 Diff: https://reviews.apache.org/r/62017/diff/2/ Changes: https://reviews.apache.org/r/62017/diff/1-2/ Testing --- Thanks, Deepak Goel

Review Request 62017: Allows port mapper plugin to have optional args.

/port_mapper/port_mapper.cpp 43cf3e44a55c56dc8195c9cd05f6edd8bf13d448 Diff: https://reviews.apache.org/r/62017/diff/1/ Testing --- Thanks, Deepak Goel

Review Request 61866: Adds port mapping information in NetworkInfo as part of `state` output.

mapping information in NetworkInfo as part of `state` output. Diffs - src/common/http.cpp 43d674e9286170aae92014a952c6a8ba66437ca5 Diff: https://reviews.apache.org/r/61866/diff/1/ Testing --- Thanks, Deepak Goel