src/master/master.cpp 3c6b18ead44cd5f2978093f5415e974cfcbfa714
Diff: https://reviews.apache.org/r/52719/diff/
Testing
---
`make check`
Thanks,
Neil Conway
docs/shared-resources.md 29e43389c530f816118a32dcd7c2f1b82b0af431
Diff: https://reviews.apache.org/r/52967/diff/
Testing
---
Previewed with site-docker.
Thanks,
Neil Conway
-------
On Oct. 18, 2016, 12:50 a.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52967/
> --
Description
---
Fixed a typo in a comment.
Diffs
-
include/mesos/mesos.proto 0017d3d9d46433b391703025f611ce437bbc7ebe
include/mesos/v1/mesos.proto def33ef5e446576c86da0498e8a24e2e2de17918
Diff: https://reviews.apache.org/r/52988/diff/
Testing
---
Visual inspection.
Thanks,
Neil
12fe8593ff17c35d540f944c428cf7f33b7dcbb3
src/tests/reconciliation_tests.cpp 1412090299df388456f04ed58a1d384ce3ff550a
Diff: https://reviews.apache.org/r/52693/diff/
Testing
---
`make check`
Thanks,
Neil Conway
-----
On Oct. 18, 2016, 1:05 a.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52659/
> ---
`
Thanks,
Neil Conway
88cf1e612ad8186ef2cea161b3a52b0df9517305
Diff: https://reviews.apache.org/r/52659/diff/
Testing
---
`make check`
Thanks,
Neil Conway
5a9944cf459ab688907d95bbda09f464b37efd1e
Diff: https://reviews.apache.org/r/52658/diff/
Testing
---
`make check`
Thanks,
Neil Conway
://reviews.apache.org/r/52967/diff/
Testing
---
Previewed with site-docker.
Thanks,
Neil Conway
---
Fixed typo in comment.
Diffs
-
src/tests/containerizer/linux_filesystem_isolator_tests.cpp
f17ed4437a5e1366f85803ce7e29bee24162504c
Diff: https://reviews.apache.org/r/52966/diff/
Testing
---
Thanks,
Neil Conway
,
Neil Conway
write to a read-only
volume.
- Neil Conway
On Oct. 17, 2016, 6:15 p.m., Jiang Yan Xu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
---
Visual inspection.
Thanks,
Neil Conway
inspection, no functional change.
Thanks,
Neil Conway
b356fb62a4e068bc171a75a76001c6d0e76af92a
src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc
Diff: https://reviews.apache.org/r/52803/diff/
Testing
---
`make check`
Thanks,
Neil Conway
: mesos
Description
---
Added a CHANGELOG description for partition-aware frameworks.
Diffs
-
CHANGELOG 1b8fa346d916f941841bd34b264c8803e4286dc4
Diff: https://reviews.apache.org/r/52887/diff/
Testing
---
Visual inspection.
Thanks,
Neil Conway
iff: https://reviews.apache.org/r/52832/diff/
Testing
---
`make check`
Thanks,
Neil Conway
lltree.hpp
8ba21dedd793d3819ad2bc5674eda3ad41f9295a
Diff: https://reviews.apache.org/r/52831/diff/
Testing
---
`make check`
Thanks,
Neil Conway
Testing
---
Visual inspection.
Thanks,
Neil Conway
b356fb62a4e068bc171a75a76001c6d0e76af92a
src/tests/slave_tests.cpp 93b81d3e5b90d8036409e943f598c865fe335bcc
Diff: https://reviews.apache.org/r/52803/diff/
Testing
---
`make check`
Thanks,
Neil Conway
ff: https://reviews.apache.org/r/52723/diff/
Testing
---
`make check`
Thanks,
Neil Conway
12fe8593ff17c35d540f944c428cf7f33b7dcbb3
src/tests/reconciliation_tests.cpp 1412090299df388456f04ed58a1d384ce3ff550a
Diff: https://reviews.apache.org/r/52693/diff/
Testing
---
`make check`
Thanks,
Neil Conway
tests/reconciliation_tests.cpp 1412090299df388456f04ed58a1d384ce3ff550a
Diff: https://reviews.apache.org/r/52083/diff/
Testing
---
`make check` on OSX, Linux.
Thanks,
Neil Conway
red` when the in-progress operation has completed successfully.
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52083/#review152239
-----
` is sent appropriately. We
should add unit tests for at least some of these situations, if feasible -- but
I'll defer that for now.
Thanks,
Neil Conway
`
Thanks,
Neil Conway
/slave.cpp 6bd9b49c3bbdb973a0d03552ae8fe55b33371083
Diff: https://reviews.apache.org/r/52802/diff/
Testing
---
`make check`
Thanks,
Neil Conway
://reviews.apache.org/r/52801/diff/
Testing
---
`make check`
Thanks,
Neil Conway
6bd9b49c3bbdb973a0d03552ae8fe55b33371083
Diff: https://reviews.apache.org/r/52740/diff/
Testing
---
`make check`
Thanks,
Neil Conway
changes into
separate reviews?
3rdparty/libprocess/src/decoder.hpp (line 244)
<https://reviews.apache.org/r/52647/#comment221376>
Whitespace looks wonky.
3rdparty/libprocess/src/decoder.hpp (line 438)
<https://reviews.apache.org/r/52647/#comment221377>
Whitespace looks won
of these situations, if feasible -- but
I'll defer that for now.
Thanks,
Neil Conway
/r/52740/diff/
Testing
---
`make check`
Thanks,
Neil Conway
ake check`
Thanks,
Neil Conway
src/tests/slave_recovery_tests.cpp 703948f7a6861a4401ee45ce9cae2644106083f3
Diff: https://reviews.apache.org/r/52723/diff/
Testing
---
`make check`
Thanks,
Neil Conway
/tests/master_slave_reconciliation_tests.cpp
2983c1b074c2d4179e95e619083f5dd4e9ac6730
src/tests/slave_recovery_tests.cpp 703948f7a6861a4401ee45ce9cae2644106083f3
Diff: https://reviews.apache.org/r/52723/diff/
Testing
---
`make check`
Thanks,
Neil Conway
://issues.apache.org/jira/browse/MESOS-6332
Repository: mesos
Description
---
Fixed typo in log message.
Diffs
-
src/master/master.cpp ad8993ae43e2508a3777f4062acaca1177ac77f2
Diff: https://reviews.apache.org/r/52721/diff/
Testing
---
`make check`
Thanks,
Neil Conway
://issues.apache.org/jira/browse/MESOS-6332
Repository: mesos
Description
---
Clarified a comment.
Diffs
-
src/master/master.cpp ad8993ae43e2508a3777f4062acaca1177ac77f2
Diff: https://reviews.apache.org/r/52720/diff/
Testing
---
`make check`
Thanks,
Neil Conway
f/
Testing
---
`make check`
Thanks,
Neil Conway
tps://reviews.apache.org/r/52695/#comment220708>
"Enable all warnings" is not a great description for "-Wall" (despite how
it is named).
3rdparty/libprocess/Makefile.am (line 17)
<https://reviews.apache.org/r/52695/#comment220709>
"comparison"
- Neil Conway
1412090299df388456f04ed58a1d384ce3ff550a
Diff: https://reviews.apache.org/r/52693/diff/
Testing
---
`make check`
Thanks,
Neil Conway
---
`make check`
Thanks,
Neil Conway
---
`make check`
Thanks,
Neil Conway
---
`make check`
Thanks,
Neil Conway
---
Cleaned up a test case.
Diffs
-
src/tests/fault_tolerance_tests.cpp 5a9944cf459ab688907d95bbda09f464b37efd1e
Diff: https://reviews.apache.org/r/52656/diff/
Testing
---
`make check`
Thanks,
Neil Conway
, we previously didn't
enable basic stuff like `-Wall` for stout and libprocess?!). As noted in the
other review, stout/libprocess/mesos changes should be split into separate
reviews.
- Neil Conway
On Oct. 7, 2016, 7:22 p.m., Aaron Wood wrote
ons of?) gcc/clang.
(2) You should split this review into three separate reviews: a single review
should make changes to at most one of Mesos, libprocess, and stout.
(3) What _specific_ attack vectors are these changes intended to prevent?
- Neil Conway
On Oct. 7, 2016, 7:22 p.m.
---
Fixed typo in comment.
Diffs
-
src/java/jni/org_apache_mesos_state_AbstractState.cpp
8addd2d71c0e830e4bf9c0c1ff0c7e4af776060a
Diff: https://reviews.apache.org/r/52633/diff/
Testing
---
Thanks,
Neil Conway
---
Synchronized unversioned and v1 mesos.proto.
Diffs
-
include/mesos/v1/mesos.proto 57846a5cc0d8af53771346ad4b441ce7b337c6c5
Diff: https://reviews.apache.org/r/52634/diff/
Testing
---
Thanks,
Neil Conway
---
Improved symmetry of code in related utility functions.
Diffs
-
src/tests/utils.cpp cc5259a720bb6451714a100b0451b473395e3650
Diff: https://reviews.apache.org/r/52617/diff/
Testing
---
`make check`
Thanks,
Neil Conway
://issues.apache.org/jira/browse/MESOS-6231
Repository: mesos
Description
---
Added comment describing a common gotcha.
Diffs
-
src/tests/utils.cpp cc5259a720bb6451714a100b0451b473395e3650
Diff: https://reviews.apache.org/r/52618/diff/
Testing
---
`make check`
Thanks,
Neil Conway
---
Fixed whitespace infelicities.
Diffs
-
src/tests/utils.cpp cc5259a720bb6451714a100b0451b473395e3650
Diff: https://reviews.apache.org/r/52616/diff/
Testing
---
`make check`
Thanks,
Neil Conway
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5/#review150236
---
Ship it!
Ship It!
- Neil Conway
On Sept. 23, 2016, 7:31 p.m
.
Changes
---
Rebase.
Repository: mesos
Description
---
Tweaked test comments.
Diffs (updated)
-
src/tests/partition_tests.cpp 7c38f0efa414447e6292b2d6b334fb9879c92eb5
Diff: https://reviews.apache.org/r/52175/diff/
Testing
---
`make check` on OSX.
Thanks,
Neil
7c38f0efa414447e6292b2d6b334fb9879c92eb5
Diff: https://reviews.apache.org/r/52174/diff/
Testing
---
`make check` on OSX.
Thanks,
Neil Conway
-----
On Sept. 22, 2016, 9:12 p.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52174/
>
and Linux.
Thanks,
Neil Conway
---
Tweaked test comments.
Diffs
-
src/tests/partition_tests.cpp 7c38f0efa414447e6292b2d6b334fb9879c92eb5
Diff: https://reviews.apache.org/r/52175/diff/
Testing
---
`make check` on OSX.
Thanks,
Neil Conway
66a672f6d16233e96b29e330a9e6c474546fa851
src/tests/partition_tests.cpp 7c38f0efa414447e6292b2d6b334fb9879c92eb5
Diff: https://reviews.apache.org/r/52174/diff/
Testing
---
`make check` on OSX.
Thanks,
Neil Conway
hpp
31acbd406c7d447d6f141201c0cfa153d948ef9f
3rdparty/stout/include/stout/os/raw/argv.hpp
3ac62169be22eebaa56ec1a3b7cf1d0007b17870
Diff: https://reviews.apache.org/r/52086/diff/
Testing
---
`make check` on OSX and Linux.
Thanks,
Neil Conway
/52085/diff/
Testing
---
`make check` on OSX and Linux.
Thanks,
Neil Conway
3ac62169be22eebaa56ec1a3b7cf1d0007b17870
Diff: https://reviews.apache.org/r/52086/diff/
Testing
---
`make check` on OSX and Linux.
Thanks,
Neil Conway
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43138/#review149971
---
Ship it!
Ship It!
- Neil Conway
On Sept. 21, 2016, 2:39 p.m
Klues.
Changes
---
Tweak.
Repository: mesos
Description
---
Observed with clang-tidy.
Diffs (updated)
-
src/linux/fs.cpp 369a302e0f97daaa987df8d625cfe3c4808cdfc9
Diff: https://reviews.apache.org/r/52113/diff/
Testing
---
`make check` on Linux.
Thanks,
Neil
Description
---
Observed with clang-tidy.
Diffs
-
src/linux/fs.cpp 369a302e0f97daaa987df8d625cfe3c4808cdfc9
Diff: https://reviews.apache.org/r/52113/diff/
Testing
---
`make check` on Linux.
Thanks,
Neil Conway
.
Thanks,
Neil Conway
initialize libprocess before calling into any libprocess
facilities (in this case, `process::Latch`).
Diffs
-
src/exec/exec.cpp c1cda5aca81dd8c73c50dd01ce49ef69805bbf09
Diff: https://reviews.apache.org/r/52082/diff/
Testing
---
`make check` on OSX.
Thanks,
Neil Conway
/52080/diff/
Testing
---
`make check` on OSX.
Thanks,
Neil Conway
_tests.cpp 696e0f71190238133f29b6380bc58b994a556e69
Diff: https://reviews.apache.org/r/52039/diff/
Testing
---
`make check` on OSX.
Thanks,
Neil Conway
4992ab0a0bb5babbf6a4fa3e6eff3577590fc879
src/tests/master_tests.cpp 6cde15fcd6ca8ec40438c75aed980e83f8de9b86
src/tests/reconciliation_tests.cpp 8e438bfbce508a074f0d54513cd752344238e3f2
Diff: https://reviews.apache.org/r/51376/diff/
Testing
---
make check
Thanks,
Neil Conway
to a well-defined value in the first place.
Diffs
-
3rdparty/libprocess/src/process.cpp 1e48fd5269d1a94c2217e8826af54b9b42ec4b23
Diff: https://reviews.apache.org/r/51984/diff/
Testing
---
`make check` on OSX.
Thanks,
Neil Conway
---
Avoided passing large object by value.
Diffs
-
src/slave/containerizer/mesos/isolators/network/cni/cni.hpp
eea80355d9a12f7b9571c55194ef3ab4931e6aed
Diff: https://reviews.apache.org/r/51983/diff/
Testing
---
`make check` on OSX and Linux.
Thanks,
Neil Conway
43af218
src/tests/cluster.cpp b04653af97d17aaa9d0d3ee872169b66cd67126b
src/tests/mesos.cpp 07a64f0ff49a753ec26260cdf859d0584c3f935a
Diff: https://reviews.apache.org/r/51958/diff/
Testing
---
`make check` on OSX and Linux.
Thanks,
Neil Conway
4942ac88b8e27741ef9b4e1fe0d82ab788bae883
Diff: https://reviews.apache.org/r/51954/diff/
Testing
---
`make check` on OSX and Linux.
Thanks,
Neil Conway
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51953/#review149241
-------
On Sept. 16, 2016, 7:15 p.m., Neil Conway wrote:
>
>
rc/master/master.hpp 4992ab0a0bb5babbf6a4fa3e6eff3577590fc879
src/master/master.cpp b88472f6350d3f71e057bab34822423da5427151
src/tests/registrar_tests.cpp b04fc92c66449f1094212a534899e16d5f6f01bd
Diff: https://reviews.apache.org/r/51953/diff/
Testing
---
`make check` on OSX and Linux.
Thanks,
Neil Conway
/
Testing
---
`make check` on OSX and Linux.
Thanks,
Neil Conway
/include/stout/os/windows/pagesize.hpp
6112e9781a9d42f7ec1ae0832c0c877d1915b09b
Diff: https://reviews.apache.org/r/51967/diff/
Testing
---
`make check` on OSX and Linux.
Thanks,
Neil Conway
/51956/diff/
Testing
---
`make check` on OSX and Linux.
Thanks,
Neil Conway
b04fc92c66449f1094212a534899e16d5f6f01bd
Diff: https://reviews.apache.org/r/51957/diff/
Testing
---
`make check` on OSX and Linux.
Thanks,
Neil Conway
r/http.cpp 9005e7c308d5f57c6f5c573951d468a3ba730740
src/tests/cluster.cpp b04653af97d17aaa9d0d3ee872169b66cd67126b
src/tests/mesos.cpp 07a64f0ff49a753ec26260cdf859d0584c3f935a
Diff: https://reviews.apache.org/r/51958/diff/
Testing
---
`make check` on OSX and Linux.
Thanks,
Neil Conway
rc/master/master.cpp b88472f6350d3f71e057bab34822423da5427151
src/tests/master_tests.cpp 6cde15fcd6ca8ec40438c75aed980e83f8de9b86
Diff: https://reviews.apache.org/r/51955/diff/
Testing
---
`make check` on OSX and Linux.
Thanks,
Neil Conway
.
Thanks,
Neil Conway
rc/master/master.cpp b88472f6350d3f71e057bab34822423da5427151
src/tests/registrar_tests.cpp b04fc92c66449f1094212a534899e16d5f6f01bd
Diff: https://reviews.apache.org/r/51953/diff/
Testing
---
`make check` on OSX and Linux.
Thanks,
Neil Conway
whose ID we collided with.
Diffs (updated)
-
src/master/master.hpp 4992ab0a0bb5babbf6a4fa3e6eff3577590fc879
src/master/master.cpp b88472f6350d3f71e057bab34822423da5427151
Diff: https://reviews.apache.org/r/51913/diff/
Testing
---
`make check`
Thanks,
Neil Conway
4992ab0a0bb5babbf6a4fa3e6eff3577590fc879
src/master/master.cpp b88472f6350d3f71e057bab34822423da5427151
Diff: https://reviews.apache.org/r/51913/diff/
Testing
---
`make check`
Thanks,
Neil Conway
(32296 ms)
[ RUN ] SlaveCount/Registrar_BENCHMARK_Test.MarkUnreachableThenReachable/3
Marked 5 agents unreachable in 39.277686secs
Marked 5 agents reachable in 18.483256secs
[ OK ] SlaveCount/Registrar_BENCHMARK_Test.MarkUnreachableThenReachable/3
(73369 ms)
```
Thanks,
Neil
` is quadratic
time and `MarkSlaveReachable` and `MarkSlaveUnreachable` are both linear time.
For the time being, optimizing these operations doesn't seem like it is needed
urgently.
Thanks,
Neil Conway
eviews.apache.org/r/51375/#review148960
---
On Sept. 15, 2016, 7:36 a.m., Neil Conway wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51375/
>
Diff: https://reviews.apache.org/r/51375/diff/
Testing
---
make check
Thanks,
Neil Conway
/partition_tests.cpp f3142ad8d50daafcdb70ad9dbb2772f8ba30db00
Diff: https://reviews.apache.org/r/51891/diff/
Testing
---
`make check`
Thanks,
Neil Conway
of the `reset`s should
be the reverse of the order in which the fields are initialized in the ctor.
That is also fragile, however.
- Neil Conway
On Sept. 14, 2016, 10:35 a.m., Neil Conway wrote:
>
> ---
> This is an automatically generat
EATION
src/tests/mock_registrar.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/51375/diff/
Testing
---
make check
Thanks,
Neil Conway
2f3fa5fae634b6250f3c00bbef3077493f79af95
Diff: https://reviews.apache.org/r/51707/diff/
Testing
---
make check
Thanks,
Neil Conway
/
Testing
---
make check
Thanks,
Neil Conway
rtant for admins to pay attention to.
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51653/#review148619
---
On Sept. 12, 2
s
> > correctly here? What would happen if master behaves incorrectly? Maybe add
> > some comments?
>
> Neil Conway wrote:
> Well, we're checking the master does not segfault or hit a `CHECK`
> failure, which it was doing before I fixed that bug and added this test :
Thanks,
Neil Conway
)
-
src/tests/slave_tests.cpp 2f3fa5fae634b6250f3c00bbef3077493f79af95
Diff: https://reviews.apache.org/r/50707/diff/
Testing
---
make check
Thanks,
Neil Conway
ain).
I also improved the comments.
- Neil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50707/#review148592
-------
O
801 - 900 of 2064 matches
Mail list logo