.
Diffs (updated)
-
src/slave/containerizer/mesos/isolators/gpu/isolator.cpp
a0be1026bdaf7d4bb33f41e4c7d45666bd61f005
Diff: https://reviews.apache.org/r/72945/diff/3/
Changes: https://reviews.apache.org/r/72945/diff/2-3/
Testing
---
sudo make check
Thanks,
Qian Zhang
it?
Agreed.
- Qian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72945/#review222030
---
On Oct. 13, 2020, 9:39 a
-containerizer.md 3231cb93481102dfc26a718918566e61b57e3617
Diff: https://reviews.apache.org/r/72845/diff/4/
Changes: https://reviews.apache.org/r/72845/diff/3-4/
Testing
---
Thanks,
Qian Zhang
is is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72845/#review222019
-------
On Oct. 8, 2020, 3:57 p.m., Qian Zhang wrote:
>
> ---
/72945/diff/2/
Changes: https://reviews.apache.org/r/72945/diff/1-2/
Testing
---
sudo make check
Thanks,
Qian Zhang
his is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72945/#review222025
-------
On Oct. 12, 2020, 9:50 a.m., Qian Zhang wrote:
>
> ---
Diff: https://reviews.apache.org/r/72945/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
directoy entries when globing Nvidia GPU devices.
Diffs
-
src/slave/containerizer/mesos/isolators/gpu/isolator.cpp
a0be1026bdaf7d4bb33f41e4c7d45666bd61f005
Diff: https://reviews.apache.org/r/72945/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
-containerizer.md 3231cb93481102dfc26a718918566e61b57e3617
Diff: https://reviews.apache.org/r/72845/diff/3/
Changes: https://reviews.apache.org/r/72845/diff/2-3/
Testing
---
Thanks,
Qian Zhang
/72888/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
/containerizer/volume_csi_isolator_tests.cpp
d51d3c94e1a707f54d6b36ce6484068243e696c2
src/tests/mesos.hpp 49abfc2aabaa151f9b7642db2ba34bf63554d48e
Diff: https://reviews.apache.org/r/72888/diff/1/
Testing
---
sudo make check
Thanks,
Qian Zhang
878788c0cb675a16ef69abd4facc8ca89cbd19d3
Diff: https://reviews.apache.org/r/72846/diff/1/
Testing
---
Thanks,
Qian Zhang
: https://reviews.apache.org/r/72846/diff/1/
Testing
---
Thanks,
Qian Zhang
3231cb93481102dfc26a718918566e61b57e3617
Diff: https://reviews.apache.org/r/72845/diff/2/
Changes: https://reviews.apache.org/r/72845/diff/1-2/
Testing
---
Thanks,
Qian Zhang
/r/72845/diff/1/
Testing
---
Thanks,
Qian Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72806/#review221803
---
Ship it!
Ship It!
- Qian Zhang
On Sept. 4, 2020, 2:39 p.m
ight? And why does `targetPath` not exist when publishing volume succeeds?
- Qian Zhang
On Sept. 4, 2020, 9:25 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
an container. But I guess what you want to
verify in this test is not orphan container, instead it should be the container
finishes when agent is down, right? Maybe you can just update the name and the
comments of this test by not mentioning "orphan container"?
- Qian Zhang
On S
> On Sept. 2, 2020, 9:35 p.m., Qian Zhang wrote:
> > src/tests/containerizer/volume_csi_isolator_tests.cpp
> > Lines 238 (patched)
> > <https://reviews.apache.org/r/72728/diff/13/?file=2239017#file2239017line238>
> >
> > Do we really need this method?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221793
---
Ship it!
Ship It!
- Qian Zhang
On Sept. 3, 2020, 3:05 a.m
/provisioner_docker_tests.cpp
Lines 437-438 (patched)
<https://reviews.apache.org/r/72794/#comment310868>
A newline between.
- Qian Zhang
On Aug. 21, 2020, 1:08 a.m., Andrei Sekretenko wrote:
>
> ---
> This is an automatica
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72793/#review221791
---
Ship it!
Ship It!
- Qian Zhang
On Aug. 21, 2020, 1:07 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72792/#review221790
---
Ship it!
Ship It!
- Qian Zhang
On Aug. 21, 2020, 1:07 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72791/#review221789
---
Ship it!
Ship It!
- Qian Zhang
On Aug. 21, 2020, 1:06 a.m
g/r/72790/#comment310841>
A newline between.
- Qian Zhang
On Aug. 21, 2020, 1:06 a.m., Andrei Sekretenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
ker Hub, right? Then I think we need to include the prefix
`INTERNET_CURL_` in the test name.
- Qian Zhang
On Sept. 2, 2020, 1:57 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72805/#review221775
---
Ship it!
Ship It!
- Qian Zhang
On Sept. 2, 2020, 1:50 p.m
/isolator.cpp
d5d8835f00798884bcf46f728470ee18868b405c
src/slave/containerizer/mesos/isolators/volume/csi/paths.hpp
5b4a4eeed0e85a5bed90056638414acf3a9e7ab5
Diff: https://reviews.apache.org/r/72829/diff/1/
Testing
---
Thanks,
Qian Zhang
/72804/diff/3/
Changes: https://reviews.apache.org/r/72804/diff/2-3/
Testing
---
Thanks,
Qian Zhang
on `LocalImplicitResourceProviderObjectApprover` to
authorize CSI server, right?
https://github.com/apache/mesos/blob/1.10.0/src/authorizer/local/authorizer.cpp#L1128:L1140
- Qian Zhang
On Aug. 29, 2020, 8:44 a.m., Greg Mann wrote:
>
> ---
> This is an auto
29ae821f0d7411816de9363aa6364b4874097942
Diff: https://reviews.apache.org/r/72820/diff/1/
Testing
---
Thanks,
Qian Zhang
--------
On Aug. 30, 2020, 9:36 a.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72804/
> -
---
Thanks,
Qian Zhang
> On Aug. 25, 2020, 10:41 p.m., Qian Zhang wrote:
> > src/tests/csi_server_tests.cpp
> > Lines 457 (patched)
> > <https://reviews.apache.org/r/72728/diff/9/?file=2238569#file2238569line457>
> >
> > It seems we only want to verify the behavior of CSI ser
stead?
src/tests/containerizer/volume_csi_isolator_tests.cpp
Lines 541 (patched)
<https://reviews.apache.org/r/72728/#comment310771>
Do we want to unpublish the volume at the end of this test? Otherwise there
will be a mount left on the host filesystem?
- Qian Zhang
On Au
> On Aug. 25, 2020, 10:41 p.m., Qian Zhang wrote:
> > src/tests/csi_server_tests.cpp
> > Lines 457 (patched)
> > <https://reviews.apache.org/r/72728/diff/9/?file=2238569#file2238569line457>
> >
> > It seems we only want to verify the behavior of CSI ser
(patched)
<https://reviews.apache.org/r/72805/#comment310764>
A newline between.
src/tests/mesos.hpp
Lines 2097 (patched)
<https://reviews.apache.org/r/72805/#comment310765>
Do we need another `createVolumeHostPath` in the `internal` namespace at
line 1804?
- Qian Zhang
On A
/flags.cpp 878788c0cb675a16ef69abd4facc8ca89cbd19d3
Diff: https://reviews.apache.org/r/72803/diff/1/
Testing
---
Thanks,
Qian Zhang
/mesos/isolators/volume/csi/isolator.cpp
02ef1f215eeb0e6436d42146b922d8a48e023607
Diff: https://reviews.apache.org/r/72804/diff/1/
Testing
---
Thanks,
Qian Zhang
d to end, maybe we do not need to start master and agent just like
what we do in `ROOT_InvalidPluginConfig`?
- Qian Zhang
On Aug. 25, 2020, 5:20 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72727/#review221702
---
Ship it!
Ship It!
- Qian Zhang
On Aug. 18, 2020, 9:23 a.m
/mesos.proto ffe45c305ab46c73f0da5908287aa3eab8ecf5dd
src/csi/v1_volume_manager.cpp c05265cd514de745e824c16a0acef276deed1510
Diff: https://reviews.apache.org/r/72788/diff/2/
Testing
---
Thanks,
Qian Zhang
535974bc9ef4049551d7ea7b464bd000deccd7e8
Diff: https://reviews.apache.org/r/72789/diff/3/
Testing
---
Thanks,
Qian Zhang
---
Thanks,
Qian Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72799/#review221700
---
Ship it!
Ship It!
- Qian Zhang
On Aug. 25, 2020, 8:16 a.m
535974bc9ef4049551d7ea7b464bd000deccd7e8
Diff: https://reviews.apache.org/r/72789/diff/2/
Testing
---
Thanks,
Qian Zhang
To reply, visit:
https://reviews.apache.org/r/72789/#review221678
---
On Aug. 23, 2020, 10:32 p.m., Qian Zhang wrote:
>
> ---
> This is an automatically generated e
/diff/1-2/
Testing
---
Thanks,
Qian Zhang
/v1_volume_manager.cpp c05265cd514de745e824c16a0acef276deed1510
Diff: https://reviews.apache.org/r/72788/diff/2/
Changes: https://reviews.apache.org/r/72788/diff/1-2/
Testing
---
Thanks,
Qian Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72779/#review221672
---
Ship it!
Ship It!
- Qian Zhang
On Aug. 21, 2020, 7:14 a.m
> On Aug. 20, 2020, 10:17 a.m., Qian Zhang wrote:
> > src/slave/csi_server.cpp
> > Lines 280 (patched)
> > <https://reviews.apache.org/r/72779/diff/3/?file=2238503#file2238503line284>
> >
> > So here we erase the plugin while `plugin.initialized`
535974bc9ef4049551d7ea7b464bd000deccd7e8
Diff: https://reviews.apache.org/r/72789/diff/1/
Testing
---
Thanks,
Qian Zhang
://reviews.apache.org/r/72789/diff/1/
Testing
---
Thanks,
Qian Zhang
/
Testing
---
Thanks,
Qian Zhang
> On Aug. 20, 2020, 2:41 p.m., Qian Zhang wrote:
> > src/slave/csi_server.cpp
> > Lines 280-282 (patched)
> > <https://reviews.apache.org/r/72779/diff/3/?file=2238503#file2238503line284>
> >
> > I think we should log an error message here, otherwise w
herwise when
`initializePlugin()` is called in `start()` we will not know which plugin is
failed to initialize.
- Qian Zhang
On Aug. 20, 2020, 3:04 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To
> On Aug. 19, 2020, 3:43 p.m., Qian Zhang wrote:
> > src/slave/csi_server.cpp
> > Line 136 (original), 155 (patched)
> > <https://reviews.apache.org/r/72779/diff/2/?file=2238466#file2238466line158>
> >
> > If `name` is specified, do we need to do this
src/slave/csi_server.cpp
Lines 308 (patched)
<https://reviews.apache.org/r/72779/#comment310719>
Kill this newline.
Ditto for the similar code in `CSIServerProcess::publishVolume` and
`CSIServerProcess::unpublishVolume`
- Qian Zhang
On Aug. 20, 2020, 3:04 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72761/#review221652
---
Ship it!
Ship It!
- Qian Zhang
On Aug. 20, 2020, 5:48 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72761/#review221637
---
Ship it!
Ship It!
- Qian Zhang
On Aug. 19, 2020, 2:16 p.m
cified, do we need to do this `os::ls`? I think we can just
load and initialize the specified plugin directly without traversing the
entries in `pluginConfigDir`, right?
- Qian Zhang
On Aug. 19, 2020, 2:
--
>
> (Updated Aug. 18, 2020, 1:13 p.m.)
>
>
> Review request for mesos and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> ---
>
> This patc
: https://reviews.apache.org/r/72759/diff/2-3/
Testing
---
Thanks,
Qian Zhang
> On Aug. 14, 2020, 6:21 a.m., Greg Mann wrote:
> > src/csi/service_manager.cpp
> > Lines 740 (patched)
> > <https://reviews.apache.org/r/72759/diff/1/?file=2237900#file2237900line740>
> >
> > Where does this env var name come from, 'MESOS_NODE_ID'?
&g
/csi_server.cpp b435d5db194ffad736838a5b98494944d3264045
Diff: https://reviews.apache.org/r/72759/diff/2/
Changes: https://reviews.apache.org/r/72759/diff/1-2/
Testing
---
Thanks,
Qian Zhang
3c1840cae4befe09581ea4efae855d552bd19b05
Diff: https://reviews.apache.org/r/72754/diff/3/
Changes: https://reviews.apache.org/r/72754/diff/2-3/
Testing
---
Thanks,
Qian Zhang
a void method), and here we do not need to handle its result.
- Qian Zhang
On Aug. 18, 2020, 1:13 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
erver::start()` in the way that I
mentioned in this comment (https://reviews.apache.org/r/72779/#comment310664),
then I think `CSIServer::start()` do not need to return anything (just a void
method), and here we do not need to handle its result.
- Qian Zhang
On Aug. 18, 2020, 9:25 a.m., Gre
/diff/1/
Testing
---
Thanks,
Qian Zhang
t keep
the method `CSIServer::start()` where we can just do `started.set(Nothing());`.
WDYT?
- Qian Zhang
On Aug. 15, 2020, 11:54 p.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
ve to assign `info` at line 152.
src/slave/csi_server.cpp
Lines 204 (patched)
<https://reviews.apache.org/r/72779/#comment310662>
Will this `repair` get invoked when each of the above `then()` fails? Or it
will get invoked only when the last `then()` fails?
- Qian Zhang
On Aug. 1
> On Aug. 13, 2020, 10:42 a.m., Qian Zhang wrote:
> > src/slave/slave.hpp
> > Lines 892 (patched)
> > <https://reviews.apache.org/r/72761/diff/1/?file=2237909#file2237909line892>
> >
> > Why does slave need CSI server as its member?
I think slave ne
GENT_ENDPOINT`. Or maybe we should name it `MESOS_AGENT_IP`?
- Qian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72759/#review221574
---
e8608d977652baf02b4474bb48d3f4598cfa5f3f
src/slave/flags.cpp 02a5568f29927e767029a53f05f3b3e97ed0d1f8
Diff: https://reviews.apache.org/r/72770/diff/1/
Testing
---
Thanks,
Qian Zhang
nabled) {
```
I used the following configuration parameters, anything missed?
```
../configure --disable-libtool-wrappers --disable-python --disable-java
--enable-ssl --enable-libevent --enable-debug
```
- Qian Zhang
On Aug. 13, 2020, 3:19 a.m., Greg Mann
3c1840cae4befe09581ea4efae855d552bd19b05
Diff: https://reviews.apache.org/r/72754/diff/2/
Changes: https://reviews.apache.org/r/72754/diff/1-2/
Testing
---
Thanks,
Qian Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72760/#review221561
---
Ship it!
Ship It!
- Qian Zhang
On Aug. 13, 2020, 3:21 a.m
.apache.org/r/72761/#comment310627>
Why does slave need CSI server as its member?
src/tests/cluster.hpp
Lines 59 (patched)
<https://reviews.apache.org/r/72761/#comment310628>
This line should be put below the line `#include "slave/constants.hpp"`.
- Qian Zhang
On Aug
/
Testing
---
Thanks,
Qian Zhang
> On Aug. 12, 2020, 11:18 a.m., Qian Zhang wrote:
> > src/tests/csi_server_tests.cpp
> > Lines 114-121 (patched)
> > <https://reviews.apache.org/r/72728/diff/3/?file=2237793#file2237793line114>
> >
> > It seems the required flag
> > [--endpoint
src/examples/test_csi_plugin.cpp#L130:L132)
is not set here?
- Qian Zhang
On Aug. 11, 2020, 11:08 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
3>
I think this will break the case when `--volume_id_path` is set to true, in
which case `volumeInfo.id` is already set to `getVolumePath(capacity, name)` in
the constructor and now here we call `getVolumePath` again which will give us a
wrong volume path.
- Qian Zhang
On Aug. 12, 20
tps://reviews.apache.org/r/72728/#comment310619>
Instead of removing this, I think we may need to implement the `TearDown`
method to do some cleanup like:
https://github.com/apache/mesos/blob/1.10.0/src/tests/storage_local_resource_provider_tests.cpp#L163:L187
WDYT?
- Qian Zhang
---
>
> (Updated Aug. 11, 2020, 11:07 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> ---
>
&
-CREATION
Diff: https://reviews.apache.org/r/72733/diff/5/
Changes: https://reviews.apache.org/r/72733/diff/4-5/
Testing
---
Thanks,
Qian Zhang
/volume/csi/isolator.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72753/diff/2/
Changes: https://reviews.apache.org/r/72753/diff/1-2/
Testing
---
Thanks,
Qian Zhang
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72732/#review221534
---
Ship it!
Ship It!
- Qian Zhang
On Aug. 11, 2020, 12:20 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72716/#review221531
---
Ship it!
Ship It!
- Qian Zhang
On Aug. 11, 2020, 10:30 a.m
^
../../../src/csi/volume_manager.hpp:58:45: note: candidate expects 7
arguments, 8 provided
```
- Qian Zhang
On Aug. 7, 2020, 3:03 p.m., Greg Mann wrote:
>
> ---
> This is an au
we did
when `volumeIdPath` is set to `true`.
- Qian Zhang
On Aug. 1, 2020, 3:06 a.m., Greg Mann wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
src/tests/csi_server_tests.cpp
Lines 92 (patched)
<https://reviews.apache.org/r/72728/#comment310573>
I do not see how `slaveWorkDirs` is used afterward.
- Qian Zhang
On Aug. 7, 2020, 3:02 p.m., Greg Mann wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72716/#review221517
---
Ship it!
Ship It!
- Qian Zhang
On Aug. 7, 2020, 3 p.m
> On Aug. 7, 2020, 8:01 p.m., Qian Zhang wrote:
> > src/slave/csi_server.cpp
> > Lines 200 (patched)
> > <https://reviews.apache.org/r/72716/diff/5/?file=2237439#file2237439line200>
> >
> > Do we need to include `info.type()` in the container pref
: https://reviews.apache.org/r/72733/diff/4/
Changes: https://reviews.apache.org/r/72733/diff/3-4/
Testing
---
Thanks,
Qian Zhang
> On July 29, 2020, 11:27 p.m., Qian Zhang wrote:
> > src/slave/csi_server.cpp
> > Lines 233-235 (patched)
> > <https://reviews.apache.org/r/72716/diff/2/?file=2236468#file2236468line233>
> >
> > I am just curious what would happen if any of
---
Thanks,
Qian Zhang
/isolator.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72753/diff/1/
Testing
---
Thanks,
Qian Zhang
/volume/csi/paths.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/volume/csi/paths.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72690/diff/10/
Changes: https://reviews.apache.org/r/72690/diff/9-10/
Testing
---
Thanks,
Qian Zhang
/isolator.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72734/diff/3/
Changes: https://reviews.apache.org/r/72734/diff/2-3/
Testing
---
Thanks,
Qian Zhang
> On July 29, 2020, 11:27 p.m., Qian Zhang wrote:
> > src/slave/csi_server.cpp
> > Lines 233-235 (patched)
> > <https://reviews.apache.org/r/72716/diff/2/?file=2236468#file2236468line233>
> >
> > I am just curious what would happen if any of
1 - 100 of 2317 matches
Mail list logo
