Review Request 71157: Update docker image before build.

2019-07-24 Thread Tomasz Janiszewski
://reviews.apache.org/r/71157/diff/1/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 71118: Update clang and cmake for arm docker build.

2019-07-18 Thread Tomasz Janiszewski
://reviews.apache.org/r/71118/diff/3-4/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 71118: Update clang and cmake for arm docker build.

2019-07-18 Thread Tomasz Janiszewski
://reviews.apache.org/r/71118/diff/2-3/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 71118: Update clang and cmake for arm docker build.

2019-07-18 Thread Tomasz Janiszewski
://reviews.apache.org/r/71118/diff/1-2/ Testing --- Thanks, Tomasz Janiszewski

Review Request 71118: Update clang and cmake for arm docker build.

2019-07-18 Thread Tomasz Janiszewski
--- Update clang and cmake for arm docker build. Diffs - support/mesos-build/ubuntu-16.04-arm.dockerfile d223202e38d1d78554af9c95de1ee78a70dc3818 Diff: https://reviews.apache.org/r/71118/diff/1/ Testing --- Thanks, Tomasz Janiszewski

Review Request 70727: Fix V1 TaskState invalid enum in test.

2019-05-27 Thread Tomasz Janiszewski
Thanks, Tomasz Janiszewski

Review Request 70386: Quote chmode arguments

2019-04-04 Thread Tomasz Janiszewski
--- Quote `chmod` arguments Diffs - support/mesos-build.sh c2d121debdbf26053bc9b699b437933a0682733c Diff: https://reviews.apache.org/r/70386/diff/1/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 70102: Moved NULL check from cpplint into clang-tidy.

2019-03-04 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70102/#review213390 --- Ship it! Ship It! - Tomasz Janiszewski On Mar 3, 2019, 1:02

Review Request 66138: Add dockerfile for ARM.

2018-03-19 Thread Tomasz Janiszewski
. Repository: mesos Description --- Add dockerfile for ARM. Diffs - support/mesos-build/ubuntu-16.04-arm.dockerfile PRE-CREATION Diff: https://reviews.apache.org/r/66138/diff/1/ Testing --- Thanks, Tomasz Janiszewski

Review Request 65569: Install ping for docker build.

2018-02-08 Thread Tomasz Janiszewski
/65569/diff/1/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 63400: Fix bad links.

2017-11-08 Thread Tomasz Janiszewski
3b8114d6c2eb33200800999c410d1d6030fa5148 site/source/layouts/community_section.erb 07fd28853e119c1d9298a662cc6d73054b6e415f Diff: https://reviews.apache.org/r/63400/diff/3/ Changes: https://reviews.apache.org/r/63400/diff/2-3/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 63400: Fix bad links.

2017-11-06 Thread Tomasz Janiszewski
The `[lacking a while]` link is missing the colon in `https://`. > > Tomasz Janiszewski wrote: > Good catch. Thanks! > > Vinod Kone wrote: > forgot to push the updated diff? I pushed but forgot to publish :) Fixed. - Tomasz

Re: Review Request 63400: Fix bad links.

2017-11-06 Thread Tomasz Janiszewski
-community-update-1.md 3b8114d6c2eb33200800999c410d1d6030fa5148 site/source/layouts/community_section.erb 07fd28853e119c1d9298a662cc6d73054b6e415f Diff: https://reviews.apache.org/r/63400/diff/2/ Changes: https://reviews.apache.org/r/63400/diff/1-2/ Testing --- Thanks, Tomasz

Re: Review Request 63400: Fix bad links.

2017-10-31 Thread Tomasz Janiszewski
---- On Oct. 30, 2017, 2:48 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63400/ > ---

Re: Review Request 63400: Fix bad links.

2017-10-31 Thread Tomasz Janiszewski
ps://reviews.apache.org/r/63400/#review189620 ------- On Oct. 30, 2017, 2:48 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63400/ > -

Re: Review Request 63400: Fix bad links.

2017-10-30 Thread Tomasz Janiszewski
> On Oct. 30, 2017, 2:42 p.m., Joerg Schad wrote: > > Would it make sense (in addition to this) to add redirect fromt the old > > pages? There might be external links being broken as well... > > Tomasz Janiszewski wrote: > +1 I've already pointed it here > h

Re: Review Request 63400: Fix bad links.

2017-10-30 Thread Tomasz Janiszewski
6642 - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63400/#review189577 --- On Oct. 29, 2017, 9:43 p.m., Tomasz Ja

Review Request 63400: Fix bad links.

2017-10-29 Thread Tomasz Janiszewski
/community_section.erb 07fd28853e119c1d9298a662cc6d73054b6e415f Diff: https://reviews.apache.org/r/63400/diff/1/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 63095: Added the Getting Started landing page.

2017-10-29 Thread Tomasz Janiszewski
links – instead provide 301 - Tomasz Janiszewski On Oct. 18, 2017, 6:46 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 63314: Add support for Ubuntu 16.04 in docker build.

2017-10-29 Thread Tomasz Janiszewski
tu 16.04 but not > > in other versions? > > Tomasz Janiszewski wrote: > I'm not sure if we need it in 14.04. I follow instructions from [getting > started](http://mesos.apache.org/documentation/latest/building/#ubuntu-14-04) > and it looks like this are the only difference bet

Review Request 63379: Set max-size for a book thumbnail on the site.

2017-10-27 Thread Tomasz Janiszewski
in next row leaving a blank space. Diffs - site/source/assets/css/main.css d6ecb18f8c9ce785deee18cb9d131f021b6611f7 Diff: https://reviews.apache.org/r/63379/diff/1/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 63293: Update google-glog to 0.3.5.

2017-10-26 Thread Tomasz Janiszewski
e this PR. - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63293/#review189264 --- On Oct. 25, 2017, 12:28 p.m., Tom

Re: Review Request 63314: Add support for Ubuntu 16.04 in docker build.

2017-10-26 Thread Tomasz Janiszewski
tps://www.diffchecker.com/Aj4N9M8y - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63314/#review189278 ------- On Oct.

Re: Review Request 63314: Add support for Ubuntu 16.04 in docker build.

2017-10-26 Thread Tomasz Janiszewski
/ Changes: https://reviews.apache.org/r/63314/diff/1-2/ Testing --- Thanks, Tomasz Janiszewski

Review Request 63315: Allowe override of parallel jobs in docker build.

2017-10-25 Thread Tomasz Janiszewski
Description --- Use JOBS env variable to control `make -j` parameter. By default `JOBS=6`. Diffs - support/docker-build.sh 50e693ca71d499f71f2935923f4691feef560b12 Diff: https://reviews.apache.org/r/63315/diff/1/ Testing --- Thanks, Tomasz Janiszewski

Review Request 63314: Add support for Ubuntu 16.04 in docker build.

2017-10-25 Thread Tomasz Janiszewski
Description --- Add support for Ubuntu 16.04 in docker build. Diffs - support/docker-build.sh 50e693ca71d499f71f2935923f4691feef560b12 Diff: https://reviews.apache.org/r/63314/diff/1/ Testing --- Thanks, Tomasz Janiszewski

Review Request 63295: Update glog-0.3.3.patch to build on ARM.

2017-10-25 Thread Tomasz Janiszewski
an old version of config.guess this change updates it to the recent version that properly detects ARM architecture. Diffs - 3rdparty/glog-0.3.3.patch f1ed584cf12181307552c3c9429d31759be5de65 Diff: https://reviews.apache.org/r/63295/diff/1/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 63293: Update google-glog to 0.3.5.

2017-10-25 Thread Tomasz Janiszewski
ab15bea04d7b8af31a638b7c4ce3256ed2f0df4e Diff: https://reviews.apache.org/r/63293/diff/1/ Testing --- Thanks, Tomasz Janiszewski

Review Request 63293: Update google-glog to 0.3.5.

2017-10-25 Thread Tomasz Janiszewski
, Tomasz Janiszewski

Review Request 63294: Update glog patch (config.guess) to support ARM.

2017-10-25 Thread Tomasz Janiszewski
--- Thanks, Tomasz Janiszewski

Re: Review Request 63101: Upgrades jQuery used by Mesos WebUI to version 3.2.1.

2017-10-18 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63101/#review188472 --- Ship it! Ship It! - Tomasz Janiszewski On Oct. 18, 2017, 10

Re: Review Request 63102: Upgrades AngularJS used by Mesos WebUI to version 1.2.32.

2017-10-18 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63102/#review188471 --- Ship it! Ship It! - Tomasz Janiszewski On Oct. 18, 2017, 10

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

2017-06-20 Thread Tomasz Janiszewski
> On Maj 11, 2017, 8:35 rano, Tomasz Janiszewski wrote: > > src/webui/master/static/browse.html > > Lines 17-20 (original), 17-20 (patched) > > <https://reviews.apache.org/r/58874/diff/3/?file=1710161#file1710161line17> > > > > How about usign `` here

Re: Review Request 59796: Show used resources in per-framework page.

2017-06-05 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59796/#review176906 --- Ship it! Ship It! - Tomasz Janiszewski On Cze 5, 2017, 4:50

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

2017-05-11 Thread Tomasz Janiszewski
> On Maj 11, 2017, 8:35 rano, Tomasz Janiszewski wrote: > > src/webui/master/static/browse.html > > Lines 17-20 (original), 17-20 (patched) > > <https://reviews.apache.org/r/58874/diff/3/?file=1710161#file1710161line17> > > > > How about usign `` here

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

2017-05-11 Thread Tomasz Janiszewski
k like. ``` {{dir}} / ``` - Tomasz Janiszewski On Maj 8, 2017, 8:01 rano, haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 56193: Use Docker cpus instead of cpu_share if possible.

2017-05-06 Thread Tomasz Janiszewski
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56193/#review170223 ----------- On Lut 1, 2017, 10:31 po południu, Tomasz Janiszewski wrote: > > --

Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

2017-05-03 Thread Tomasz Janiszewski
> On Maj 1, 2017, 8:45 po południu, Tomasz Janiszewski wrote: > > src/webui/master/static/js/controllers.js > > Lines 1024 (patched) > > <https://reviews.apache.org/r/58872/diff/1/?file=1703827#file1703827line1024> > > > > It's not obious why we remov

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

2017-05-03 Thread Tomasz Janiszewski
> On Maj 1, 2017, 8:14 po południu, Tomasz Janiszewski wrote: > > src/webui/master/static/browse.html > > Line 17 (original), 17 (patched) > > <https://reviews.apache.org/r/58874/diff/1/?file=1703836#file1703836line17> > > > > Could you keep origina

Re: Review Request 58872: Ensured sandbox URI request reroute after fetched `$scope.state`.

2017-05-01 Thread Tomasz Janiszewski
start. Can you add a comment with clarification? - Tomasz Janiszewski On Kwi 29, 2017, 6:22 po południu, haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

Re: Review Request 58874: Stripped spaces between directory elements in WebUI.

2017-05-01 Thread Tomasz Janiszewski
this should be replaced with `visibility: hidden;`. With `font-size: 0;` there is different (smaller) padding then before the change. - Tomasz Janiszewski On Kwi 30, 2017, 4:29 rano, haosdent huang wrote: > > --- > This is an automatic

Re: Review Request 48291: Use varint comparator in replica log.

2017-03-11 Thread Tomasz Janiszewski
upgrading leveldb to 1.18 we could replace default byte-wise comparator with varint comparator. Diffs - src/log/leveldb.cpp 5310a123b0fb25f240429722b676fe46174cb2ce Diff: https://reviews.apache.org/r/48291/diff/3/ Testing --- `make check dist` on Ubuntu x64 Thanks, Tomasz

Re: Review Request 48291: Use varint comparator in replica log.

2017-02-25 Thread Tomasz Janiszewski
to 1.18 we could replace default byte-wise comparator with varint comparator. Diffs (updated) - src/log/leveldb.cpp 5310a123b0fb25f240429722b676fe46174cb2ce Diff: https://reviews.apache.org/r/48291/diff/ Testing --- `make check dist` on Ubuntu x64 Thanks, Tomasz Janiszewski

Re: Review Request 56847: Removed unnecessary leveldb build rules.

2017-02-20 Thread Tomasz Janiszewski
. Thanks, Tomasz Janiszewski

Re: Review Request 56847: Removed unnecessary leveldb build rules.

2017-02-20 Thread Tomasz Janiszewski
in leveldb and bypass build failures in macOS. Diffs - 3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9 Diff: https://reviews.apache.org/r/56847/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 56847: Removed unnecessary leveldb build rules.

2017-02-20 Thread Tomasz Janiszewski
unnecessary rules in leveldb and bypass build failures in macOS. Diffs - 3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9 Diff: https://reviews.apache.org/r/56847/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 56847: Remove unecessary leveldb build rule.

2017-02-20 Thread Tomasz Janiszewski
huang. Repository: mesos Description --- Remove unecessary leveldb build rule. Diffs (updated) - 3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9 Diff: https://reviews.apache.org/r/56847/diff/ Testing --- Thanks, Tomasz Janiszewski

Review Request 56847: Remove unecessary leveldb build rule.

2017-02-20 Thread Tomasz Janiszewski
--- Remove unecessary leveldb build rule. Diffs - 3rdparty/leveldb-1.19.patch e281e9572438d91de5746114f19aa339e732bcf9 Diff: https://reviews.apache.org/r/56847/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 51053: Update leveldb to 1.19.

2017-02-19 Thread Tomasz Janiszewski
: https://docs.google.com/document/d/1fv2OMvH6hVm6waacOejSrTJwUuDQeXlqqPDZjBmbcKU/edit?usp=sharing Thanks, Tomasz Janiszewski

Re: Review Request 51053: Update leveldb to 1.19.

2017-02-15 Thread Tomasz Janiszewski
://gist.github.com/janisz/c0cd248a796cd7f10254ddbc02e91872 Thanks, Tomasz Janiszewski

Re: Review Request 53741: Show maintainance schedule info in the WebUI.

2017-02-06 Thread Tomasz Janiszewski
n automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53741/#review164323 --- On Feb. 6, 2017, 9:29 a.m., Tomasz Janiszewski wrote: > > --- > This is an a

Re: Review Request 53741: Show maintainance schedule info in the WebUI.

2017-02-06 Thread Tomasz Janiszewski
/mesos_webui_maintenance_schedule.png) Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 entires schedule generated with [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853) Thanks, Tomasz Janiszewski

Review Request 56193: Use Docker cpus instead of cpu_share if possible.

2017-02-01 Thread Tomasz Janiszewski
b63b060ba1c1d39dc1702368cf667831edbd39bd Diff: https://reviews.apache.org/r/56193/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 48291: Use varint comparator in replica log.

2017-01-29 Thread Tomasz Janiszewski
to 1.18 we could replace default byte-wise comparator with varint comparator. Diffs (updated) - src/log/leveldb.cpp 5310a123b0fb25f240429722b676fe46174cb2ce Diff: https://reviews.apache.org/r/48291/diff/ Testing --- `make check dist` on Ubuntu x64 Thanks, Tomasz Janiszewski

Re: Review Request 48291: Use varint comparator in replica log.

2017-01-29 Thread Tomasz Janiszewski
default byte-wise comparator with varint comparator. Diffs - src/log/leveldb.cpp f389d74b123574665c611b46cb52e3dc7042b331 Diff: https://reviews.apache.org/r/48291/diff/ Testing --- `make check dist` on Ubuntu x64 Thanks, Tomasz Janiszewski

Re: Review Request 51053: Update leveldb to 1.19.

2017-01-29 Thread Tomasz Janiszewski
--- make -j 8 distcheck benchamrks: https://gist.github.com/janisz/c0cd248a796cd7f10254ddbc02e91872 Thanks, Tomasz Janiszewski

Re: Review Request 53741: Display maintainance info in the webui.

2017-01-29 Thread Tomasz Janiszewski
iew162986 --- On Jan. 29, 2017, 2:48 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 53741: Display maintainance info in the webui.

2017-01-29 Thread Tomasz Janiszewski
) Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 entires schedule generated with [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853) Thanks, Tomasz Janiszewski

Re: Review Request 53289: Updated favicon.ico.

2016-11-18 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53289/#review156315 --- Ship it! Ship It! - Tomasz Janiszewski On Oct. 30, 2016, 1

Re: Review Request 53288: Updated the brand in navbar to Mesos logo.

2016-11-18 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53288/#review156314 --- Ship it! Ship It! - Tomasz Janiszewski On Oct. 29, 2016, 4

Re: Review Request 53287: Overrided the default navbar color to match project website.

2016-11-18 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53287/#review156313 --- Ship it! Ship It! - Tomasz Janiszewski On Oct. 29, 2016, 4

Re: Review Request 53286: Applied material style in WebUI.

2016-11-18 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53286/#review156312 --- Ship it! Ship It! - Tomasz Janiszewski On Oct. 29, 2016, 4

Re: Review Request 53741: Display maintainance info in the webui.

2016-11-16 Thread Tomasz Janiszewski
. Perfomrance testing done with 500 entires schedule generated with [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853) Thanks, Tomasz Janiszewski

Re: Review Request 53741: Display maintainance info in the webui.

2016-11-16 Thread Tomasz Janiszewski
EATION > > Diff: https://reviews.apache.org/r/53741/diff/ > > > Testing > --- > > [Screenshot](https://issues.apache.org/jira/secure/attachment/12838845/mesos_webui_maintenance_schedule.png) > > Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 > entires schedule generated with > [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853) > > > Thanks, > > Tomasz Janiszewski > >

Re: Review Request 53741: Display maintainance info in the webui.

2016-11-15 Thread Tomasz Janiszewski
ps://reviews.apache.org/r/53741/#review155882 ------- On Nov. 15, 2016, 9:03 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 53741: Display maintainance info in the webui.

2016-11-15 Thread Tomasz Janiszewski
eviews.apache.org/r/53741/#review155931 --- On Nov. 15, 2016, 9:03 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 53741: Display maintainance info in the webui.

2016-11-15 Thread Tomasz Janiszewski
/mesos_webui_maintenance_schedule.png) Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 entires schedule generated with [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853) Thanks, Tomasz Janiszewski

Review Request 53741: Display maintainance info in the webui.

2016-11-14 Thread Tomasz Janiszewski
schedule generated with [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853) Thanks, Tomasz Janiszewski

Re: Review Request 49360: Supported TCP in health check.

2016-08-25 Thread Tomasz Janiszewski
tps://reviews.apache.org/r/49360/#comment213438> Will it work on all supported systems? src/health-check/health_checker.cpp (line 518) <https://reviews.apache.org/r/49360/#comment213439> `bash` appears in 3 places and may be extracted to constant. - Tomasz Janiszewski On Aug. 25, 201

Re: Review Request 51053: Update leveldb to 1.19.

2016-08-22 Thread Tomasz Janiszewski
> On Aug. 22, 2016, 2:29 a.m., Vinod Kone wrote: > > Have you also done compatibility tests mentioned in the ticket? > > Tomasz Janiszewski wrote: > No. It's minior upgrade from 1.18 to 1.19 but I can got thur > https://docs.

Re: Review Request 51053: Update leveldb to 1.19.

2016-08-22 Thread Tomasz Janiszewski
ing is OK. - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51053/#review146280 --- On Aug. 12, 2016, 11:17 p.m., Tomasz Janiszew

Re: Review Request 47324: Update leveldb to 1.18.

2016-08-17 Thread Tomasz Janiszewski
/) - Tomasz Janiszewski On Aug. 12, 2016, 4:58 p.m., Tomasz Janiszewski wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 51053: Update leveldb to 1.19.

2016-08-12 Thread Tomasz Janiszewski
://gist.github.com/janisz/c0cd248a796cd7f10254ddbc02e91872 Thanks, Tomasz Janiszewski

Re: Review Request 51053: Update leveldb to 1.19.

2016-08-12 Thread Tomasz Janiszewski
/ Testing --- make -j 8 distcheck benchamrks: https://gist.github.com/janisz/c0cd248a796cd7f10254ddbc02e91872 Thanks, Tomasz Janiszewski

Review Request 51053: Update leveldb to 1.19.

2016-08-12 Thread Tomasz Janiszewski
/c0cd248a796cd7f10254ddbc02e91872 Thanks, Tomasz Janiszewski

Re: Review Request 47324: Update leveldb to 1.18.

2016-08-12 Thread Tomasz Janiszewski
/diff/ Testing --- Tested on Ubuntu amd_64 need to test on PPC Thanks, Tomasz Janiszewski

Re: Review Request 47324: Update leveldb to 1.18.

2016-08-12 Thread Tomasz Janiszewski
: https://reviews.apache.org/r/47324/diff/ Testing --- Tested on Ubuntu amd_64 need to test on PPC Thanks, Tomasz Janiszewski

Re: Review Request 50981: Fix volumes help message example mistake.

2016-08-11 Thread Tomasz Janiszewski
--- Thanks, Tomasz Janiszewski

Review Request 50981: Fix volumes help message example mistake.

2016-08-11 Thread Tomasz Janiszewski
--- Changed docker_options to driver_options. Diffs - src/cli/execute.cpp b752d057a3d86482ef1a4baaf31052469e38dc76 Diff: https://reviews.apache.org/r/50981/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 50851: Decode Protobuf long int form strings.

2016-08-11 Thread Tomasz Janiszewski
- Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50851/#review145430 --- On Aug. 11, 2016, 8:47 a.m., Tomasz Janiszew

Re: Review Request 50851: Decode Protobuf long int form strings.

2016-08-11 Thread Tomasz Janiszewski
inst `Message` object. But since there is no equal method for protobuf object I serialise them to JSON. - Tomasz ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50851/#review145430 ---

Re: Review Request 50851: Decode Protobuf long int form strings.

2016-08-11 Thread Tomasz Janiszewski
) - 3rdparty/stout/include/stout/protobuf.hpp 91305e104c01d649bd435a27b15954036c27 3rdparty/stout/tests/protobuf_tests.cpp 8877e8934e0f7875bfedcfa88b491ce4b13ca44f Diff: https://reviews.apache.org/r/50851/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 50900: Removed unneeded extra space in libprocess code base.

2016-08-09 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50900/#review145191 --- Ship it! Ship It! - Tomasz Janiszewski On Aug. 8, 2016, 4

Re: Review Request 50899: Removed unneeded extra space in stout code base.

2016-08-09 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50899/#review145190 --- Ship it! Ship It! - Tomasz Janiszewski On Aug. 8, 2016, 4

Re: Review Request 50887: Trimmed unneeded extra space between right angle brackets.

2016-08-09 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50887/#review145189 --- Ship it! Ship It! - Tomasz Janiszewski On Aug. 8, 2016, 4

Review Request 50851: Decode Protobuf long int form strings.

2016-08-05 Thread Tomasz Janiszewski
8877e8934e0f7875bfedcfa88b491ce4b13ca44f Diff: https://reviews.apache.org/r/50851/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 50398: Added libz to Ubuntu build dependencies.

2016-07-28 Thread Tomasz Janiszewski
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50398/#review143863 --- On July 25, 2016, 5:39 p.m., Tomasz Janiszewski wrote: > > -

Review Request 50398: Added libz to Ubuntu build dependencies.

2016-07-25 Thread Tomasz Janiszewski
: mesos Description --- Added libz to Ubuntu build dependencies. Diffs - docs/getting-started.md ebe52705b8c8757d4a507ce3ae75f56d535a39d1 Diff: https://reviews.apache.org/r/50398/diff/ Testing --- Thanks, Tomasz Janiszewski

Review Request 50114: Added missing tables attributes in docs.

2016-07-17 Thread Tomasz Janiszewski
99 docs/modules.md 60191566cf3580792046ba21a6b9a66a21b18e21 Diff: https://reviews.apache.org/r/50114/diff/ Testing --- Thanks, Tomasz Janiszewski

Re: Review Request 49360: Supported TCP check in health check.

2016-07-16 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49360/#review142497 --- Ship it! Ship It! - Tomasz Janiszewski On July 2, 2016, 3

Re: Review Request 36816: Supported HTTP/HTTPS in health check.

2016-07-16 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review142496 --- Ship it! Ship It! - Tomasz Janiszewski On July 2, 2016, 3

Re: Review Request 48910: Group frameworks by state in the webui.

2016-06-27 Thread Tomasz Janiszewski
tomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/#review139696 ----------- On Cze 27, 2016, 7:19 po południu, Tomasz Janiszewski wrote: > > --- > This i

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

2016-06-27 Thread Tomasz Janiszewski
t directly from > > TASK_STAGING to TASK_LOST, i.e., a task was removed before any update for > > it was received by the master (e.g., agent removed). > > Tomasz Janiszewski wrote: > What is desired behaviour for this situation? Now start and stop time > will be equal.

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

2016-06-27 Thread Tomasz Janiszewski
be3fa1f1fba9eda7ebcc9bf33142fe4307dd8d90 Diff: https://reviews.apache.org/r/49228/diff/ Testing --- Generate orpahne tasks that is alive. It should have not set stopped time. Thanks, Tomasz Janiszewski

Re: Review Request 48910: Group frameworks by state in the webui.

2016-06-27 Thread Tomasz Janiszewski
> disconnected and active (doesn't make sense) > > disconnected and inactive > > Tomasz Janiszewski wrote: > I'm on latest master `git_sha: > "05b553ec6b0260547055fbc807ab3acce4ece234"`. There is no `disconnected` field > in frameworks returned by `/maste

Re: Review Request 48910: Group frameworks by state in the webui.

2016-06-27 Thread Tomasz Janiszewski
framework (e.g. Marathon) wait until it appear on `#/frameworks`. Stop it (no graceful shutdown with deregistration). It should be highlighted with next page update. Thanks, Tomasz Janiszewski

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

2016-06-27 Thread Tomasz Janiszewski
ll` when first status is terminal? - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/#review139622 ------- On June

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

2016-06-27 Thread Tomasz Janiszewski
be3fa1f1fba9eda7ebcc9bf33142fe4307dd8d90 Diff: https://reviews.apache.org/r/49228/diff/ Testing --- Generate orpahne tasks that is alive. It should have not set stopped time. Thanks, Tomasz Janiszewski

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

2016-06-27 Thread Tomasz Janiszewski
finetely it is. Fixed. - Tomasz --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/#review139606 --- On June 27, 2016, 5:

Re: Review Request 49228: Fixed wrong stopped time in webui for live tasks.

2016-06-27 Thread Tomasz Janiszewski
be3fa1f1fba9eda7ebcc9bf33142fe4307dd8d90 Diff: https://reviews.apache.org/r/49228/diff/ Testing --- Generate orpahne tasks that is alive. It should have not set stopped time. Thanks, Tomasz Janiszewski

  1   2   3   >