Re: Review Request 71742: Mesos agent shouldn't respond pings if no master is registered

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71742/ --- (Updated Nov. 22, 2019, 8 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 71742: Mesos agent shouldn't respond pings if no master is registered

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71742/ --- (Updated Nov. 19, 2019, 10:39 p.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 71742: Mesos agent shouldn't respond pings if no master is registered

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71742/ --- (Updated Nov. 13, 2019, 10:39 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 71742: Mesos agent shouldn't respond pings if no master is registered

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71742/ --- (Updated Nov. 13, 2019, 12:18 a.m.) Review request for mesos and Jiang Yan Xu.

Review Request 71742: Mesos agent responds pings only from currently registered master

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71742/ --- Review request for mesos. Bugs: MESOS-10032

Re: Review Request 71080: Master should store the list of completed framework ids for lifecycle.

> On July 24, 2019, 9:34 p.m., Jiang Yan Xu wrote: > > include/mesos/allocator/allocator.hpp > > Lines 66 (patched) > > > > > > `maxCompletedFrameworks` is used for the metrics to keep for completed > > frameworks

Re: Review Request 71080: Master should store the list of completed framework ids for lifecycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71080/ --- (Updated July 24, 2019, 11:10 p.m.) Review request for mesos, James Peach and

Re: Review Request 71080: Master should store the list of completed framework ids for lifecycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71080/ --- (Updated July 19, 2019, 3:10 a.m.) Review request for mesos, James Peach and

Re: Review Request 71080: Master should store the list of completed framework ids for lifecycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71080/ --- (Updated July 19, 2019, 12:09 a.m.) Review request for mesos, James Peach and

Re: Review Request 71080: Master should store the list of completed framework ids for lifecycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71080/ --- (Updated July 17, 2019, 6:58 p.m.) Review request for mesos, James Peach and

Review Request 71080: Master should store the list of completed framework ids for lifecycle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71080/ --- Review request for mesos, James Peach and Jiang Yan Xu. Bugs: MESOS-8636

Re: Review Request 70660: Fix the XFS build for recent Fedora versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70660/#review215330 --- Ship it! Ship It! - Xudong Ni On May 17, 2019, 2:24 a.m.,

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review211735 --- Ship it! Ship It! - Xudong Ni On Jan. 2, 2019, 5:15 p.m.,

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review211517 --- src/slave/containerizer/mesos/launch.cpp Lines 142 (patched)

Re: Review Request 68706: Added master failover reregistration progress metrics.

> On Oct. 15, 2018, 4:45 p.m., James Peach wrote: > > I think that we need test for this as well. At minimum, we ought to update > > `MasterTest.MetricsInMetricsEndpoint`. Best would be a test that registers > > a number of agents, then restarts the master and validates the metrics. Basic

Re: Review Request 68706: Added master failover reregistration progress metrics.

> On Oct. 18, 2018, 6:14 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Lines 1874-1875 (patched) > > > > > > If we use equality operator and only set the timer when such a number > > of reregistered

Re: Review Request 68706: Added master failover reregistration progress metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/ --- (Updated Oct. 19, 2018, 11:56 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68706: Added master failover reregistration progress metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/ --- (Updated Oct. 19, 2018, 11:14 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68706: Added master failover reregistration progress metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/ --- (Updated Oct. 16, 2018, 4:49 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68706: Added master failover reregistration progress metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/ --- (Updated Oct. 16, 2018, 4:19 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68706: Added master failover reregistration progress metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/ --- (Updated Oct. 10, 2018, 5:22 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68706: Added master failover reregistration progress metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/ --- (Updated Oct. 9, 2018, 11:24 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68706: Added master failover reregistration progress metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/ --- (Updated Oct. 9, 2018, 8:45 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68706: Added master failover reregistration progress metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/ --- (Updated Sept. 12, 2018, 9:42 p.m.) Review request for mesos, Benjamin Mahler,

Review Request 68706: Added master failover reregistration progress metrics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68706/ --- Review request for mesos. Bugs: MESOS-9178

Re: Review Request 68366: Added a custom port range option to the `network/ports` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/ --- (Updated Aug. 24, 2018, 10:54 p.m.) Review request for mesos and James Peach.

Re: Review Request 68366: Added a custom port range option to the `network/ports` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/ --- (Updated Aug. 23, 2018, 10:16 p.m.) Review request for mesos and James Peach.

Re: Review Request 68366: Added a custom port range option to the `network/ports` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/ --- (Updated Aug. 23, 2018, 2:56 a.m.) Review request for mesos and James Peach.

Re: Review Request 68366: Added agent protected port range option in network isolator.

> On Aug. 22, 2018, 7:27 p.m., James Peach wrote: > > Can you please update the commit comment to better describe the specific > > changes? > > > > Maybe something along these lines: > > > > ``` > > Added a custom port range option to the `network/ports` isolator. > > > > Added the

Re: Review Request 68366: Added agent protected port range option in network isolator.

> On Aug. 22, 2018, 11:50 p.m., James Peach wrote: > > I think this change broke the > > `NetworkPortsIsolatorTest.ROOT_NC_NoPortsResource` test, just regressing > > against master. Fixed it; There was an empty ports condition removed in one of iteration but didn't add back in the later

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/ --- (Updated Aug. 22, 2018, 5:35 p.m.) Review request for mesos and James Peach.

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/ --- (Updated Aug. 20, 2018, 9:53 p.m.) Review request for mesos and James Peach.

Re: Review Request 68366: Added agent protected port range option in network isolator.

> On Aug. 17, 2018, 10:02 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 343 (patched) > > > > > > `flags.container_ports_protected_range` is already an interval

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/ --- (Updated Aug. 17, 2018, 6:27 p.m.) Review request for mesos and James Peach.

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/ --- (Updated Aug. 17, 2018, 5:21 p.m.) Review request for mesos and James Peach.

Re: Review Request 68366: Added agent protected port range option in network isolator.

> On Aug. 16, 2018, 5:22 p.m., James Peach wrote: > > As per our offline discussion, I think that we can generalize this to make > > it consistent with the existing options. If we have the concept of a > > protected port range, then the existing features map to "protect all ports" > > and

Re: Review Request 68366: Added agent protected port range option in network isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/ --- (Updated Aug. 16, 2018, 9:28 p.m.) Review request for mesos and James Peach.

Review Request 68366: Added agent config option to allow ignoring ephemeral port range.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/ --- Review request for mesos and James Peach. Bugs: MESOS-9133

Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67365/#review204067 --- Ship it! Ship It! - Xudong Ni On May 30, 2018, 6:57 p.m.,

Re: Review Request 67365: Added MESOS-8340 to the 1.7.x CHANGELOG.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67365/#review204027 --- CHANGELOG Lines 8 (patched)

Re: Review Request 67271: Renamed an ambiguous variable in network port isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67271/ --- (Updated May 24, 2018, 9:57 p.m.) Review request for mesos and James Peach.

Re: Review Request 67195: Added enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/ --- (Updated May 24, 2018, 9:56 p.m.) Review request for mesos, James Peach and

Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

> On May 24, 2018, 8:30 p.m., James Peach wrote: > > Commit subject should be "Added ..." subject changed - Xudong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/#review203805

Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

> On May 24, 2018, 5:58 p.m., Gilbert Song wrote: > > we need to update `configure.md` correspondingly. Updated configuration/agent.md - Xudong --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 67271: Renamed an ambiguous variable in network port isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67271/ --- (Updated May 24, 2018, 6:17 p.m.) Review request for mesos and James Peach.

Re: Review Request 67271: Change ambiguous parameter name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67271/ --- (Updated May 23, 2018, 6:42 p.m.) Review request for mesos and James Peach.

Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/ --- (Updated May 23, 2018, 6:33 p.m.) Review request for mesos, James Peach and

Re: Review Request 67271: Change ambiguous parameter name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67271/ --- (Updated May 23, 2018, 6:32 p.m.) Review request for mesos and James Peach.

Review Request 67271: Change ambiguous parameter name.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67271/ --- Review request for mesos and James Peach. Bugs: MESOS-8340

Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/ --- (Updated May 23, 2018, 5:57 p.m.) Review request for mesos, James Peach and

Review Request 67244: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67244/ --- Review request for mesos. Repository: mesos Description --- To reduce

Re: Review Request 67244: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67244/ --- (Updated May 22, 2018, 4:02 a.m.) Review request for mesos, James Peach and

Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

> On May 21, 2018, 8:56 p.m., James Peach wrote: > > src/slave/containerizer/mesos/isolators/network/ports.cpp > > Lines 577 (patched) > > > > > > This is more complicated than it needs to be. You can simply do

Re: Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/ --- (Updated May 21, 2018, 4:14 p.m.) Review request for mesos, James Peach and

Review Request 67195: Adding enforce_container_ports flag for network ports isolation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67195/ --- Review request for mesos, James Peach and Jiang Yan Xu. Bugs: mesos-8340

Re: Review Request 66919: Failure to update registry should abort the master process.

> On May 8, 2018, 12:08 a.m., Jiang Yan Xu wrote: > > src/master/http.cpp > > Lines 4163 (patched) > > > > > > You missed a space between `result)` and `{` which I didn't catch > > initially but fixed up in a

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/ --- (Updated May 7, 2018, 6:10 p.m.) Review request for mesos, Joseph Wu and Jiang

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/ --- (Updated May 7, 2018, 5:20 p.m.) Review request for mesos, Joseph Wu and Jiang

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/ --- (Updated May 7, 2018, 4:54 p.m.) Review request for mesos, Joseph Wu and Jiang

Re: Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/ --- (Updated May 2, 2018, 9:38 p.m.) Review request for mesos. Bugs: MESOS-8630

Review Request 66919: Failure to update registry should abort the master process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66919/ --- Review request for mesos. Bugs: MESOS-8630