---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36360/#review91782
---
Ship it!
src/common/http.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36360/
---
(Updated July 15, 2015, 2:50 a.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36360/#review91280
---
src/common/http.hpp (lines 52 - 53)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36360/#review91204
---
Patch looks great!
Reviews applied: [36360]
All tests passed.
-
On July 9, 2015, 8:23 p.m., Anand Mazumdar wrote:
src/common/http_constants.cpp, line 26
https://reviews.apache.org/r/36360/diff/1/?file=1003774#file1003774line26
minor nit-pick , might consider using std::string; before-hand ?
:) done
- Isabel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36360/
---
(Updated July 9, 2015, 9:07 p.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36360/#review91205
---
Can you move this into the existing common/http.hpp, and remove the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36360/#review91178
---
Ship it!
LGTM, Just some minor comments.
On July 9, 2015, 9:32 p.m., Ben Mahler wrote:
Can you move this into the existing common/http.hpp, and remove the content
type one? For content type, would rather see a typed member on
Request/Response than constants here, given the other occurrences:
```
? mesos git:(master) ?
On July 9, 2015, 9:32 p.m., Ben Mahler wrote:
Can you move this into the existing common/http.hpp, and remove the content
type one? For content type, would rather see a typed member on
Request/Response than constants here, given the other occurrences:
```
? mesos git:(master) ?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36360/#review91241
---
Patch looks great!
Reviews applied: [36360]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36360/#review91242
---
Ship it!
Ship It!
- Marco Massenzio
On July 9, 2015, 10:34
12 matches
Mail list logo