Re: Review Request 36360: Adding common constants for HTTP API

2015-07-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36360/#review91782 --- Ship it! src/common/http.hpp

Re: Review Request 36360: Adding common constants for HTTP API

2015-07-14 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36360/ --- (Updated July 15, 2015, 2:50 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 36360: Adding common constants for HTTP API

2015-07-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36360/#review91280 --- src/common/http.hpp (lines 52 - 53)

Re: Review Request 36360: Adding common constants for HTTP API

2015-07-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36360/#review91204 --- Patch looks great! Reviews applied: [36360] All tests passed. -

Re: Review Request 36360: Adding common constants for HTTP API

2015-07-09 Thread Isabel Jimenez
On July 9, 2015, 8:23 p.m., Anand Mazumdar wrote: src/common/http_constants.cpp, line 26 https://reviews.apache.org/r/36360/diff/1/?file=1003774#file1003774line26 minor nit-pick , might consider using std::string; before-hand ? :) done - Isabel

Re: Review Request 36360: Adding common constants for HTTP API

2015-07-09 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36360/ --- (Updated July 9, 2015, 9:07 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 36360: Adding common constants for HTTP API

2015-07-09 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36360/#review91205 --- Can you move this into the existing common/http.hpp, and remove the

Re: Review Request 36360: Adding common constants for HTTP API

2015-07-09 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36360/#review91178 --- Ship it! LGTM, Just some minor comments.

Re: Review Request 36360: Adding common constants for HTTP API

2015-07-09 Thread Isabel Jimenez
On July 9, 2015, 9:32 p.m., Ben Mahler wrote: Can you move this into the existing common/http.hpp, and remove the content type one? For content type, would rather see a typed member on Request/Response than constants here, given the other occurrences: ``` ? mesos git:(master) ?

Re: Review Request 36360: Adding common constants for HTTP API

2015-07-09 Thread Marco Massenzio
On July 9, 2015, 9:32 p.m., Ben Mahler wrote: Can you move this into the existing common/http.hpp, and remove the content type one? For content type, would rather see a typed member on Request/Response than constants here, given the other occurrences: ``` ? mesos git:(master) ?

Re: Review Request 36360: Adding common constants for HTTP API

2015-07-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36360/#review91241 --- Patch looks great! Reviews applied: [36360] All tests passed. -

Re: Review Request 36360: Adding common constants for HTTP API

2015-07-09 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36360/#review91242 --- Ship it! Ship It! - Marco Massenzio On July 9, 2015, 10:34