Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38755/ --- (Updated Sept. 26, 2015, 10:05 p.m.) Review request for mesos, Artem

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

> On Sept. 25, 2015, 7:07 a.m., Alex Clemmer wrote: > > cmake/CompilationConfigure.cmake, line 97 > > > > > > Oh yeah. I forgot to remove these. I don't actually know what > > `pkglibexecdir` does in autoconf; I'll

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38755/#review100637 --- cmake/CompilationConfigure.cmake (line 84)

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38755/#review100618 --- Ship it! cmake/CompilationConfigure.cmake (line 46)

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

> On Sept. 25, 2015, 11:05 a.m., Artem Harutyunyan wrote: > > LGTM. - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38755/#review100637

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38755/ --- (Updated Sept. 25, 2015, 10:13 p.m.) Review request for mesos, Artem

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

> On Sept. 25, 2015, 6:05 p.m., Artem Harutyunyan wrote: > > cmake/CompilationConfigure.cmake, line 84 > > > > > > NOLINT? Doesn't complain on my box, I don't think it's necessary. Also, this _does_ run when you

Re: Review Request 38755: CMake: Move compiler configuration logic to its own file.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38755/#review100554 --- cmake/CompilationConfigure.cmake (line 97)