Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/#review108903 --- Ship it! Ship It! - Vinod Kone On Dec. 2, 2015, 10:41 p.m.,

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/#review108391 --- I see a very basic test in the next review. Are you planning to

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

> On Dec. 2, 2015, 10:24 p.m., Vinod Kone wrote: > > I see a very basic test in the next review. Are you planning to write more > > comprehensive tests? Is that plan to templatize slave recovery tests for > > both pid based and http executors? For now, I added just a basic test for testing

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- (Updated Dec. 2, 2015, 10:41 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- (Updated Nov. 30, 2015, 3:56 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- (Updated Nov. 10, 2015, 2:27 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- (Updated Nov. 7, 2015, 1:07 a.m.) Review request for mesos, Ben Mahler, Isabel

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- (Updated Oct. 22, 2015, 8:48 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- (Updated Oct. 23, 2015, 1:39 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- (Updated Oct. 22, 2015, 5:53 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- (Updated Oct. 20, 2015, 7:06 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- (Updated Oct. 16, 2015, 6:43 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/#review101615 --- src/slave/slave.cpp (line 2420)

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/#review101614 --- src/slave/slave.cpp (line 2479)

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

> On Oct. 6, 2015, 1:04 a.m., haosdent huang wrote: > > src/slave/slave.cpp, line 2389 > > > > > > I think just print a number is not easy to understand when troubleshoot > > error happens. > > Anand Mazumdar

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

> On Oct. 6, 2015, 6:35 a.m., haosdent huang wrote: > > src/slave/slave.cpp, line 2420 > > > > > > Should use return here directly instead of break? What is the advantage of one over the other here ? I was being

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

> On Oct. 6, 2015, 1:04 a.m., haosdent huang wrote: > > src/slave/slave.cpp, line 2389 > > > > > > I think just print a number is not easy to understand when troubleshoot > > error happens. Can you elaborate a

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

> On Oct. 6, 2015, 6:20 a.m., haosdent huang wrote: > > src/slave/slave.cpp, line 2479 > > > > > > Seems this line is incomplete. It was intentionally left this way to avoid warning as error issues. This would be

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/#review101568 --- src/slave/slave.cpp (line 96)

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/#review101565 --- Ship it! Ship It! - Isabel Jimenez On Sept. 30, 2015, 6:06

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/ --- (Updated Sept. 30, 2015, 6:06 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/#review101085 --- Ship it! Ship It! - Guangya Liu On 九月 30, 2015, 6:06 a.m.,

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

> On 九月 30, 2015, 5:41 a.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 2387 > > > > > > How to handle the case if executor is in RECOVRING state? The logic is > > different for register and reregister with

Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38877/#review101077 --- src/slave/slave.hpp (line 169)