Re: Review Request 39837: Passing os environment variables when start docker executor.

2015-11-02 Thread Jojy Varghese
> On Nov. 1, 2015, 5:56 p.m., Jojy Varghese wrote: > > How did you test this? Could you please elaborate the test steps? Or even > > better - add a test case? > > haosdent huang wrote: > Need add a test case. Thanks haosdent. Shout if you need help. - Jojy

Re: Review Request 39837: Passing os environment variables when start docker executor.

2015-11-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39837/#review104655 --- Patch looks great! Reviews applied: [39837] All tests passed. -

Re: Review Request 39837: Passing os environment variables when start docker executor.

2015-11-01 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39837/#review104660 --- src/slave/containerizer/docker.cpp

Re: Review Request 39837: Passing os environment variables when start docker executor.

2015-11-01 Thread Jojy Varghese
> On Nov. 1, 2015, 4:29 p.m., Timothy Chen wrote: > > src/slave/containerizer/docker.cpp, line 302 > > > > > > We intentionally exclude os enviornments as you can see here for a > > reason. > > > > There

Re: Review Request 39837: Passing os environment variables when start docker executor.

2015-11-01 Thread haosdent huang
> On Nov. 1, 2015, 4:29 p.m., Timothy Chen wrote: > > src/slave/containerizer/docker.cpp, line 302 > > > > > > We intentionally exclude os enviornments as you can see here for a > > reason. > > > > There

Re: Review Request 39837: Passing os environment variables when start docker executor.

2015-11-01 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39837/#review104665 --- How did you test this? Could you please elaborate the test steps?

Re: Review Request 39837: Passing os environment variables when start docker executor.

2015-11-01 Thread haosdent huang
> On Nov. 1, 2015, 5:56 p.m., Jojy Varghese wrote: > > How did you test this? Could you please elaborate the test steps? Or even > > better - add a test case? Need add a test case. - haosdent --- This is an automatically generated

Re: Review Request 39837: Passing os environment variables when start docker executor.

2015-11-01 Thread haosdent huang
> On Nov. 1, 2015, 4:29 p.m., Timothy Chen wrote: > > src/slave/containerizer/docker.cpp, line 302 > > > > > > We intentionally exclude os enviornments as you can see here for a > > reason. > > > > There