Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/#review108653 --- src/master/http.cpp (lines 1034 - 1037)

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/#review108639 --- src/master/master.hpp (lines 1089 - 1094)

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

> On Dec. 2, 2015, 3:05 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, lines 1035-1038 > > > > > > Let's leave a comment here, that `principal` matches > > `reservation().principal()` for each resource

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

> On Dec. 2, 2015, 2:26 p.m., Alexander Rukletsov wrote: > > src/master/master.hpp, lines 1089-1095 > > > > > > Do you want to do this cleanup as a separate patch? I believe we tend > > not to conflate semantic

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/ --- (Updated Dec. 2, 2015, 7:53 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

> On Dec. 2, 2015, 3:05 p.m., Alexander Rukletsov wrote: > > src/master/http.cpp, lines 1035-1038 > > > > > > Let's leave a comment here, that `principal` matches > > `reservation().principal()` for each resource

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/ --- (Updated Dec. 2, 2015, 10:47 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

> On Nov. 30, 2015, 9:44 p.m., Jie Yu wrote: > > src/master/http.cpp, line 2313 > > > > > > Instead of adding a new parameter to `_operation`. Can we put the > > logics of checking authorization result to

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/#review108510 --- src/master/http.cpp (lines 1037 - 1040)

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/#review108397 --- src/master/http.cpp (line 2255)

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/ --- (Updated Nov. 30, 2015, 8:46 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/#review107279 --- Ship it! Ship It! - Jie Yu On Nov. 19, 2015, 11:41 p.m., Greg

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

> On Nov. 13, 2015, 11:38 p.m., Jie Yu wrote: > > src/master/http.cpp, line 853 > > > > > > This looks problematic to me. 'this' will become invalid once this > > function returns. That means when `_reserve` is

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/ --- (Updated Nov. 19, 2015, 11:41 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

> On Nov. 13, 2015, 11:38 p.m., Jie Yu wrote: > > src/master/http.cpp, line 853 > > > > > > This looks problematic to me. 'this' will become invalid once this > > function returns. That means when `_reserve` is

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/ --- (Updated Nov. 16, 2015, 11:53 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/ --- (Updated Nov. 13, 2015, 11:16 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/#review106526 --- src/master/http.cpp (line 853)

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

> On Nov. 13, 2015, 11:38 p.m., Jie Yu wrote: > > src/master/http.cpp, line 853 > > > > > > This looks problematic to me. 'this' will become invalid once this > > function returns. That means when `_reserve` is

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/ --- (Updated Nov. 14, 2015, 12:01 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/ --- (Updated Nov. 13, 2015, 4:32 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/ --- (Updated Nov. 9, 2015, 5:26 p.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/#review105599 --- Ship it! Ship It! - Guangya Liu On 十一月 7, 2015, 1:48 a.m.,

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

> On Nov. 6, 2015, 8:03 a.m., Guangya Liu wrote: > > src/tests/reservation_endpoints_tests.cpp, lines 874-877 > > > > > > remove this Ahh, sorry!! Thanks Guangya :-) - Greg

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/#review105547 --- src/master/master.hpp (line 981)

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

> On Nov. 7, 2015, 1:16 a.m., Neil Conway wrote: > > src/master/master.hpp, line 981 > > > > > > Should update the comment for new function parameter. Derp. Thanks Neil! - Greg

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/ --- (Updated Nov. 7, 2015, 1:48 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39988/#review105380 --- src/tests/reservation_endpoints_tests.cpp (lines 871 - 874)