Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-12-03 Thread Benjamin Bannier
> On Dec. 3, 2015, 1:05 p.m., Bernd Mathiske wrote: > > src/tests/fetcher_tests.cpp, line 543 > > > > > > Since both ExtractNotExecutable and ExtractTar dio the same now one of > > these tests is redundant and can

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-12-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40776/ --- (Updated Dec. 3, 2015, 2:33 p.m.) Review request for mesos, Bernd Mathiske and

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-12-03 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40776/#review108816 --- src/tests/fetcher_tests.cpp (line 543)

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-12-03 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40776/#review108831 --- Ship it! Ship It! - Bernd Mathiske On Dec. 3, 2015, 6:33 a.m.,

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-11-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40776/#review108257 --- Patch looks great! Reviews applied: [40776] Passed command:

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-11-28 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40776/ --- (Updated Nov. 28, 2015, 11:15 a.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-11-28 Thread Benjamin Bannier
> On Nov. 27, 2015, 9:53 p.m., Till Toenshoff wrote: > > src/tests/fetcher_cache_tests.cpp, lines 325-326 > > > > > > Let's add a reference to the JIRA describing the issue in more detail > > -- here and also in

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-11-27 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40776/ --- (Updated Nov. 27, 2015, 6:11 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-11-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40776/#review108245 --- Patch looks great! Reviews applied: [40776] Passed command:

Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.

2015-11-27 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40776/#review108246 --- Ship it! Thanks for this Benjamin - really made sense to