Re: Review Request 41772: Added helper function to flatten resources.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 三月 12, 2016, 2:46 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41772: Added helper function to flatten resources.

2016-03-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 三月 11, 2016, 9:10 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41772: Added helper function to flatten resources.

2016-02-28 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 二月 29, 2016, 7:08 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-25 Thread Klaus Ma
> On Jan. 20, 2016, 6:18 a.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter type

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-25 Thread Guangya Liu
> On Jan. 19, 2016, 10:18 p.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-25 Thread Joseph Wu
> On Jan. 19, 2016, 2:18 p.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter type

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-23 Thread Guangya Liu
> On 一月 19, 2016, 10:18 p.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter type

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-23 Thread Klaus Ma
> On Jan. 20, 2016, 6:18 a.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter type

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 一月 23, 2016, 2:17 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 一月 23, 2016, 2:59 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-22 Thread Guangya Liu
> On 一月 19, 2016, 10:18 p.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter type

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-20 Thread Guangya Liu
> On 一月 19, 2016, 10:18 p.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter type

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-20 Thread Guangya Liu
> On 一月 19, 2016, 10:18 p.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 874-877 > > > > > > This is pretty much a copy of `Resources::reserved` now. You can > > remove it. > > Guangya Liu wrote: >

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-20 Thread Joseph Wu
> On Jan. 19, 2016, 2:18 p.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 874-877 > > > > > > This is pretty much a copy of `Resources::reserved` now. You can > > remove it. > > Guangya Liu wrote: >

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-20 Thread Guangya Liu
> On 一月 19, 2016, 10:18 p.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter type

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-19 Thread Guangya Liu
> On 一月 19, 2016, 10:18 p.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 874-877 > > > > > > This is pretty much a copy of `Resources::reserved` now. You can > > remove it. The reason that I keep this

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 一月 20, 2016, 3:40 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-19 Thread Klaus Ma
> On Jan. 20, 2016, 6:18 a.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 874-877 > > > > > > This is pretty much a copy of `Resources::reserved` now. You can > > remove it. > > Guangya Liu wrote: >

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-19 Thread Klaus Ma
> On Jan. 20, 2016, 6:18 a.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter type

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-19 Thread Klaus Ma
> On Jan. 20, 2016, 6:18 a.m., Joseph Wu wrote: > > src/common/resources.cpp, line 880 > > > > > > It should be fine to just name this `flatten`. > > > > You should also consider changing the parameter type

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-17 Thread Klaus Ma
> On Jan. 7, 2016, 8:31 a.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 894-904 > > > > > > This seems more appropriate as an optional parameter for > > `Resources::flatten`, just like `Option`. > >

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 一月 16, 2016, 4:23 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-15 Thread Guangya Liu
> On 一月 7, 2016, 12:31 a.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 894-904 > > > > > > This seems more appropriate as an optional parameter for > > `Resources::flatten`, just like `Option`. > >

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-13 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 一月 13, 2016, 12:16 p.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-13 Thread Klaus Ma
> On Jan. 7, 2016, 8:31 a.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 894-904 > > > > > > This seems more appropriate as an optional parameter for > > `Resources::flatten`, just like `Option`. > >

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-13 Thread Guangya Liu
> On 一月 7, 2016, 12:31 a.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 894-904 > > > > > > This seems more appropriate as an optional parameter for > > `Resources::flatten`, just like `Option`. > >

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-13 Thread Klaus Ma
> On Jan. 7, 2016, 8:31 a.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 894-904 > > > > > > This seems more appropriate as an optional parameter for > > `Resources::flatten`, just like `Option`. > >

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-07 Thread Guangya Liu
> On 一月 7, 2016, 12:31 a.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 880-891 > > > > > > Does this give you more value than something like this? > > ``` > >

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 一月 7, 2016, 10:52 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-07 Thread Guangya Liu
> On 一月 7, 2016, 12:31 a.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 880-891 > > > > > > Does this give you more value than something like this? > > ``` > >

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-07 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 一月 8, 2016, 6:46 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-07 Thread Joseph Wu
> On Jan. 6, 2016, 4:31 p.m., Joseph Wu wrote: > > src/common/resources.cpp, lines 880-891 > > > > > > Does this give you more value than something like this? > > ``` > >

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/#review113153 --- include/mesos/resources.hpp (lines 267 - 275)

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 一月 3, 2016, 9:42 a.m.) Review request for mesos, Ben Mahler, Artem

Re: Review Request 41772: Added helper function to flatten resources.

2016-01-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/ --- (Updated 一月 2, 2016, 1:16 a.m.) Review request for mesos, Ben Mahler, Artem