Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

2016-02-16 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 16, 2016, 5:55 p.m.) Review request for mesos and Bernd

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

2016-02-16 Thread haosdent huang
> On Feb. 16, 2016, 11:02 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 422 > > > > > > In some fetcher cache tests, we specifically want to find out if > > concurrent execution of

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

2016-02-16 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119293 --- src/tests/fetcher_cache_tests.cpp (line 422)

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

2016-02-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review118439 --- Bad patch! Reviews applied: [42696] Failed command:

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

2016-02-09 Thread haosdent huang
> On Feb. 10, 2016, 3:39 a.m., Guangya Liu wrote: > > src/tests/fetcher_cache_tests.cpp, line 424 > > > > > > Can you introduce a new member variable named as `master flags` and get > > the allocation interval from

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

2016-02-09 Thread haosdent huang
> On Feb. 10, 2016, 4:12 a.m., Guangya Liu wrote: > > src/tests/fetcher_cache_tests.cpp, line 64 > > > > > > Do you need the DEFAULT_ALLOCATION_INTERVAL namespace? `using > >

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

2016-02-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 10, 2016, 1:42 a.m.) Review request for mesos and Bernd

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

2016-02-09 Thread Guangya Liu
> On 二月 10, 2016, 3:39 a.m., Guangya Liu wrote: > > src/tests/fetcher_cache_tests.cpp, line 424 > > > > > > Can you introduce a new member variable named as `master flags` and get > > the allocation interval from

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

2016-02-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review118566 --- Patch looks great! Reviews applied: [42696, 43316, 43367]

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

2016-02-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 10, 2016, 4:01 a.m.) Review request for mesos and Bernd

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

2016-02-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review118576 --- src/tests/fetcher_cache_tests.cpp (line 64)

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

2016-02-09 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 10, 2016, 4:17 a.m.) Review request for mesos and Bernd

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

2016-02-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review118563 --- src/tests/fetcher_cache_tests.cpp (lines 193 - 195)

Re: Review Request 43367: Speed up FetcherCache test cases by advance allocation_interval.

2016-02-09 Thread haosdent huang
> On Feb. 10, 2016, 3:39 a.m., Guangya Liu wrote: > > src/tests/fetcher_cache_tests.cpp, line 424 > > > > > > Can you introduce a new member variable named as `master flags` and get > > the allocation interval from