Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

2016-03-13 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/ --- (Updated March 13, 2016, 1:29 p.m.) Review request for mesos, Adam B and Neil

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

2016-03-13 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/#review123309 --- Fix it, then Ship it! Looks great. Fix it, then I'll commit.

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

2016-03-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/ --- (Updated March 7, 2016, 8:14 p.m.) Review request for mesos, Adam B and Neil

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

2016-03-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/ --- (Updated March 7, 2016, 8:13 p.m.) Review request for mesos, Adam B and Neil

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

2016-03-07 Thread Joerg Schad
> On Feb. 24, 2016, 7:57 a.m., Adam B wrote: > > docs/app-framework-development-guide.md, lines 137-139 > > > > > > Let's be very explicit that they'll need to instantiate a > > MesosSchedulerDriver and call these

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

2016-03-07 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/ --- (Updated March 7, 2016, 8:05 p.m.) Review request for mesos, Adam B and Neil

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

2016-03-07 Thread Joerg Schad
> On Feb. 24, 2016, 7:57 a.m., Adam B wrote: > > docs/app-framework-development-guide.md, line 144 > > > > > > Get rid of the `virtual` and `= 0` since that's not a part of the API > > that their scheduler will

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

2016-03-07 Thread Adam B
> On Feb. 21, 2016, 7:20 p.m., Guangya Liu wrote: > > docs/app-framework-development-guide.md, line 135 > > > > > > Why not merge this and above `Scheduler API` into one section? > > Joerg Schad wrote: > I

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

2016-02-23 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/#review120465 --- Great work. Still missing a bit of context about what a

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

2016-02-23 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/#review120356 --- Fix it, then Ship it! docs/app-framework-development-guide.md

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

2016-02-22 Thread Guangya Liu
> On 二月 22, 2016, 3:20 a.m., Guangya Liu wrote: > > docs/app-framework-development-guide.md, line 135 > > > > > > Why not merge this and above `Scheduler API` into one section? > > Joerg Schad wrote: > I wanted

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

2016-02-22 Thread Joerg Schad
> On Feb. 22, 2016, 3:20 a.m., Guangya Liu wrote: > > docs/app-framework-development-guide.md, line 135 > > > > > > Why not merge this and above `Scheduler API` into one section? I wanted to keep the Scheduler API

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

2016-02-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/#review120130 --- Patch looks great! Reviews applied: [43819] Passed command:

Re: Review Request 43819: Added Scheduler-Driver API to app-framework-development-guide.md.

2016-02-21 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43819/#review120091 --- docs/app-framework-development-guide.md (line 17)