Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/#review124967 --- Thanks! I'll make the adjustments from the comments below, please

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated March 21, 2016, 12:08 p.m.) Review request for mesos, Alexander

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated March 15, 2016, 3:52 p.m.) Review request for mesos, Alexander

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/#review122055 --- Fix it, then Ship it!

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated March 3, 2016, 5:17 p.m.) Review request for mesos, Alexander

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated March 3, 2016, 2:32 p.m.) Review request for mesos, Alexander

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated March 2, 2016, 4:43 p.m.) Review request for mesos, Alexander

Re: Review Request 43882: Added allocation metrics for allocation time.

> On March 1, 2016, 12:48 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2577 > > > > > > Why don't you need to convert to `JSON::Number` first? `time` is a `JSON::Number`;

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated March 2, 2016, 11:34 a.m.) Review request for mesos, Alexander

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/#review121406 --- src/master/allocator/mesos/hierarchical.cpp (lines 1216 - 1219)

Re: Review Request 43882: Added allocation metrics for allocation time.

> On Feb. 27, 2016, 2:11 a.m., Alexander Rojas wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 360 > > > > > > There is a second parameter in the `Timer` object which allows you to > > specify a

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated Feb. 29, 2016, 8:59 p.m.) Review request for mesos, Alexander

Re: Review Request 43882: Added allocation metrics for allocation time.

> On Feb. 27, 2016, 2:11 a.m., Alexander Rojas wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1220 > > > > > > Add a `CHECK_NOT_NULL` > > Benjamin Bannier wrote: > `timer` is initialized from a

Re: Review Request 43882: Added allocation metrics for allocation time.

> On Feb. 25, 2016, 5:47 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1207 > > > > > > It seems a general functional class, can we move it into > > `process/metrics`? I currently

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated Feb. 28, 2016, 10:28 p.m.) Review request for mesos, Alexander

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/#review121029 --- src/master/allocator/mesos/hierarchical.hpp (line 360)

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated Feb. 26, 2016, 6:01 p.m.) Review request for mesos, Alexander

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/#review120718 --- src/master/allocator/mesos/hierarchical.cpp (line 1207)

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated Feb. 25, 2016, 12:37 p.m.) Review request for mesos, Alexander

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated Feb. 25, 2016, 12:01 p.m.) Review request for mesos, Alexander

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated Feb. 24, 2016, 11:49 a.m.) Review request for mesos, Alexander

Re: Review Request 43882: Added allocation metrics for allocation time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43882/ --- (Updated Feb. 24, 2016, 11:23 a.m.) Review request for mesos, Alexander