Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/#review123211 --- Ship it! Ship It! - Vinod Kone On March 11, 2016, 1:47

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-11 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/ --- (Updated March 11, 2016, 2:47 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-11 Thread Alexander Rojas
> On March 10, 2016, 10:06 p.m., Vinod Kone wrote: > > src/Makefile.am, line 158 > > > > > > any reason why this should be exposed in the include directory? > > Alexander Rojas wrote: > Main reason is because

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-10 Thread Alexander Rojas
> On March 10, 2016, 10:06 p.m., Vinod Kone wrote: > > src/Makefile.am, line 158 > > > > > > any reason why this should be exposed in the include directory? Main reason is because of this `static Try

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/#review122988 --- src/Makefile.am (line 158)

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-10 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/ --- (Updated March 10, 2016, 3:09 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-10 Thread Alexander Rojas
> On March 10, 2016, 10:14 a.m., Adam B wrote: > > src/authorizer/authorizer.cpp, lines 43-44 > > > > > > Double-blank line between impls, please screw up while rebasing. - Alexander

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-10 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/#review122902 --- Fix it, then Ship it! Looks good. Just some alpha-order nits,

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-09 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/ --- (Updated March 9, 2016, 3:07 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-08 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/ --- (Updated March 9, 2016, 6:35 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-08 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/ --- (Updated March 9, 2016, 5:58 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44320: Moved authorizer.proto to acls.proto.

2016-03-08 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44320/ --- (Updated March 8, 2016, 5:44 p.m.) Review request for mesos, Adam B, Joerg