Re: Review Request 45008: Moved command scheduler to use the scheduler library.

2016-03-29 Thread Vinod Kone
> On March 18, 2016, 5:34 a.m., Guangya Liu wrote: > > src/cli/execute.cpp, line 456 > > > > > > Can you please add some comments here for why `devolve`here? > > > > Do we have plan to update all `status`

Re: Review Request 45008: Moved command scheduler to use the scheduler library.

2016-03-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45008/#review125974 --- Ship it! Ship It! - Vinod Kone On March 28, 2016, 10:32

Re: Review Request 45008: Moved command scheduler to use the scheduler library.

2016-03-28 Thread Anand Mazumdar
> On March 28, 2016, 9:39 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, lines 245-266 > > > > > > The semantics of stop() are a bit hard to intuit. > > > > How about we have two methods > > -

Re: Review Request 45008: Moved command scheduler to use the scheduler library.

2016-03-28 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45008/ --- (Updated March 28, 2016, 10:32 p.m.) Review request for mesos, Guangya Liu and

Re: Review Request 45008: Moved command scheduler to use the scheduler library.

2016-03-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45008/#review125753 --- src/cli/execute.cpp (lines 45 - 47)

Re: Review Request 45008: Moved command scheduler to use the scheduler library.

2016-03-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45008/#review124147 --- src/cli/execute.cpp (line 448)