Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45800/#review127684 --- Bad patch! Reviews applied: [45800, 45799, 45440, 45067] Failed

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-07 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45800/ --- (Updated April 7, 2016, 9:50 p.m.) Review request for mesos, Joseph Wu and

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45800/#review127670 --- Bad patch! Reviews applied: [45800, 45799, 45440, 45067] Failed

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-07 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45800/#review127665 --- Fix it, then Ship it! src/examples/long_lived_framework.cpp

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-07 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45800/ --- (Updated April 7, 2016, 9:24 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45800/#review127501 --- Bad patch! Reviews applied: [45800, 45799, 45440, 45067] Failed

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-06 Thread Joseph Wu
> On April 6, 2016, 10:10 a.m., Joseph Wu wrote: > > src/examples/long_lived_framework.cpp, lines 217-221 > > > > > > Would be nice to log something here. > > Anand Mazumdar wrote: > Logging an `ERROR` would be

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-06 Thread Anand Mazumdar
> On April 6, 2016, 5:10 p.m., Joseph Wu wrote: > > src/examples/long_lived_framework.cpp, line 593 > > > > > > Does the HTTP scheduler driver initialize glog (like the old scheduler > > driver does)? It doesn't.

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45800/ --- (Updated April 6, 2016, 5:45 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45800/#review127365 --- LGTM. src/examples/long_lived_framework.cpp (lines 216 - 220)

Re: Review Request 45800: Moved long running framework to use the v1 API.

2016-04-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45800/#review127286 --- Patch looks great! Reviews applied: [45067, 45440, 45799, 45800]