Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-17 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48450/ --- (Updated June 18, 2016, 2:33 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48450/#review138339 --- can you rebase this chain? - Vinod Kone On June 9, 2016, 11:13

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48450/#review138338 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 11:13 p.m.,

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-17 Thread haosdent huang
> On June 17, 2016, 6:20 a.m., haosdent huang wrote: > > src/tests/master_tests.cpp, line 2510 > > > > > > Should we add > > ``` > > .WillRepeatedly(Return()); > > ``` > > here, may receive

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-17 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48450/#review138265 --- Ship it! Ship It! - haosdent huang On June 9, 2016, 11:13

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-17 Thread Jay Guo
> On June 17, 2016, 6:20 a.m., haosdent huang wrote: > > src/tests/master_tests.cpp, line 2510 > > > > > > Should we add > > ``` > > .WillRepeatedly(Return()); > > ``` > > here, may receive

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-17 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48450/#review138168 --- src/tests/master_tests.cpp (line 2510)

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48450/#review138139 --- Ship it! Ship It! - Vinod Kone On June 9, 2016, 11:13 p.m.,

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48450/#review136940 --- Patch looks great! Reviews applied: [48400, 48401, 48449, 48046,

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-09 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48450/#review136898 --- src/tests/master_tests.cpp (lines 2495 - 2518)

Re: Review Request 48450: Add unit test for master /tasks endpoint.

2016-06-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48450/#review136746 --- Patch looks great! Reviews applied: [48400, 48401, 48449, 48046,