Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

2017-03-01 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/#review167345 --- Closing this review due to inactivity. Please see our

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

2016-07-21 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/ --- (Updated July 22, 2016, 12:34 a.m.) Review request for mesos and Benjamin

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

2016-07-21 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/ --- (Updated July 21, 2016, 11:44 p.m.) Review request for mesos and Benjamin

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

2016-07-21 Thread Klaus Ma
> On July 21, 2016, 7:44 a.m., Benjamin Mahler wrote: > > src/common/values.cpp, lines 589-594 > > > > > > Do we still need this? Seems to me that we want to do the following: > > > > ``` > > // Ranges.

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

2016-07-21 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/ --- (Updated July 21, 2016, 10:38 p.m.) Review request for mesos and Benjamin

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

2016-07-20 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/#review143028 --- Sorry for the delay, mostly some bugs around use of tokenize

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

2016-07-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/#review142483 --- Patch looks great! Reviews applied: [49223] Passed command:

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

2016-07-15 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/ --- (Updated July 16, 2016, 10:39 a.m.) Review request for mesos and Benjamin

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

2016-07-09 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/ --- (Updated July 9, 2016, 8:35 p.m.) Review request for mesos and Benjamin

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

2016-07-09 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/#review141396 --- Your patch cannot be applied with description exceed 72

Re: Review Request 49223: Fixed Value parsing code to only accept the canonical formats.

2016-07-09 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/ --- (Updated July 9, 2016, 3:54 p.m.) Review request for mesos and Benjamin