Re: Review Request 49688: Added cmake build variables for mesos tests.

2016-10-03 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/#review151254 --- This patch is probably not needed anymore. We already build the

Re: Review Request 49688: Added cmake build variables for mesos tests.

2016-09-07 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated Sept. 7, 2016, 6:33 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49688: Added cmake build variables for mesos tests.

2016-08-07 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated Aug. 8, 2016, 5:23 a.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49688: Added cmake build variables for mesos tests.

2016-08-02 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated Aug. 2, 2016, 3:32 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49688: Added cmake build variables for mesos tests.

2016-08-02 Thread Srinivas Brahmaroutu
> On Aug. 2, 2016, 1:17 a.m., Alex Clemmer wrote: > > src/tests/cmake/MesosTestsConfigure.cmake, line 76 > > > > > > This variable doesn't seem to exist. Did you mean the (eminently badly > > named)

Re: Review Request 49688: Added cmake build variables for mesos tests.

2016-08-01 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/#review144429 --- Ship it! Sorry, I should have marked this "fix it and ship it"

Re: Review Request 49688: Added cmake build variables for mesos tests.

2016-08-01 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/#review144424 --- src/tests/cmake/MesosTestsConfigure.cmake (line 74)

Re: Review Request 49688: Added cmake build variables for mesos tests.

2016-08-01 Thread Alex Clemmer
> On July 12, 2016, 4:16 a.m., Alex Clemmer wrote: > > src/tests/CMakeLists.txt, line 21 > > > > > > It looks like at least some of the following tests are missing, and I > > don't see them grep'ing the codebase.

Re: Review Request 49688: Added cmake build variables for mesos tests.

2016-07-19 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated July 19, 2016, 9:35 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49688: Added cmake build variables for mesos tests.

2016-07-19 Thread Srinivas Brahmaroutu
> On July 12, 2016, 4:16 a.m., Alex Clemmer wrote: > > cmake/MesosConfigure.cmake, lines 96-97 > > > > > > Hmm, this seems like it should break the build. We're defining these > > scripts in `MesosConfigure.cmake`

Re: Review Request 49688: Added cmake build variables for mesos tests.

2016-07-16 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated July 16, 2016, 8:33 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 49688: Added cmake build variables for mesos tests.

2016-07-12 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49688/ --- (Updated July 13, 2016, 12:37 a.m.) Review request for mesos, Alex Clemmer and