Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review151807 --- Ship it! I'll do some adjustment on the test when committing.

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Oct. 6, 2016, 4:28 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 50271: Created an isolator for Linux capabilities.

> On Oct. 2, 2016, 2:22 a.m., Jie Yu wrote: > > src/tests/containerizer/isolator_tests.cpp, lines 665-682 > > > > > > I am wondering if we can parameterize this as well? Yes we can :D Updated the RR to this

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Oct. 4, 2016, 5:03 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 50271: Created an isolator for Linux capabilities.

> On Oct. 2, 2016, 2:22 a.m., Jie Yu wrote: > > src/tests/containerizer/isolator_tests.cpp, line 378 > > > > > > I suggest we take `Option` here so that the caller > > can do: > > ``` > >

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Oct. 4, 2016, 3:08 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Sept. 29, 2016, 6:20 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Sept. 22, 2016, 11:48 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 50271: Created an isolator for Linux capabilities.

> On Sept. 20, 2016, 2:38 a.m., Jie Yu wrote: > > src/Makefile.am, line 834 > > > > > > This should belong linux files below? > > Benjamin Bannier wrote: > This isolator has no hard dependency on Linux so we

Re: Review Request 50271: Created an isolator for Linux capabilities.

> On Sept. 20, 2016, 2:38 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 1242-1251 > > > > > > I understand why you want to do this check, but we usually do not do > > such checks

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review149657 --- Patch looks great! Reviews applied: [51784, 51930, 51931, 52081,

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Sept. 20, 2016, 1:40 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 50271: Created an isolator for Linux capabilities.

> On Sept. 20, 2016, 4:38 a.m., Jie Yu wrote: > > src/Makefile.am, line 834 > > > > > > This should belong linux files below? This isolator has no hard dependency on Linux so we can build it on all platforms. I

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Sept. 20, 2016, 1:12 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review149587 --- Haven't looked at the tests yet. src/Makefile.am (line 833)

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review149505 --- Patch looks great! Reviews applied: [51784, 51930, 51931, 50271]

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Sept. 19, 2016, 4:21 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 50271: Created an isolator for Linux capabilities.

> On Sept. 10, 2016, 8:23 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/capabilities.cpp, lines 47-49 > > > > > > We need to have special case for command tasks (i.e., > >

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review148733 --- Patch looks great! Reviews applied: [51654, 50271] Passed

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Sept. 13, 2016, 1:52 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 50271: Created an isolator for Linux capabilities.

> On Sept. 8, 2016, 11:12 a.m., Jay Guo wrote: > > src/tests/containerizer/isolator_tests.cpp, line 1802 > > > > > > I think we need more comprehensive tests for all the cases listed in > > the matrix in design

Re: Review Request 50271: Created an isolator for Linux capabilities.

> On Sept. 10, 2016, 8:23 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/capabilities.cpp, lines 57-68 > > > > > > Do you know that `Set` supports union and intersection. I think here we > >

Re: Review Request 50271: Created an isolator for Linux capabilities.

> On Sept. 10, 2016, 2:34 a.m., Jie Yu wrote: > > Can you move tests into a separate patch? If you have no strong objections I would really like to keep them as part of this patch. - Benjamin --- This is an automatically generated

Re: Review Request 50271: Created an isolator for Linux capabilities.

> On Sept. 10, 2016, 6:23 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/linux/capabilities.cpp, lines 47-49 > > > > > > We need to have special case for command tasks (i.e., > >

Re: Review Request 50271: Created an isolator for Linux capabilities.

> On Sept. 8, 2016, 9:12 a.m., Jay Guo wrote: > > Could list test steps to verify functionalities? I tried following steps: > > // start master > > $ mesos-master --ip= --work_dir= > > // start agent > > $ sudo mesos-agent --master=: > > --work_dir= --isolation=linux/capabilities > >

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review148389 --- Can you move tests into a separate patch? - Jie Yu On Sept. 9,

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review148338 --- src/tests/containerizer/isolator_tests.cpp (lines 1825 - 1826)

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review148289 --- Patch looks great! Reviews applied: [51697, 50270, 50271]

Re: Review Request 50271: Created an isolator for Linux capabilities.

> On Sept. 8, 2016, 11:12 a.m., Jay Guo wrote: > > Could list test steps to verify functionalities? I tried following steps: > > // start master > > $ mesos-master --ip= --work_dir= > > // start agent > > $ sudo mesos-agent --master=: > > --work_dir= --isolation=linux/capabilities > >

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Sept. 8, 2016, 6:04 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review148162 --- Could list test steps to verify functionalities? I tried

Re: Review Request 50271: Created an isolator for Linux capabilities.

> On Sept. 6, 2016, 9 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/capabilities.hpp, line 41 > > > > > > are we consistent on 'override' keyword? I'd suggest we be consistent > > with other

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review148065 --- Patch looks great! Reviews applied: [51697, 50270, 50271]

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Sept. 7, 2016, 6:46 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review147891 --- src/slave/containerizer/mesos/isolators/capabilities.hpp (line

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review147886 --- include/mesos/slave/containerizer.proto (line 144)

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Sept. 6, 2016, 5:04 p.m.) Review request for mesos, Jay Guo and Jie

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Aug. 25, 2016, 5:18 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review145794 --- Patch looks great! Reviews applied: [50266, 50889, 51042, 51043,

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Aug. 15, 2016, 5:57 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review145651 --- Patch looks great! Reviews applied: [50266, 50889, 51042, 51043,

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Aug. 12, 2016, 6:48 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/#review145434 --- Bad patch! Reviews applied: [50271, 50270, 50269, 50889, 50266]

Re: Review Request 50271: Created an isolator for Linux capabilities.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50271/ --- (Updated Aug. 10, 2016, 7:03 p.m.) Review request for mesos and Jie Yu.